Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 774203003: Update Window API for CSSOM smooth scrolling to match the spec (Closed)

Created:
6 years ago by ajuma
Modified:
6 years ago
Reviewers:
Ian Vollick
CC:
blink-reviews, arv+blink, Inactive
Project:
blink
Visibility:
Public.

Description

Update Window API for CSSOM smooth scrolling to match the spec This updates the Window API for smooth scrolling to match changes to the CSSOM View spec. Previously, the spec added an optional ScrollBehavior argument to the scroll, scrollTo, and scrollBy methods. Now, the spec instead defines overloads of scroll, scrollTo, and scrollBy that take a single ScrollToOptions dictionary. Smooth scrolling is behind a runtime flag. Spec: http://dev.w3.org/csswg/cssom-view/#extensions-to-the-window-interface BUG=243871 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186465

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 3

Patch Set 4 : Add test cases #

Patch Set 5 : Update expected results #

Unified diffs Side-by-side diffs Delta from patch set Stats (+335 lines, -128 lines) Patch
M LayoutTests/fast/dom/Window/window-scroll-arguments.html View 5 chunks +51 lines, -33 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-scroll-arguments-expected.txt View 2 chunks +51 lines, -33 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/main-frame-interrupted-scroll.html View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/main-frame-scroll.html View 1 2 3 2 chunks +21 lines, -3 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/main-frame-scroll-expected.txt View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/main-frame-scrollBy.html View 1 2 3 2 chunks +20 lines, -3 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/main-frame-scrollBy-expected.txt View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/main-frame-scrollTo.html View 1 2 3 2 chunks +21 lines, -3 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/main-frame-scrollTo-expected.txt View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/subframe-interrupted-scroll.html View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/subframe-scroll.html View 1 2 3 2 chunks +21 lines, -3 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/subframe-scroll-expected.txt View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/subframe-scrollBy.html View 1 2 3 2 chunks +20 lines, -3 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/subframe-scrollBy-expected.txt View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/subframe-scrollTo.html View 1 2 3 2 chunks +22 lines, -4 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/subframe-scrollTo-expected.txt View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/core.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/frame/DOMWindow.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 4 chunks +48 lines, -24 lines 0 comments Download
M Source/core/frame/ScrollOptions.idl View 1 chunk +4 lines, -2 lines 0 comments Download
A Source/core/frame/ScrollToOptions.idl View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/frame/Window.idl View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ajuma
https://codereview.chromium.org/774203003/diff/40001/Source/core/frame/LocalDOMWindow.cpp File Source/core/frame/LocalDOMWindow.cpp (left): https://codereview.chromium.org/774203003/diff/40001/Source/core/frame/LocalDOMWindow.cpp#oldcode1435 Source/core/frame/LocalDOMWindow.cpp:1435: exceptionState.throwTypeError("The ScrollBehavior provided is invalid."); We get this error ...
6 years ago (2014-12-03 19:11:51 UTC) #2
Ian Vollick
https://codereview.chromium.org/774203003/diff/40001/Source/core/frame/LocalDOMWindow.cpp File Source/core/frame/LocalDOMWindow.cpp (right): https://codereview.chromium.org/774203003/diff/40001/Source/core/frame/LocalDOMWindow.cpp#newcode1520 Source/core/frame/LocalDOMWindow.cpp:1520: scaledY = currentOffset.y(); There appears to be a real ...
6 years ago (2014-12-03 20:20:56 UTC) #3
ajuma
https://codereview.chromium.org/774203003/diff/40001/Source/core/frame/LocalDOMWindow.cpp File Source/core/frame/LocalDOMWindow.cpp (right): https://codereview.chromium.org/774203003/diff/40001/Source/core/frame/LocalDOMWindow.cpp#newcode1520 Source/core/frame/LocalDOMWindow.cpp:1520: scaledY = currentOffset.y(); On 2014/12/03 20:20:55, vollick wrote: > ...
6 years ago (2014-12-03 21:02:01 UTC) #4
Ian Vollick
On 2014/12/03 21:02:01, ajuma wrote: > https://codereview.chromium.org/774203003/diff/40001/Source/core/frame/LocalDOMWindow.cpp > File Source/core/frame/LocalDOMWindow.cpp (right): > > https://codereview.chromium.org/774203003/diff/40001/Source/core/frame/LocalDOMWindow.cpp#newcode1520 > ...
6 years ago (2014-12-03 23:18:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/774203003/80001
6 years ago (2014-12-04 00:01:18 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-04 01:14:33 UTC) #8
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186465

Powered by Google App Engine
This is Rietveld 408576698