Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Unified Diff: Source/core/frame/DOMWindow.h

Issue 774203003: Update Window API for CSSOM smooth scrolling to match the spec (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update expected results Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/frame/LocalDOMWindow.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/DOMWindow.h
diff --git a/Source/core/frame/DOMWindow.h b/Source/core/frame/DOMWindow.h
index 130a79f5d5c072c9b915d0e1ebc49daaff663d8a..a22423ca00e801663036349f6886995cc7dbdc1f 100644
--- a/Source/core/frame/DOMWindow.h
+++ b/Source/core/frame/DOMWindow.h
@@ -32,7 +32,7 @@ class Navigator;
class Performance;
class RequestAnimationFrameCallback;
class Screen;
-class ScrollOptions;
+class ScrollToOptions;
class SerializedScriptValue;
class Storage;
class StyleMedia;
@@ -143,11 +143,11 @@ public:
virtual bool find(const String&, bool caseSensitive, bool backwards, bool wrap, bool wholeWord, bool searchInFrames, bool showDialog) const = 0;
virtual void scrollBy(double x, double y, ScrollBehavior = ScrollBehaviorAuto) const = 0;
- virtual void scrollBy(double x, double y, const ScrollOptions&, ExceptionState&) const = 0;
- virtual void scrollTo(double x, double y, ScrollBehavior = ScrollBehaviorAuto) const = 0;
- virtual void scrollTo(double x, double y, const ScrollOptions&, ExceptionState&) const = 0;
+ virtual void scrollBy(const ScrollToOptions&) const = 0;
+ virtual void scrollTo(double x, double y) const = 0;
+ virtual void scrollTo(const ScrollToOptions&) const = 0;
void scroll(double x, double y) const { scrollTo(x, y); }
- void scroll(double x, double y, const ScrollOptions& scrollOptions, ExceptionState& exceptionState) const { scrollTo(x, y, scrollOptions, exceptionState); }
+ void scroll(const ScrollToOptions& scrollToOptions) const { scrollTo(scrollToOptions); }
virtual void moveBy(float x, float y) const = 0;
virtual void moveTo(float x, float y) const = 0;
« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/frame/LocalDOMWindow.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698