Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2173)

Issue 7740080: The order of evaluation in parseInt is wrong. (Closed)

Created:
8 years, 11 months ago by shinyak (Google)
Modified:
8 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

The spec (15.1.2.2 parseInt (string , radix)) says ToString should be called before ToInt32. http://www.ecma-international.org/publications/files/ECMA-ST/Ecma-262.pdf In the current implementation, the order is reversed. So this webkit test (https://bugs.webkit.org/show_bug.cgi?id=65366) fails on Chromium. BUG=1649 TEST=parse-int-float.js Committed: http://code.google.com/p/v8/source/detail?r=9116

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M src/v8natives.js View 1 chunk +4 lines, -1 line 0 comments Download
M test/mjsunit/parse-int-float.js View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Lasse Reichstein
8 years, 11 months ago (2011-09-02 11:36:27 UTC) #1
LGTM. I'll land it.

Powered by Google App Engine
This is Rietveld 408576698