Issue 7739025: Fix an inlining bug on the 3.3 branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7739025: Fix an inlining bug on the 3.3 branch. (Closed)

Created:
9 years, 3 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 3 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/3.3

Visibility:
Public.

Description

Fix an inlining bug on the 3.3 branch. When inlining a function in a test context, it's possible that control flow does not reach one or both of the branch targets. In that case we should not try to construct a flow graph from that target. This bug has been fixed on the 3.4 branch and later, but was present on 3.3 and earlier. R=vegorov@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9144

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -7 lines)			Patch
	M	src/hydrogen.cc	View		1 chunk	+10 lines, -6 lines	0 comments	Download
	M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages