Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 773333002: Fix the rightOf and below conditions for overlapping case. (Closed)

Created:
6 years ago by c.shu
Modified:
6 years ago
Reviewers:
Krzysztof Olczyk, fs
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fix the rightOf and below conditions for overlapping case. For the overlapping rects, |a| is considered to be below |b| if both edges of |a| are below the respective ones of |b|. In the code, we should make sure the rects are actually overlapping. For example, __ __ | a| __ |b'| |__| | b|| | |__||__| Before the patch, |b| and |b'| are considered below |a|, which is not intuitively true. With the patch, they are no longer below |a|. The rightOf-case is handled in an analog fashion. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186731

Patch Set 1 #

Patch Set 2 : address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -88 lines) Patch
A + LayoutTests/fast/spatial-navigation/snav-not-below.html View 1 1 chunk +13 lines, -34 lines 0 comments Download
A + LayoutTests/fast/spatial-navigation/snav-not-below-expected.txt View 1 1 chunk +6 lines, -9 lines 0 comments Download
A + LayoutTests/fast/spatial-navigation/snav-not-rightof.html View 1 1 chunk +11 lines, -32 lines 0 comments Download
A + LayoutTests/fast/spatial-navigation/snav-not-rightof-expected.txt View 1 1 chunk +6 lines, -9 lines 0 comments Download
M LayoutTests/fast/spatial-navigation/snav-z-index.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/spatial-navigation/snav-z-index-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/SpatialNavigation.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (5 generated)
c.shu
6 years ago (2014-12-03 20:49:14 UTC) #2
Krzysztof Olczyk
lgtm
6 years ago (2014-12-04 09:21:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/773333002/1
6 years ago (2014-12-04 14:12:37 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years ago (2014-12-04 14:12:39 UTC) #7
c.shu
On 2014/12/04 14:12:39, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years ago (2014-12-04 14:16:18 UTC) #8
tkent
I don't review snav patches. +fs
6 years ago (2014-12-05 01:14:37 UTC) #10
fs
What does this fix, could you add a test (rather than just removing one - ...
6 years ago (2014-12-05 09:42:04 UTC) #11
c.shu
On 2014/12/05 09:42:04, fs wrote: > What does this fix, could you add a test ...
6 years ago (2014-12-05 16:12:14 UTC) #12
Krzysztof Olczyk
On 2014/12/05 at 16:12:14, c.shu wrote: > On 2014/12/05 09:42:04, fs wrote: > > What ...
6 years ago (2014-12-08 07:36:39 UTC) #13
fs
On 2014/12/08 07:36:39, Krzysztof Olczyk wrote: > On 2014/12/05 at 16:12:14, c.shu wrote: > > ...
6 years ago (2014-12-08 09:55:51 UTC) #14
c.shu
> Now this certainly counts as a motivation, and should preferably go in the > ...
6 years ago (2014-12-08 17:10:07 UTC) #15
fs
Thanks, lgtm. But please line-wrap the description and mention that the rightOf-case is handled in ...
6 years ago (2014-12-08 17:17:06 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/773333002/20001
6 years ago (2014-12-08 19:53:43 UTC) #18
c.shu
On 2014/12/08 17:17:06, fs wrote: > Thanks, lgtm. > > But please line-wrap the description ...
6 years ago (2014-12-08 19:55:01 UTC) #19
commit-bot: I haz the power
6 years ago (2014-12-08 21:28:18 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186731

Powered by Google App Engine
This is Rietveld 408576698