Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: LayoutTests/fast/spatial-navigation/snav-not-below.html

Issue 773333002: Fix the rightOf and below conditions for overlapping case. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: address review comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/spatial-navigation/snav-not-below-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/spatial-navigation/snav-not-below.html
diff --git a/LayoutTests/fast/spatial-navigation/snav-overlapping-elements.html b/LayoutTests/fast/spatial-navigation/snav-not-below.html
similarity index 61%
copy from LayoutTests/fast/spatial-navigation/snav-overlapping-elements.html
copy to LayoutTests/fast/spatial-navigation/snav-not-below.html
index f5679a8825e93281a111665c9feba535024a8529..fa8066dabf79be9ef459de7c130dff7e480b354f 100644
--- a/LayoutTests/fast/spatial-navigation/snav-overlapping-elements.html
+++ b/LayoutTests/fast/spatial-navigation/snav-not-below.html
@@ -12,61 +12,40 @@ body a {
}
#e1 {
left: 10px;
- top: 10px;
+ top: 210px;
}
#e2 {
- left: 20px;
- top: 75px;
+ left: 120px;
+ top: 250px;
}
#e3 {
- left: 10px;
- top: 150px;
-}
-#e4 {
- left: 10px;
- top: 300px;
-}
-#e5 {
- left: 75px;
- top: 300px;
-}
-#e6 {
- left: 150px;
- top: 300px;
+ left: 250px;
+ top: 250px;
+ height: 120px;
}
</style>
<body id="some-content" onload="runTest()">
<p id="description"></p>
<div id="elements">
-<!-- Vertical: -->
<a id="e1" href="#e1">Element 1</a>
<a id="e2" href="#e2">Element 2</a>
<a id="e3" href="#e3">Element 3</a>
-<!-- Horizontal: -->
-<a id="e4" href="#e1">Element 4</a>
-<a id="e5" href="#e2">Element 5</a>
-<a id="e6" href="#e3">Element 6</a>
</div>
<div id="console"></div>
<script type="application/javascript">
-description('This test ensures that Spatial Navigation works with overlapping elements');
+description('This test ensures that e2 is NOT below e1 and e3 is NOT below e2.');
jsTestIsAsync = true;
var resultMap = [
- // Vertical:
+ ["Down", "e1"],
+ ["Right", "e2"],
["Down", "e2"],
- ["Down", "e3"],
+ ["Right", "e3"],
+ ["Up", "e3"],
+ ["Left", "e2"],
["Up", "e2"],
- ["Up", "e1"],
- ["Down", "e2"],
- ["Down", "e3"],
- ["Down", "e4"],
- // Horizontal:
- ["Right", "e5"],
- ["Right", "e6"],
- ["Left", "e5"],
- ["Left", "e4"],
+ ["Left", "e1"],
["DONE", "DONE"]
];
« no previous file with comments | « no previous file | LayoutTests/fast/spatial-navigation/snav-not-below-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698