Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 773323002: Upload picture byte size and op count metrics for SKP recording. (Closed)

Created:
6 years ago by mtklein_C
Modified:
6 years ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Upload picture byte size and op count metrics for SKP recording. Look okay? { "results" : { "desk_amazon.skp_1264_3999" : { "nonrendering" : { "bytes" : 75656, "max_ms" : 1.150187, "mean_ms" : 1.150187, "median_ms" : 1.150187, "min_ms" : 1.150187, "ops" : 659, "options" : { "bench_type" : "recording", "clip" : "0 0 1000 1000", "name" : "desk_amazon.skp", "scale" : "1", "source_type" : "skp" } } }, ... BUG=skia: Committed: https://skia.googlesource.com/skia/+/051e56df8f14fae68f0e990f78b85494c2ce4a6b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M bench/ResultsWriter.h View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/nanobench.cpp View 5 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mtklein
6 years ago (2014-12-03 19:57:14 UTC) #2
jcgregorio
lgtm
6 years ago (2014-12-04 16:33:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/773323002/1
6 years ago (2014-12-04 16:37:02 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-04 16:46:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/051e56df8f14fae68f0e990f78b85494c2ce4a6b

Powered by Google App Engine
This is Rietveld 408576698