Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1158)

Unified Diff: bench/ResultsWriter.h

Issue 773323002: Upload picture byte size and op count metrics for SKP recording. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | bench/nanobench.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bench/ResultsWriter.h
diff --git a/bench/ResultsWriter.h b/bench/ResultsWriter.h
index b8d97075a10bd150102007ede8e5f3febd403e14..f53a980de43d87c79e3ff45570e7064fdcdaf594 100644
--- a/bench/ResultsWriter.h
+++ b/bench/ResultsWriter.h
@@ -34,7 +34,7 @@ public:
virtual void property(const char name[], const char value[]) {}
// Denote the start of a specific benchmark. Once bench is called,
- // then config and timer can be called multiple times to record runs.
+ // then config and metric can be called multiple times to record runs.
virtual void bench(const char name[], int32_t x, int32_t y) {}
// Record the specific configuration a bench is run under, such as "8888".
@@ -44,7 +44,7 @@ public:
virtual void configOption(const char name[], const char* value) {}
// Record a single test metric.
- virtual void timer(const char name[], double ms) {}
+ virtual void metric(const char name[], double ms) {}
// Flush to storage now please.
virtual void flush() {}
@@ -105,7 +105,7 @@ public:
virtual void configOption(const char name[], const char* value) {
(*fConfig)["options"][name] = value;
}
- virtual void timer(const char name[], double ms) {
+ virtual void metric(const char name[], double ms) {
// Don't record if nan, or -nan.
if (sk_double_isnan(ms)) {
return;
« no previous file with comments | « no previous file | bench/nanobench.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698