ServiceWorker: remove get_newest_worker() helper (cleanup)

ServiceWorker: remove get_newest_worker() helper (cleanup)

It looks we can just use registration.installing now.

BUG=425900
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186458

[kinuko, 2014-12-03 09:14:57]

kinuko@chromium.org changed reviewers:
+ falken@chromium.org

[kinuko, 2014-12-03 09:17:20]

(Low priority; just want to do some patch exercise)

[falken, 2014-12-03 10:09:05]

falken@chromium.org changed reviewers:
+ nhiroki@chromium.org

[falken, 2014-12-03 10:09:06]

I think we can just replace get_newest_worker() with registration.installing
(see registration-service-worker-attributes.html).

+nhiroki, who added get_newest_worker in
https://codereview.chromium.org/580033002, I think when trying to track down
Windows timeouts that were probably due to crbug.com/431172.

Side note: Looks like there's a lot of tests that unnecessarily call
wait_for_update() in order to get a worker, when they can just use
registration.installing.

[kinuko, 2014-12-03 10:37:50]

Thanks!

On 2014/12/03 10:09:06, falken wrote:
> I think we can just replace get_newest_worker() with registration.installing
> (see registration-service-worker-attributes.html).

Yup I wondered if that's the case.
 
> +nhiroki, who added get_newest_worker in
> https://codereview.chromium.org/580033002, I think when trying to track down
> Windows timeouts that were probably due to crbug.com/431172.
> 
> Side note: Looks like there's a lot of tests that unnecessarily call
> wait_for_update() in order to get a worker, when they can just use
> registration.installing.

I can fix up them too (in a separate patch) if that's desirable :)

[nhiroki, 2014-12-03 14:59:35]

On 2014/12/03 10:37:50, kinuko wrote:
> Thanks!
> 
> On 2014/12/03 10:09:06, falken wrote:
> > I think we can just replace get_newest_worker() with registration.installing
> > (see registration-service-worker-attributes.html).
> 
> Yup I wondered if that's the case.
>  
> > +nhiroki, who added get_newest_worker in
> > https://codereview.chromium.org/580033002, I think when trying to track down
> > Windows timeouts that were probably due to crbug.com/431172.

You're right. I think "get_newest_worker" fulfilled its role, so let's remove
it.

> > Side note: Looks like there's a lot of tests that unnecessarily call
> > wait_for_update() in order to get a worker, when they can just use
> > registration.installing.
> 
> I can fix up them too (in a separate patch) if that's desirable :)

Good! Those are also legacies of the past age. Let's remove them, too :D

[kinuko, 2014-12-03 15:58:20]

Patchset #2 (id:20001) has been deleted

[kinuko, 2014-12-03 15:59:03]

Updated. PTAL

[falken, 2014-12-03 16:20:14]

lgtm

[nhiroki, 2014-12-03 23:32:27]

lgtm2, thanks!

[nhiroki, 2014-12-03 23:32:45]

On 2014/12/03 23:32:27, nhiroki wrote:
> lgtm2, thanks!

lgtm...

[kinuko, 2014-12-03 23:48:37]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2014-12-03 23:48:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/773153002/40001

[commit-bot: I haz the power, 2014-12-03 23:50:57]

Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186458