Issue 580033002: ServiceWorker: Stabilize install-phase-event-waituntil.html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 580033002: ServiceWorker: Stabilize install-phase-event-waituntil.html (Closed)

Created:
6 years, 3 months ago by nhiroki

Modified:
6 years, 3 months ago

Reviewers:
horo

CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

ServiceWorker: Stabilize install-phase-event-waituntil.html 'install-phase-event-waituntil.html' often causes a timeout on windows and I suspect that the intended 'statechange' event could be fired before setting the event handler. To avoid timeouts, this CL makes the test use more stabilized wait_for_update() helper introduced by https://src.chromium.org/viewvc/blink?revision=182220&view=revision BUG=405847 TEST=run_webkit_tests.py --debug http/tests/serviceworker/install-phase-event-waituntil.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182229

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -53 lines)			Patch
	M	LayoutTests/http/tests/serviceworker/install-phase-event-waituntil.html	View		7 chunks	+48 lines, -53 lines	0 comments	Download
	M	LayoutTests/http/tests/serviceworker/resources/test-helpers.js	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/580033002/1

6 years, 3 months ago (2014-09-18 10:01:57 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-18 10:08:18 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 182229

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages