Issue 773113006: Fix/reland 505555fa8031fc06d67e9ed43e3021d8d84cb44f (crrev.com/773983002).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 773113006: Fix/reland 505555fa8031fc06d67e9ed43e3021d8d84cb44f (crrev.com/773983002). (Closed)

Created:
6 years ago by viettrungluu

Modified:
6 years ago

Reviewers:
yzshen1

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix/reland 505555fa8031fc06d67e9ed43e3021d8d84cb44f (crrev.com/773983002). This adds ChannelEndpoint::ResetChannelNoLock(). I needed to set is_detached_from_channel_ in a bunch of other places. R=yzshen@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/20b24ee7520f22272c6dd2983bc5cc86a7ec12c3

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+129 lines, -55 lines)			Patch
M	mojo/edk/system/channel_endpoint.h	View	4 chunks	+19 lines, -0 lines	0 comments	Download
M	mojo/edk/system/channel_endpoint.cc	View	6 chunks	+81 lines, -37 lines	0 comments	Download
M	mojo/edk/system/channel_endpoint_client.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	mojo/edk/system/message_pipe.h	View	2 chunks	+6 lines, -7 lines	0 comments	Download
M	mojo/edk/system/message_pipe.cc	View	4 chunks	+20 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

6 years ago (2014-12-03 18:56:30 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
20b24ee7520f22272c6dd2983bc5cc86a7ec12c3 (presubmit successful).

Expand Messages | Collapse Messages