mojo/edk/system/channel_endpoint_client.h - Issue 773113006: Fix/reland 505555fa8031fc06d67e9ed43e3021d8d84cb44f (crrev.com/773983002).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/edk/system/channel_endpoint_client.h

Issue 773113006: Fix/reland 505555fa8031fc06d67e9ed43e3021d8d84cb44f (crrev.com/773983002). (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/edk/system/channel_endpoint_client.h

diff --git a/mojo/edk/system/channel_endpoint_client.h b/mojo/edk/system/channel_endpoint_client.h

index 7a7d5b8044548a5128f610bed99af7acf72974a8..c758e9c5485e4533d158b930548fc42e19084475 100644

--- a/mojo/edk/system/channel_endpoint_client.h

+++ b/mojo/edk/system/channel_endpoint_client.h

@@ -38,8 +38,9 @@ class MOJO_SYSTEM_IMPL_EXPORT ChannelEndpointClient

// called by |Channel| when it receives a message for the |ChannelEndpoint|.

// (|port| is the value passed to |ChannelEndpoint|'s constructor as

// |client_port|.)

- virtual void OnReadMessage(unsigned port,

- scoped_ptr<MessageInTransit> message) = 0;

+ //

+ // This should return true if it accepted (and took ownership of) |message|.

+ virtual bool OnReadMessage(unsigned port, MessageInTransit* message) = 0;

// Called by |ChannelEndpoint| when the |Channel| is relinquishing its pointer

// to the |ChannelEndpoint| (and vice versa). After this is called,

« no previous file with comments | « mojo/edk/system/channel_endpoint.cc ('k') | mojo/edk/system/message_pipe.h » ('j') | no next file with comments »