Remove NOTIFICATION_HISTORY_URLS_DELETED

chrome/browser/history/history_notifications.h

Index: chrome/browser/history/history_notifications.h
diff --git a/chrome/browser/history/history_notifications.h b/chrome/browser/history/history_notifications.h
index 6178b99a2780a8bd79d8fe6d83f478df942501ba..c499a42c4c453b903aa06ed1b148acee1ce6c0a7 100644
--- a/chrome/browser/history/history_notifications.h
+++ b/chrome/browser/history/history_notifications.h
@@ -16,7 +16,7 @@
 
 namespace history {
 
-// Details for NOTIFICATION_HISTORY_TYPED_URLS_MODIFIED.
+// Details for History URLs Modified Notification.
 struct URLsModifiedDetails : public HistoryDetails {

[sdefresne, 2014/12/04 17:21:13]

Please delete this struct, it is no longer used.

[nshaik, 2014/12/07 09:34:50]

Done.

   URLsModifiedDetails();
   ~URLsModifiedDetails() override;
@@ -26,9 +26,13 @@ struct URLsModifiedDetails : public HistoryDetails {
   URLRows changed_urls;
 };
 
-// Details for NOTIFICATION_HISTORY_URLS_DELETED.
+// Details for History URLs Deleted Notification.
 struct URLsDeletedDetails : public HistoryDetails {

[sdefresne, 2014/12/04 17:21:13]

I'd like to get this removed; please see my comments about NotifyURLsDeleted and
OnURLsDeleted on how to do it.

[nshaik, 2014/12/07 09:34:50]

had the same thoughts. done.

   URLsDeletedDetails();
+  URLsDeletedDetails(bool all_history,
+                     bool expired,
+                     const URLRows& rows,
+                     const std::set<GURL>& favicon_urls);
   ~URLsDeletedDetails() override;
 
   // Set when all history was deleted. False means just a subset was deleted.