Remove NOTIFICATION_HISTORY_URLS_DELETED

chrome/browser/history/history_notifications.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Structs that hold data used in broadcasting notifications.
 
 #ifndef CHROME_BROWSER_HISTORY_HISTORY_NOTIFICATIONS_H__
 #define CHROME_BROWSER_HISTORY_HISTORY_NOTIFICATIONS_H__
 
 #include <set>
 
 #include "chrome/browser/history/history_details.h"
 #include "components/history/core/browser/history_types.h"
 #include "components/history/core/browser/keyword_id.h"
 #include "url/gurl.h"
 
 namespace history {
 
-// Details for NOTIFICATION_HISTORY_TYPED_URLS_MODIFIED.
+// Details for History URLs Modified Notification.
 struct URLsModifiedDetails : public HistoryDetails {

[sdefresne, 2014/12/04 17:21:13]

Please delete this struct, it is no longer used.

[nshaik, 2014/12/07 09:34:50]

Done.

   URLsModifiedDetails();
   ~URLsModifiedDetails() override;
 
   // Lists the information for each of the URLs affected. The rows will have the
   // IDs that are currently in effect in the main history database.
   URLRows changed_urls;
 };
 
-// Details for NOTIFICATION_HISTORY_URLS_DELETED.
+// Details for History URLs Deleted Notification.
 struct URLsDeletedDetails : public HistoryDetails {

[sdefresne, 2014/12/04 17:21:13]

I'd like to get this removed; please see my comments about NotifyURLsDeleted and
OnURLsDeleted on how to do it.

[nshaik, 2014/12/07 09:34:50]

had the same thoughts. done.

   URLsDeletedDetails();
+  URLsDeletedDetails(bool all_history,
+                     bool expired,
+                     const URLRows& rows,
+                     const std::set<GURL>& favicon_urls);
   ~URLsDeletedDetails() override;
 
   // Set when all history was deleted. False means just a subset was deleted.
   bool all_history;
 
   // True if the data was expired due to old age. False if the data was deleted
   // in response to an explicit user action through the History UI.
   bool expired;
 
   // The URLRows of URLs deleted. This is valid only when |all_history| is false
@@ skipping 26 matching lines @@
   explicit KeywordSearchDeletedDetails(URLID url_row_id);
   ~KeywordSearchDeletedDetails() override;
 
   // The ID of the corresponding URLRow in the main history database.
   URLID url_row_id;
 };
 
 }  // namespace history
 
 #endif  // CHROME_BROWSER_HISTORY_HISTORY_NOTIFICATIONS_H__