Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 772893004: Adds constants and runner for animations (Closed)

Created:
6 years ago by sky
Modified:
6 years ago
Reviewers:
Elliot Glaysher
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Adds constants and runner for animations Its not yet wired up to anything, but the basics and plumbing are there. I'm hoping this is rich enough for animations we want to support. BUG=434429 TEST=none R=erg@chromium.org, ben@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a8c2431189efa7d3103d71ad45430a064fcf1cf0

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 4

Patch Set 3 : merge to trunk #

Patch Set 4 : animations.mojom #

Patch Set 5 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1461 lines, -37 lines) Patch
M mojo/services/public/interfaces/view_manager/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A mojo/services/public/interfaces/view_manager/animations.mojom View 1 2 3 1 chunk +61 lines, -0 lines 0 comments Download
M services/view_manager/BUILD.gn View 1 2 3 4 6 chunks +12 lines, -0 lines 0 comments Download
A services/view_manager/animation_runner.h View 1 1 chunk +73 lines, -0 lines 0 comments Download
A services/view_manager/animation_runner.cc View 1 1 chunk +112 lines, -0 lines 0 comments Download
A services/view_manager/animation_runner_observer.h View 1 chunk +27 lines, -0 lines 0 comments Download
A services/view_manager/animation_runner_unittest.cc View 1 chunk +505 lines, -0 lines 0 comments Download
A services/view_manager/scheduled_animation_group.h View 1 2 3 1 chunk +110 lines, -0 lines 0 comments Download
A services/view_manager/scheduled_animation_group.cc View 1 chunk +345 lines, -0 lines 0 comments Download
A services/view_manager/scheduled_animation_group_unittest.cc View 1 2 3 1 chunk +89 lines, -0 lines 0 comments Download
M services/view_manager/server_view.h View 4 chunks +6 lines, -1 line 0 comments Download
M services/view_manager/server_view.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M services/view_manager/server_view_delegate.h View 1 chunk +2 lines, -0 lines 0 comments Download
A services/view_manager/test_server_view_delegate.h View 1 chunk +49 lines, -0 lines 0 comments Download
A services/view_manager/test_server_view_delegate.cc View 1 chunk +59 lines, -0 lines 0 comments Download
M services/view_manager/view_coordinate_conversions_unittest.cc View 2 chunks +2 lines, -36 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
sky
6 years ago (2014-12-03 00:15:59 UTC) #1
sky
Ben's busy, so ben->erg
6 years ago (2014-12-03 22:55:42 UTC) #3
Elliot Glaysher
https://codereview.chromium.org/772893004/diff/20001/mojo/services/public/interfaces/view_manager/view_manager_constants.mojom File mojo/services/public/interfaces/view_manager/view_manager_constants.mojom (right): https://codereview.chromium.org/772893004/diff/20001/mojo/services/public/interfaces/view_manager/view_manager_constants.mojom#newcode28 mojo/services/public/interfaces/view_manager/view_manager_constants.mojom:28: struct AnimationValue { You may want to have these ...
6 years ago (2014-12-03 23:49:59 UTC) #4
sky
https://codereview.chromium.org/772893004/diff/20001/mojo/services/public/interfaces/view_manager/view_manager_constants.mojom File mojo/services/public/interfaces/view_manager/view_manager_constants.mojom (right): https://codereview.chromium.org/772893004/diff/20001/mojo/services/public/interfaces/view_manager/view_manager_constants.mojom#newcode28 mojo/services/public/interfaces/view_manager/view_manager_constants.mojom:28: struct AnimationValue { On 2014/12/03 23:49:59, Elliot Glaysher wrote: ...
6 years ago (2014-12-04 00:21:23 UTC) #5
Elliot Glaysher
lgtm
6 years ago (2014-12-04 18:51:17 UTC) #6
sky
6 years ago (2014-12-04 19:26:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
a8c2431189efa7d3103d71ad45430a064fcf1cf0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698