Issue 772853003: Cleanup: Remove NativesCollection<.>::*Raw* methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 772853003: Cleanup: Remove NativesCollection<.>::Raw methods. (Closed)

Created:
6 years ago by vogelheim

Modified:
6 years ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

More Reviews

Description

Cleanup: Remove NativesCollection<.>::*Raw* methods. These methods for used for compressed libraries, where GetSource* functions contained the compressed sources and [GS]etRawSource* the uncompressed sources. This is dead code since the API no longer supports compression. (If you need/want compressed sources, use the external startup data and compress/uncompress on the Embedder's side.) BUG=

Patch Set 1 #

Patch Set 2 : Fix compile. #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -85 lines)			Patch
M	src/bootstrapper.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/d8.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/natives.h	View		2 chunks	+2 lines, -8 lines	0 comments	Download
M	src/natives-external.cc	View	1	4 chunks	+11 lines, -27 lines	0 comments	Download
M	src/serialize.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-log.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	tools/js2c.py	View		6 chunks	+11 lines, -42 lines	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/772853003/40001

6 years ago (2014-12-04 18:25:27 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:40001)