Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: src/natives-external.cc

Issue 772853003: Cleanup: Remove NativesCollection<.>::*Raw* methods. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix compile. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/natives.h ('k') | src/serialize.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/natives-external.cc
diff --git a/src/natives-external.cc b/src/natives-external.cc
index 75e866b1b0876937daa3203dcd98772ebb708fcb..b0e1606f2b8c6a7d775fd07ae4f17e2447a8afea 100644
--- a/src/natives-external.cc
+++ b/src/natives-external.cc
@@ -32,12 +32,12 @@ class NativesStore {
int GetBuiltinsCount() { return native_ids_.length(); }
int GetDebuggerCount() { return debugger_count_; }
- Vector<const char> GetScriptName(int index) { return native_names_[index]; }
-
- Vector<const char> GetRawScriptSource(int index) {
+ Vector<const char> GetScriptSource(int index) {
return native_source_[index];
}
+ Vector<const char> GetScriptName(int index) { return native_names_[index]; }
+
int GetIndex(const char* id) {
for (int i = 0; i < native_ids_.length(); ++i) {
int native_id_length = native_ids_[i].length();
@@ -50,14 +50,9 @@ class NativesStore {
return -1;
}
- int GetRawScriptsSize() {
- DCHECK(false); // Used for compression. Doesn't really make sense here.
- return 0;
- }
-
- Vector<const byte> GetScriptsSource() {
- DCHECK(false); // Used for compression. Doesn't really make sense here.
- return Vector<const byte>();
+ Vector<const char> GetScriptsSource() {
+ DCHECK(false); // Not implemented.
+ return Vector<const char>();
}
static NativesStore* MakeFromScriptsSource(SnapshotByteSource* source) {
@@ -177,14 +172,9 @@ int NativesCollection<type>::GetIndex(const char* name) {
return NativesHolder<type>::get()->GetIndex(name);
}
-template<NativeType type>
-int NativesCollection<type>::GetRawScriptsSize() {
- return NativesHolder<type>::get()->GetRawScriptsSize();
-}
-
-template<NativeType type>
-Vector<const char> NativesCollection<type>::GetRawScriptSource(int index) {
- return NativesHolder<type>::get()->GetRawScriptSource(index);
+template <NativeType type>
+Vector<const char> NativesCollection<type>::GetScriptSource(int index) {
+ return NativesHolder<type>::get()->GetScriptSource(index);
}
template<NativeType type>
@@ -192,17 +182,11 @@ Vector<const char> NativesCollection<type>::GetScriptName(int index) {
return NativesHolder<type>::get()->GetScriptName(index);
}
-template<NativeType type>
-Vector<const byte> NativesCollection<type>::GetScriptsSource() {
+template <NativeType type>
+Vector<const char> NativesCollection<type>::GetScriptsSource() {
return NativesHolder<type>::get()->GetScriptsSource();
}
-template<NativeType type>
-void NativesCollection<type>::SetRawScriptsSource(
- Vector<const char> raw_source) {
- CHECK(false); // Use SetNativesFromFile for this implementation.
-}
-
// The compiler can't 'see' all uses of the static methods and hence
// my chose to elide them. This we'll explicitly instantiate these.
« no previous file with comments | « src/natives.h ('k') | src/serialize.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698