sky/engine/core/editing/DeleteSelectionCommand.cpp - Issue 772743004: Remove more Node API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/editing/DeleteSelectionCommand.cpp

Issue 772743004: Remove more Node API. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/editing/DeleteSelectionCommand.cpp

diff --git a/sky/engine/core/editing/DeleteSelectionCommand.cpp b/sky/engine/core/editing/DeleteSelectionCommand.cpp

index ffea090f7eb32a5e017e65ab4de036af71c439b9..1c6925ae645cef658e0e9c733e5c11054a6e5974 100644

--- a/sky/engine/core/editing/DeleteSelectionCommand.cpp

+++ b/sky/engine/core/editing/DeleteSelectionCommand.cpp

@@ -358,7 +358,7 @@ void DeleteSelectionCommand::handleGeneralDelete()

makeStylingElementsDirectChildrenOfEditableRootToPreventStyleLoss();

// Never remove the start block unless it's a table, in which case we won't merge content in.

- if (startNode->isSameNode(m_startBlock.get()) && !startOffset && canHaveChildrenForEditing(startNode)) {

+ if (startNode == m_startBlock && !startOffset && canHaveChildrenForEditing(startNode)) {

startOffset = 0;

startNode = NodeTraversal::next(*startNode);

if (!startNode)

« no previous file with comments | « sky/engine/core/dom/Range.cpp ('k') | sky/engine/core/editing/htmlediting.cpp » ('j') | no next file with comments »