sky/engine/core/dom/Range.cpp - Issue 772743004: Remove more Node API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/dom/Range.cpp

Issue 772743004: Remove more Node API. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/dom/Range.cpp

diff --git a/sky/engine/core/dom/Range.cpp b/sky/engine/core/dom/Range.cpp

index 43116e6b428ba2f75aa2651dbdf82bf7ac750f33..75feffae7a6b3fa88d31f77b67a098fe3d1b6bdb 100644

--- a/sky/engine/core/dom/Range.cpp

+++ b/sky/engine/core/dom/Range.cpp

@@ -1096,7 +1096,7 @@ void Range::surroundContents(PassRefPtr<Node> passNewParent, ExceptionState& exc

// If m_start.container() is a character data node, it will be split and it will be its parent that will

// need to accept newParent (or in the case of a comment, it logically "would" be inserted into the parent,

// although this will fail below for another reason).

- if (parentOfNewParent->isCharacterDataNode())

+ if (parentOfNewParent->isTextNode())

parentOfNewParent = parentOfNewParent->parentNode();

if (!parentOfNewParent) {

« no previous file with comments | « sky/engine/core/dom/Node.cpp ('k') | sky/engine/core/editing/DeleteSelectionCommand.cpp » ('j') | no next file with comments »