Enable the new bookmark apps system by default.

Enable the new bookmark apps system by default.

This change enables the feature previously known as streamlined hosted
apps by default.

BUG=440670
Committed: https://crrev.com/3354b1edcc1cb9ef2d307d4afd2e05b5d2c56d2e
Cr-Commit-Position: refs/heads/master@{#308017}

[benwells, 2014-12-05 02:57:24]

Patchset #2 (id:20001) has been deleted

[benwells, 2014-12-11 07:45:38]

benwells@chromium.org changed reviewers:
+ thestig@chromium.org

[benwells, 2014-12-11 07:45:38]

thestig, please review.

Note this flag changes the default behavior of app shortcuts to match that of
hosted apps launched from the launcher, which is why some tests had to be
updated.

[benwells, 2014-12-11 19:26:50]

benwells@chromium.org changed reviewers:
+ asvitkine@chromium.org

[benwells, 2014-12-11 19:26:51]

+asvitkine for histograms.xml

[Alexei Svitkine (slow), 2014-12-11 19:28:40]

histograms lgtm

[Lei Zhang, 2014-12-11 19:29:05]

thestig@chromium.org changed reviewers:
+ jianli@chromium.org

[Lei Zhang, 2014-12-11 19:29:06]

https://codereview.chromium.org/772533005/diff/120001/chrome/browser/ui/start...
File chrome/browser/ui/startup/startup_browser_creator_browsertest.cc (right):

https://codereview.chromium.org/772533005/diff/120001/chrome/browser/ui/start...
chrome/browser/ui/startup/startup_browser_creator_browsertest.cc:328: // It
should be a standard tabbed window, not an app window.
It's not clear how enabling the bookmarks app system changes the behavior here.
Jian wrote this a long time ago and still works on apps. He can probably review
the test changes.

[benwells, 2014-12-11 19:35:30]

On 2014/12/11 19:29:06, Lei Zhang wrote:
>
https://codereview.chromium.org/772533005/diff/120001/chrome/browser/ui/start...
> File chrome/browser/ui/startup/startup_browser_creator_browsertest.cc (right):
> 
>
https://codereview.chromium.org/772533005/diff/120001/chrome/browser/ui/start...
> chrome/browser/ui/startup/startup_browser_creator_browsertest.cc:328: // It
> should be a standard tabbed window, not an app window.
> It's not clear how enabling the bookmarks app system changes the behavior
here.
> Jian wrote this a long time ago and still works on apps. He can probably
review
> the test changes.

The how is due to
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/....
If the flag is on that code will flip the container to window instead of tab if
no preference has been set.

The why is because without the change the behavior of launching apps that the
user hasn't explicitly set a launch type for behaves differently between the
launcher and shortcuts.

[Lei Zhang, 2014-12-11 19:42:58]

On 2014/12/11 19:35:30, benwells wrote:
> On 2014/12/11 19:29:06, Lei Zhang wrote:
> >
>
https://codereview.chromium.org/772533005/diff/120001/chrome/browser/ui/start...
> > File chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
(right):
> > 
> >
>
https://codereview.chromium.org/772533005/diff/120001/chrome/browser/ui/start...
> > chrome/browser/ui/startup/startup_browser_creator_browsertest.cc:328: // It
> > should be a standard tabbed window, not an app window.
> > It's not clear how enabling the bookmarks app system changes the behavior
> here.
> > Jian wrote this a long time ago and still works on apps. He can probably
> review
> > the test changes.
> 
> The how is due to
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/....
> If the flag is on that code will flip the container to window instead of tab
if
> no preference has been set.
> 
> The why is because without the change the behavior of launching apps that the
> user hasn't explicitly set a launch type for behaves differently between the
> launcher and shortcuts.

Ah, I see. The name confused me. So do we still need tests for the old behavior
or is that expected to go away soon?

[benwells, 2014-12-11 20:48:36]

On 2014/12/11 19:42:58, Lei Zhang wrote:
> On 2014/12/11 19:35:30, benwells wrote:
> > On 2014/12/11 19:29:06, Lei Zhang wrote:
> > >
> >
>
https://codereview.chromium.org/772533005/diff/120001/chrome/browser/ui/start...
> > > File chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
> (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/772533005/diff/120001/chrome/browser/ui/start...
> > > chrome/browser/ui/startup/startup_browser_creator_browsertest.cc:328: //
It
> > > should be a standard tabbed window, not an app window.
> > > It's not clear how enabling the bookmarks app system changes the behavior
> > here.
> > > Jian wrote this a long time ago and still works on apps. He can probably
> > review
> > > the test changes.
> > 
> > The how is due to
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/....
> > If the flag is on that code will flip the container to window instead of tab
> if
> > no preference has been set.
> > 
> > The why is because without the change the behavior of launching apps that
the
> > user hasn't explicitly set a launch type for behaves differently between the
> > launcher and shortcuts.
> 
> Ah, I see. The name confused me. So do we still need tests for the old
behavior
> or is that expected to go away soon?

That's right, once the new system is settled in we'll remove the old behavior.
Bug 441128 is to remove the flag (I have it scheduled for M43 currently), I just
added a note to remove all the old code too.

[benwells, 2014-12-11 22:37:38]

The CQ bit was checked by benwells@chromium.org

[benwells, 2014-12-11 22:41:12]

The CQ bit was unchecked by benwells@chromium.org

[Lei Zhang, 2014-12-11 22:42:14]

lgtm

[benwells, 2014-12-11 22:42:41]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2014-12-11 23:11:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/772533005/120001

[Lei Zhang, 2014-12-11 23:37:16]

lgtm

On Thu, Dec 11, 2014 at 12:48 PM,  <benwells@chromium.org> wrote:
> On 2014/12/11 19:42:58, Lei Zhang wrote:
>>
>> On 2014/12/11 19:35:30, benwells wrote:
>> > On 2014/12/11 19:29:06, Lei Zhang wrote:
>> > >
>> >
>
>
>
https://codereview.chromium.org/772533005/diff/120001/chrome/browser/ui/start...
>>
>> > > File chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
>> (right):
>> > >
>> > >
>> >
>
>
>
https://codereview.chromium.org/772533005/diff/120001/chrome/browser/ui/start...
>>
>> > > chrome/browser/ui/startup/startup_browser_creator_browsertest.cc:328:
>> > > //
>
> It
>>
>> > > should be a standard tabbed window, not an app window.
>> > > It's not clear how enabling the bookmarks app system changes the
>> > > behavior
>> > here.
>> > > Jian wrote this a long time ago and still works on apps. He can
>> > > probably
>> > review
>> > > the test changes.
>> >
>> > The how is due to
>> >
>
>
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/....
>>
>> > If the flag is on that code will flip the container to window instead of
>> > tab
>> if
>> > no preference has been set.
>> >
>> > The why is because without the change the behavior of launching apps
>> > that
>
> the
>>
>> > user hasn't explicitly set a launch type for behaves differently between
>> > the
>> > launcher and shortcuts.
>
>
>> Ah, I see. The name confused me. So do we still need tests for the old
>
> behavior
>>
>> or is that expected to go away soon?
>
>
> That's right, once the new system is settled in we'll remove the old
> behavior.
> Bug 441128 is to remove the flag (I have it scheduled for M43 currently), I
> just
> added a note to remove all the old code too.
>
> https://codereview.chromium.org/772533005/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-12-12 01:23:16]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2014-12-12 01:24:09]

Patchset 6 (id:??) landed as
https://crrev.com/3354b1edcc1cb9ef2d307d4afd2e05b5d2c56d2e
Cr-Commit-Position: refs/heads/master@{#308017}