Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3871)

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

Issue 772533005: Enable the new bookmark apps system by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update one more test Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
diff --git a/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc b/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
index a2a94552c828c5dbd1825a5f1313c978350d5f30..fdc0bbb1f15d999477b11dd4ad96a5288931a776 100644
--- a/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
+++ b/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
@@ -320,18 +320,14 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTest, OpenAppShortcutNoPref) {
ASSERT_TRUE(launch.Launch(browser()->profile(), std::vector<GURL>(), false,
browser()->host_desktop_type()));
- // No pref was set, so the app should have opened in a window.
+ // No pref was set, so the app should have opened in a tab in a new window.
// The launch should have created a new browser.
Browser* new_browser = FindOneOtherBrowser(browser());
ASSERT_TRUE(new_browser);
- // Expect an app window.
- EXPECT_TRUE(new_browser->is_app());
-
- // The browser's app_name should include the app's ID.
- EXPECT_NE(
- new_browser->app_name_.find(extension_app->id()),
- std::string::npos) << new_browser->app_name_;
+ // It should be a standard tabbed window, not an app window.
Lei Zhang 2014/12/11 19:29:05 It's not clear how enabling the bookmarks app syst
+ EXPECT_FALSE(new_browser->is_app());
+ EXPECT_TRUE(new_browser->is_type_tabbed());
}
IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTest, OpenAppShortcutWindowPref) {
« no previous file with comments | « chrome/browser/ui/browser_browsertest.cc ('k') | chrome/browser/ui/views/frame/web_app_left_header_view_ash_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698