Move some files from sync/engine to internal_api

Move some files from sync/engine to internal_api

This change moves the following files from sync/engine to sync/internal_api:
- change_reorder_buffer.{cc,h}
- configure_reason.h
- http_post_provider_interface.h
- http_post_provider_factory.h
- syncapi_server_connection_manager.{cc,h}

As part of the change, the SyncScheduler::ScheduleConfig function was modified
to take a sync_pb::GetupdatesCallerInfo::GetUpdatesSource parameter instead of
a syncapi::ConfigureReason.

The remaining changes were mainly updates to include directives and DEPS
files.

BUG=93816
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99000

[tim (not reviewing), 2011-08-24 13:50:23]

Please address comments, and then LGTM.

It occurred to me just now that backend_api would have been a better name than
internal, because we already call that layer 'the backend' (e.g.
SyncBackendHost/Registrar), and it sounds less malicious to include
backend_api/foo from chrome than it does to include internal_api/foo.

But... we can save that for a rainy day.

http://codereview.chromium.org/7719011/diff/1/chrome/browser/sync/engine/sync...
File chrome/browser/sync/engine/sync_scheduler.h (right):

http://codereview.chromium.org/7719011/diff/1/chrome/browser/sync/engine/sync...
chrome/browser/sync/engine/sync_scheduler.h:92: void ScheduleConfig(
Let's add a comment / precondition here saying that |source| should be an item
from the subset of GetUpdatesCallerInfo that pertains to configurations.   We
could add a dcheck in the implementation to check this, too.

http://codereview.chromium.org/7719011/diff/1/chrome/browser/sync/glue/DEPS
File chrome/browser/sync/glue/DEPS (right):

http://codereview.chromium.org/7719011/diff/1/chrome/browser/sync/glue/DEPS#n...
chrome/browser/sync/glue/DEPS:8:
"+chrome/browser/sync/internal_api/configure_reason.h",
we shouldn't need this -- glue can depend on internal_api.

http://codereview.chromium.org/7719011/diff/1/chrome/browser/sync/glue/DEPS#n...
chrome/browser/sync/glue/DEPS:13: "+chrome/browser/sync/engine/syncapi.h",
think we can remove this?

[rlarocque, 2011-08-24 17:42:24]

Uploaded a new diff to address Tim's comments.

http://codereview.chromium.org/7719011/diff/1/chrome/browser/sync/engine/sync...
File chrome/browser/sync/engine/sync_scheduler.h (right):

http://codereview.chromium.org/7719011/diff/1/chrome/browser/sync/engine/sync...
chrome/browser/sync/engine/sync_scheduler.h:92: void ScheduleConfig(
On 2011/08/24 13:50:23, timsteele wrote:
> Let's add a comment / precondition here saying that |source| should be an item
> from the subset of GetUpdatesCallerInfo that pertains to configurations.   We
> could add a dcheck in the implementation to check this, too.

Done.

http://codereview.chromium.org/7719011/diff/1/chrome/browser/sync/glue/DEPS
File chrome/browser/sync/glue/DEPS (right):

http://codereview.chromium.org/7719011/diff/1/chrome/browser/sync/glue/DEPS#n...
chrome/browser/sync/glue/DEPS:8:
"+chrome/browser/sync/internal_api/configure_reason.h",
On 2011/08/24 13:50:23, timsteele wrote:
> we shouldn't need this -- glue can depend on internal_api.

Done.

http://codereview.chromium.org/7719011/diff/1/chrome/browser/sync/glue/DEPS#n...
chrome/browser/sync/glue/DEPS:13: "+chrome/browser/sync/engine/syncapi.h",
On 2011/08/24 13:50:23, timsteele wrote:
> think we can remove this?

Done.

[tim (not reviewing), 2011-08-25 16:00:50]

LGTM

[rlarocque, 2011-08-26 22:31:35]

http://codereview.chromium.org/7719011/diff/3002/chrome/test/live_sync/two_cl...
File chrome/test/live_sync/two_client_bookmarks_sync_test.cc (right):

http://codereview.chromium.org/7719011/diff/3002/chrome/test/live_sync/two_cl...
chrome/test/live_sync/two_client_bookmarks_sync_test.cc:641: sleep(10);
Oops.  Good thing the try server caught this.  

This line won't be in the patch I submit.

[tim (not reviewing), 2011-08-30 01:06:34]

On 2011/08/26 22:31:35, rlarocque_chromium.org wrote:
>
http://codereview.chromium.org/7719011/diff/3002/chrome/test/live_sync/two_cl...
> File chrome/test/live_sync/two_client_bookmarks_sync_test.cc (right):
> 
>
http://codereview.chromium.org/7719011/diff/3002/chrome/test/live_sync/two_cl...
> chrome/test/live_sync/two_client_bookmarks_sync_test.cc:641: sleep(10);
> Oops.  Good thing the try server caught this.  
> 
> This line won't be in the patch I submit.

Just wondering when you're going to land this, since I'm performing surgery on
syncapi_server_connection_manager...

[rlarocque1, 2011-08-30 17:19:00]

I should be able to get it in today.

On Mon, Aug 29, 2011 at 6:06 PM, <tim@chromium.org> wrote:

> On 2011/08/26 22:31:35, rlarocque_chromium.org wrote:
>
> http://codereview.chromium.**org/7719011/diff/3002/chrome/**
>
test/live_sync/two_client_**bookmarks_sync_test.cc<http://codereview.chromium.org/7719011/diff/3002/chrome/test/live_sync/two_client_bookmarks_sync_test.cc>
>
>> File chrome/test/live_sync/two_**client_bookmarks_sync_test.cc (right):
>>
>
>
> http://codereview.chromium.**org/7719011/diff/3002/chrome/**
>
test/live_sync/two_client_**bookmarks_sync_test.cc#**newcode641<http://codereview.chromium.org/7719011/diff/3002/chrome/test/live_sync/two_client_bookmarks_sync_test.cc#newcode641>
>
>> chrome/test/live_sync/two_**client_bookmarks_sync_test.cc:**641:
>> sleep(10);
>> Oops.  Good thing the try server caught this.
>>
>
>  This line won't be in the patch I submit.
>>
>
> Just wondering when you're going to land this, since I'm performing surgery
> on
> syncapi_server_connection_**manager...
>
>
>
http://codereview.chromium.**org/7719011/<http://codereview.chromium.org/7719...
>

[commit-bot: I haz the power, 2011-08-30 23:26:20]

Can't process patch for file
chrome/browser/sync/internal_api/change_reorder_buffer.h.
A +

[commit-bot: I haz the power, 2011-08-30 23:56:03]

Can't process patch for file
chrome/browser/sync/internal_api/change_reorder_buffer.h.
A +