Add Array.prototype.includes

test/mjsunit/harmony/array-includes-to-object.js

+// Copyright 2014 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --harmony-array-includes
+
+// Ported from
+// https://github.com/tc39/Array.prototype.includes/blob/master/test/number-this.js
+// using https://www.npmjs.org/package/test262-to-mjsunit
+
+//
+// Array.prototype.includes should use ToObject on this, so that when called with a number, it picks up numeric properties from Number.prototype

[arv (Not doing code reviews), 2014/12/04 21:04:00]

Can you add a test that this inside a getter has the right type?

[domenic (use chromium.org), 2014/12/04 21:57:19]

Done.

+//
+(function() {
+  Number.prototype[0] = "a";
+  Number.prototype[1] = "b";
+  Number.prototype.length = 2;
+  assertTrue(Array.prototype.includes.call(5, "a"));
+  assertTrue(Array.prototype.includes.call(5, "b"));
+  assertFalse(Array.prototype.includes.call(5, "c"));
+})();

[caitp (gmail), 2014/12/04 20:53:02]

Usually these tests include `assertThrows(function() {
Array.prototype.includes.call(undefined, whatever); }, TypeError);` and similar

[domenic (use chromium.org), 2014/12/04 21:57:19]

Done.