Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1483)

Unified Diff: test/mjsunit/harmony/array-includes-to-object.js

Issue 771863002: Add Array.prototype.includes (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add converted test262 tests Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/mjsunit/harmony/array-includes-to-object.js
diff --git a/test/mjsunit/harmony/array-includes-to-object.js b/test/mjsunit/harmony/array-includes-to-object.js
new file mode 100644
index 0000000000000000000000000000000000000000..026d7bd9c64954a495ee22a6843121456721a2c0
--- /dev/null
+++ b/test/mjsunit/harmony/array-includes-to-object.js
@@ -0,0 +1,21 @@
+// Copyright 2014 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --harmony-array-includes
+
+// Ported from
+// https://github.com/tc39/Array.prototype.includes/blob/master/test/number-this.js
+// using https://www.npmjs.org/package/test262-to-mjsunit
+
+//
+// Array.prototype.includes should use ToObject on this, so that when called with a number, it picks up numeric properties from Number.prototype
arv (Not doing code reviews) 2014/12/04 21:04:00 Can you add a test that this inside a getter has t
domenic (use chromium.org) 2014/12/04 21:57:19 Done.
+//
+(function() {
+ Number.prototype[0] = "a";
+ Number.prototype[1] = "b";
+ Number.prototype.length = 2;
+ assertTrue(Array.prototype.includes.call(5, "a"));
+ assertTrue(Array.prototype.includes.call(5, "b"));
+ assertFalse(Array.prototype.includes.call(5, "c"));
+})();
caitp (gmail) 2014/12/04 20:53:02 Usually these tests include `assertThrows(function
domenic (use chromium.org) 2014/12/04 21:57:19 Done.

Powered by Google App Engine
This is Rietveld 408576698