Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 771813002: IDL: Null values should be converted for non-nullable dictionary members (re-land) (Closed)

Created:
6 years ago by bashi
Modified:
6 years ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IDL: Null values should be converted for non-nullable dictionary members (re-land) This is the second attempt to land reverted CL (https://codereview.chromium.org/765673005/) with GN fix. Original description: The current implementation of the binding layer treats null values as the same as undefined, but this behavior doesn't match what the spec specified. According to the spec[1], when null is passed to a dictionary member, we should do conversion unless the member is nullable. For example, given a dictionary member and the type of the member is DOMString, passing null should result in "null" (of type string). This CL changes the binding's behavior to follow the spec. [1] http://heycam.github.io/webidl/#es-dictionary BUG=321462 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186276

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -144 lines) Patch
M LayoutTests/fast/canvas/canvas-hit-regions-basic-test.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-hit-regions-basic-test-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html View 1 chunk +1 line, -13 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test-expected.txt View 1 chunk +1 line, -6 lines 0 comments Download
M LayoutTests/fast/dom/idl-dictionary-unittest.html View 2 chunks +3 lines, -5 lines 0 comments Download
M LayoutTests/fast/dom/idl-dictionary-unittest-expected.txt View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/scripts/v8_dictionary.py View 5 chunks +18 lines, -8 lines 0 comments Download
M Source/bindings/templates/dictionary_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/bindings/templates/dictionary_v8.cpp View 2 chunks +18 lines, -9 lines 0 comments Download
M Source/bindings/templates/templates.gni View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/core/TestDictionary.h View 5 chunks +7 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestDictionary.cpp View 2 chunks +154 lines, -80 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp View 1 chunk +14 lines, -8 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
bashi
PTAL? The only diff from the reverted CL is templates.gni.
6 years ago (2014-12-02 00:04:10 UTC) #2
haraken
LGTM
6 years ago (2014-12-02 01:02:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/771813002/1
6 years ago (2014-12-02 01:03:23 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-02 03:04:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186276

Powered by Google App Engine
This is Rietveld 408576698