Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: Source/bindings/templates/dictionary_impl.h

Issue 771813002: IDL: Null values should be converted for non-nullable dictionary members (re-land) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_dictionary.py ('k') | Source/bindings/templates/dictionary_v8.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/dictionary_impl.h
diff --git a/Source/bindings/templates/dictionary_impl.h b/Source/bindings/templates/dictionary_impl.h
index b52b1c44aa56991fc49144d39cadc8b9278ae597..6cf2a0ff2b0d7b83ea2d92d6908145319c7db631 100644
--- a/Source/bindings/templates/dictionary_impl.h
+++ b/Source/bindings/templates/dictionary_impl.h
@@ -23,6 +23,9 @@ public:
bool {{member.has_method_name}}() const { return {{member.has_method_expression}}; }
{{member.rvalue_cpp_type}} {{member.cpp_name}}() const { return {{member.getter_expression}}; }
void {{member.setter_name}}({{member.rvalue_cpp_type}} value) { m_{{member.cpp_name}} = value; }
+ {% if member.null_setter_name %}
+ void {{member.null_setter_name}}() { m_{{member.cpp_name}} = {{member.member_cpp_type}}(); }
+ {% endif %}
{% endfor %}
virtual void trace(Visitor*);
« no previous file with comments | « Source/bindings/scripts/v8_dictionary.py ('k') | Source/bindings/templates/dictionary_v8.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698