Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 77173004: Revert 233759 "Make NativeTextfieldViews update the win system c..." (Closed)

Created:
7 years, 1 month ago by dmazzoni
Modified:
7 years, 1 month ago
Reviewers:
dmazzoni
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 233759 "Make NativeTextfieldViews update the win system c..." Caused new bug: http://crbug.com/320758 > Make NativeTextfieldViews update the win system caret. > > Added a helper function to ui/base/win because we're > going to need to do the same thing from content/browser. > > BUG=142133 > > Review URL: https://codereview.chromium.org/61923005 TBR=dmazzoni@chromium.org BUG=320758, 142133 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236198

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -74 lines) Patch
M trunk/src/ui/base/win/accessibility_misc_utils.h View 1 chunk +1 line, -10 lines 0 comments Download
M trunk/src/ui/base/win/accessibility_misc_utils.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M trunk/src/ui/views/controls/textfield/native_textfield_views.h View 2 chunks +0 lines, -9 lines 0 comments Download
M trunk/src/ui/views/controls/textfield/native_textfield_views.cc View 4 chunks +0 lines, -37 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dmazzoni
7 years, 1 month ago (2013-11-20 07:25:32 UTC) #1
dmazzoni
7 years, 1 month ago (2013-11-20 07:25:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r236198.

Powered by Google App Engine
This is Rietveld 408576698