Make NativeTextfieldViews update the win system caret.

Make NativeTextfieldViews update the win system caret.

Added a helper function to ui/base/win because we're
going to need to do the same thing from content/browser.

BUG=142133
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233759

[dmazzoni, 2013-11-06 22:44:36]

FWIW, Mozilla uses this exact same trick (updating the
system caret with an empty bitmap) for all of its
custom-drawn text fields, so it should be pretty safe.
Confirmed that it works correctly with Windows Magnifier.

[sky, 2013-11-07 01:34:41]

https://codereview.chromium.org/61923005/diff/40001/ui/base/win/accessibility...
File ui/base/win/accessibility_misc_utils.cc (right):

https://codereview.chromium.org/61923005/diff/40001/ui/base/win/accessibility...
ui/base/win/accessibility_misc_utils.cc:26: DeleteObject(caret_bitmap);
Does caret_bitmap leak if CreateCaret returns false? Also, don't we have some
scoper you can use?

https://codereview.chromium.org/61923005/diff/40001/ui/views/controls/textfie...
File ui/views/controls/textfield/native_textfield_views.cc (right):

https://codereview.chromium.org/61923005/diff/40001/ui/views/controls/textfie...
ui/views/controls/textfield/native_textfield_views.cc:1375: void
NativeTextfieldViews::OnCaretBoundsChanged() {
I'm not sure if this is invoked if the bounds of the TextField itself change
relative to the root. Do you care?

https://codereview.chromium.org/61923005/diff/40001/ui/views/controls/textfie...
ui/views/controls/textfield/native_textfield_views.cc:1387:
!model_->HasSelection() &&
How come you don't do this when there is a selection? Isn't there still a caret
at one end of the selection? And similarly if the drop cursor is visible are you
sure you don't want to update the caret to that position?

[dmazzoni, 2013-11-07 20:07:14]

https://codereview.chromium.org/61923005/diff/40001/ui/base/win/accessibility...
File ui/base/win/accessibility_misc_utils.cc (right):

https://codereview.chromium.org/61923005/diff/40001/ui/base/win/accessibility...
ui/base/win/accessibility_misc_utils.cc:26: DeleteObject(caret_bitmap);
On 2013/11/07 01:34:42, sky wrote:
> Does caret_bitmap leak if CreateCaret returns false? Also, don't we have some
> scoper you can use?

Good catch, done.

https://codereview.chromium.org/61923005/diff/40001/ui/views/controls/textfie...
File ui/views/controls/textfield/native_textfield_views.cc (right):

https://codereview.chromium.org/61923005/diff/40001/ui/views/controls/textfie...
ui/views/controls/textfield/native_textfield_views.cc:1375: void
NativeTextfieldViews::OnCaretBoundsChanged() {
On 2013/11/07 01:34:42, sky wrote:
> I'm not sure if this is invoked if the bounds of the TextField itself change
> relative to the root. Do you care?

I moved it to RepaintCursor, that should update every time it blinks. I added a
cache of the last rect so it doesn't need to update if it hasn't actually moved.

https://codereview.chromium.org/61923005/diff/40001/ui/views/controls/textfie...
ui/views/controls/textfield/native_textfield_views.cc:1387:
!model_->HasSelection() &&
On 2013/11/07 01:34:42, sky wrote:
> How come you don't do this when there is a selection? Isn't there still a
caret
> at one end of the selection?

You're right - I thought we didn't need to update it because it wasn't visible,
but it looks like accessibility apps track the caret even when it's at one end
of a selection. Done.

> And similarly if the drop cursor is visible are you
> sure you don't want to update the caret to that position?

I still lean towards no, it's a placeholder and not the real caret - and I don't
think it'd be an accessibility issue since it'd always be right under the mouse
cursor.

[sky, 2013-11-07 20:58:05]

LGTM

https://codereview.chromium.org/61923005/diff/130001/ui/base/win/accessibilit...
File ui/base/win/accessibility_misc_utils.h (right):

https://codereview.chromium.org/61923005/diff/130001/ui/base/win/accessibilit...
ui/base/win/accessibility_misc_utils.h:23: UI_EXPORT void
SetInvisibleSystemCaretRect(HWND hwnd, gfx::Rect caret_rect);
const gfx::Rect&

[dmazzoni, 2013-11-07 22:07:55]

https://codereview.chromium.org/61923005/diff/130001/ui/base/win/accessibilit...
File ui/base/win/accessibility_misc_utils.h (right):

https://codereview.chromium.org/61923005/diff/130001/ui/base/win/accessibilit...
ui/base/win/accessibility_misc_utils.h:23: UI_EXPORT void
SetInvisibleSystemCaretRect(HWND hwnd, gfx::Rect caret_rect);
On 2013/11/07 20:58:06, sky wrote:
> const gfx::Rect&

Done.

[commit-bot: I haz the power, 2013-11-07 22:19:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/61923005/190001

[commit-bot: I haz the power, 2013-11-08 01:45:55]

Change committed as 233759