Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 77173003: [OTS] build failure on android_aosp (Closed)

Created:
7 years, 1 month ago by Kunihiko Sakamoto
Modified:
7 years, 1 month ago
Reviewers:
Yusuke Sato
CC:
chromium-reviews
Visibility:
Public.

Description

[OTS] build failure on android_aosp AOSP's compiler is too strict about signed and unsigned integer comparison. Add a cast to fix the sign-compare warning. TEST=compile R=yusukes@chromium.org Committed: 107

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/woff2.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Kunihiko Sakamoto
7 years, 1 month ago (2013-11-20 03:09:58 UTC) #1
Yusuke Sato
On 2013/11/20 03:09:58, ksakamoto wrote: lgtm
7 years, 1 month ago (2013-11-20 03:33:38 UTC) #2
Kunihiko Sakamoto
7 years, 1 month ago (2013-11-20 03:34:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r107 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698