Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(45)

Issue 771493002: Insert the error message block when stopping parsing and an error occurred

Created:
4 years, 6 months ago by dtrebbien
Modified:
4 years, 1 month ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Insert the error message block when stopping parsing and an error occurred When XMLDocumentParser::stopParsing() is called to stop parsing, call insertErrorMessageBlock() to insert the <parsererror> element if an error occurred. The <parsererror> element was not being added to the document in certain cases involving attribute parsing. For example, if an undeclared namespace prefix was used in the document, then parsing would stop, but a <parsererror> element would not be inserted into the document to indicate that a parsing error occurred. BUG=295809

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Simplify the patch #

Patch Set 4 : Fix svg/custom/missing-xlink.svg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -1 line) Patch
A LayoutTests/fast/dom/dom-parse-parsererror.html View 1 1 chunk +75 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/dom-parse-parsererror-expected.txt View 1 chunk +18 lines, -0 lines 0 comments Download
M Source/core/xml/parser/XMLDocumentParser.cpp View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (1 generated)
dtrebbien
4 years, 6 months ago (2014-11-30 21:20:56 UTC) #2
dtrebbien
As I can't run all of the layout tests for myself on Yosemite yet (http://crbug.com/425571), ...
4 years, 6 months ago (2014-11-30 21:23:04 UTC) #3
leviw_travelin_and_unemployed
I added a bunch of trybots.
4 years, 6 months ago (2014-12-01 02:04:12 UTC) #4
dtrebbien
On 2014/12/01 02:04:12, leviw wrote: > I added a bunch of trybots. Thanks. The trybot ...
4 years, 6 months ago (2014-12-04 12:43:49 UTC) #5
Erik Dahlström (inactive)
Showing the parsing error sounds good to me. https://codereview.chromium.org/771493002/diff/20001/Source/core/xml/parser/XMLDocumentParser.cpp File Source/core/xml/parser/XMLDocumentParser.cpp (left): https://codereview.chromium.org/771493002/diff/20001/Source/core/xml/parser/XMLDocumentParser.cpp#oldcode426 Source/core/xml/parser/XMLDocumentParser.cpp:426: insertErrorMessageBlock(); ...
4 years, 5 months ago (2015-01-14 13:35:41 UTC) #6
dtrebbien
On 2015/01/14 13:35:41, Erik Dahlström wrote: > Showing the parsing error sounds good to me. ...
4 years, 5 months ago (2015-01-20 00:40:59 UTC) #7
dtrebbien
I uploaded a new patch that only modifies XMLDocumentParser::stopParsing(). The CL description was updated as ...
4 years, 5 months ago (2015-01-21 00:11:36 UTC) #8
Erik Dahlström (inactive)
On 2015/01/21 00:11:36, dtrebbien wrote: > I uploaded a new patch that only modifies XMLDocumentParser::stopParsing(). ...
4 years, 1 month ago (2015-04-28 15:18:34 UTC) #9
dtrebbien
4 years, 1 month ago (2015-05-03 12:16:43 UTC) #10
On 2015/04/28 15:18:34, Erik Dahlström wrote:
> On 2015/01/21 00:11:36, dtrebbien wrote:
> > I uploaded a new patch that only modifies XMLDocumentParser::stopParsing(). 
> The
> > CL description was updated as well.
> 
> Patchset #3 seems to add two error messages for this testcase:
>
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/svg/custom/missing-xli....

I have uploaded a new Patchset to fix this regression (I added back `&&
!isStopped()' in XMLDocumentParser::end()).

Powered by Google App Engine
This is Rietveld 408576698