Fix focus regression in chrome://settings/editDictionary.

Fix focus regression in chrome://settings/editDictionary.

BUG=437704
Committed: https://crrev.com/8202966514e2706328e4fe1be271b4eba4d8dbd5
Cr-Commit-Position: refs/heads/master@{#306678}

[bondd, 2014-12-02 20:34:54]

bondd@chromium.org changed reviewers:
+ dbeam@chromium.org

[bondd, 2014-12-02 20:34:54]

bondd@chromium.org changed required reviewers:
+ dbeam@chromium.org

[bondd, 2014-12-02 20:35:03]

https://codereview.chromium.org/771283002/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/inline_editable_list.js (right):

https://codereview.chromium.org/771283002/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/inline_editable_list.js:677:
getInitialFocusableItem: function() {
I made this a regular method instead of an ECMA 5 getter because AFAIK the
syntax for overriding a getter is messier than overriding a regular method, and
the entire point of this method is to be overridden.

https://codereview.chromium.org/771283002/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/language_dictionary_overlay_word_list.js
(right):

https://codereview.chromium.org/771283002/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/language_dictionary_overlay_word_list.js:239:
return this.getListItemByIndex(this.selectionModel.length - 1);
Placeholder is always the last list item. Focus it.

[Dan Beam, 2014-12-03 01:40:33]

lgtm

https://codereview.chromium.org/771283002/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/inline_editable_list.js (right):

https://codereview.chromium.org/771283002/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/inline_editable_list.js:677:
getInitialFocusableItem: function() {
On 2014/12/02 20:35:02, bondd wrote:
> I made this a regular method instead of an ECMA 5 getter because AFAIK the
> syntax for overriding a getter is messier than overriding a regular method,
and
> the entire point of this method is to be overridden.

Acknowledged.

[bondd, 2014-12-03 16:13:07]

The CQ bit was checked by bondd@chromium.org

[commit-bot: I haz the power, 2014-12-03 16:13:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/771283002/1

[commit-bot: I haz the power, 2014-12-03 17:09:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-03 17:09:15]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[bondd, 2014-12-03 21:00:12]

The CQ bit was checked by bondd@chromium.org

[commit-bot: I haz the power, 2014-12-03 21:00:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/771283002/1

[commit-bot: I haz the power, 2014-12-03 21:32:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-12-03 21:33:25]

Patchset 1 (id:??) landed as
https://crrev.com/8202966514e2706328e4fe1be271b4eba4d8dbd5
Cr-Commit-Position: refs/heads/master@{#306678}