Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1430)

Unified Diff: chrome/browser/resources/options/language_dictionary_overlay_word_list.js

Issue 771283002: Fix focus regression in chrome://settings/editDictionary. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/language_dictionary_overlay_word_list.js
diff --git a/chrome/browser/resources/options/language_dictionary_overlay_word_list.js b/chrome/browser/resources/options/language_dictionary_overlay_word_list.js
index c16f34e9fc2cac33ff903f887b984d457b125b1b..ef3b89eec416af0cd715941e6dd4c0424915b833 100644
--- a/chrome/browser/resources/options/language_dictionary_overlay_word_list.js
+++ b/chrome/browser/resources/options/language_dictionary_overlay_word_list.js
@@ -233,6 +233,11 @@ cr.define('options.dictionary_words', function() {
shouldFocusPlaceholder: function() {
return false;
},
+
+ /** @override */
+ getInitialFocusableItem: function() {
+ return this.getListItemByIndex(this.selectionModel.length - 1);
bondd 2014/12/02 20:35:02 Placeholder is always the last list item. Focus it
+ },
};
return {

Powered by Google App Engine
This is Rietveld 408576698