Linux: support append to password list in the GNOME keyring backend to fix initial password sync.

Linux: allow appending to a list of passwords in the GNOME keyring backend to fix initial password sync.
Password sync calls FillAutofillableLogins and FillBlacklistLogins on the same password list, expecting the latter to append.
BUG=92946
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97900

[Evan Martin, 2011-08-23 14:36:07]

LGTM

You are awesome for writing so many tests!

http://codereview.chromium.org/7712024/diff/1/chrome/browser/password_manager...
File chrome/browser/password_manager/native_backend_gnome_x.cc (right):

http://codereview.chromium.org/7712024/diff/1/chrome/browser/password_manager...
chrome/browser/password_manager/native_backend_gnome_x.cc:387:
forms->swap(forms_);
Is this performance critical?  I wonder if it's worth the extra code.  It seems
this is a vector of pointers, so either way the total amount of data being moved
around is on the order of 200 bytes.

[Mike Mammarella, 2011-08-23 19:40:20]

http://codereview.chromium.org/7712024/diff/1/chrome/browser/password_manager...
File chrome/browser/password_manager/native_backend_gnome_x.cc (right):

http://codereview.chromium.org/7712024/diff/1/chrome/browser/password_manager...
chrome/browser/password_manager/native_backend_gnome_x.cc:387:
forms->swap(forms_);
On 2011/08/23 14:36:07, Evan Martin wrote:
> Is this performance critical?  I wonder if it's worth the extra code.  It
seems
> this is a vector of pointers, so either way the total amount of data being
moved
> around is on the order of 200 bytes.

No, it's not performance critical. It would probably be fine to just do the copy
always. On the other hand it's really not much code and it "feels" better to me
to avoid the unnecessary copy since it's so easy to do. If you want I'll remove
it but otherwise I'm inclined to leave it.

[Evan Martin, 2011-08-23 19:43:45]

On 2011/08/23 19:40:20, Mike Mammarella wrote:
>
http://codereview.chromium.org/7712024/diff/1/chrome/browser/password_manager...
> File chrome/browser/password_manager/native_backend_gnome_x.cc (right):
> 
>
http://codereview.chromium.org/7712024/diff/1/chrome/browser/password_manager...
> chrome/browser/password_manager/native_backend_gnome_x.cc:387:
> forms->swap(forms_);
> On 2011/08/23 14:36:07, Evan Martin wrote:
> > Is this performance critical?  I wonder if it's worth the extra code.  It
> seems
> > this is a vector of pointers, so either way the total amount of data being
> moved
> > around is on the order of 200 bytes.
> 
> No, it's not performance critical. It would probably be fine to just do the
copy
> always. On the other hand it's really not much code and it "feels" better to
me
> to avoid the unnecessary copy since it's so easy to do. If you want I'll
remove
> it but otherwise I'm inclined to leave it.

LGTM stands, your call :)