Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1783)

Unified Diff: chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

Issue 7712024: Linux: support append to password list in the GNOME keyring backend to fix initial password sync. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
===================================================================
--- chrome/browser/password_manager/native_backend_gnome_x_unittest.cc (revision 97665)
+++ chrome/browser/password_manager/native_backend_gnome_x_unittest.cc (working copy)
@@ -539,6 +539,40 @@
CheckMockKeyringItem(&mock_keyring_items[0], form_google_, "chrome-42");
}
+TEST_F(NativeBackendGnomeTest, ListLoginsAppends) {
+ // Pretend that the migration has already taken place.
+ profile_->GetPrefs()->SetBoolean(prefs::kPasswordsUseLocalProfileId, true);
+
+ NativeBackendGnome backend(42, profile_->GetPrefs());
+ backend.Init();
+
+ BrowserThread::PostTask(BrowserThread::DB, FROM_HERE,
+ NewRunnableMethod(&backend,
+ &NativeBackendGnome::AddLogin,
+ form_google_));
+
+ // Send the same request twice with the same list both times.
+ std::vector<PasswordForm*> form_list;
+ BrowserThread::PostTask(BrowserThread::DB, FROM_HERE,
+ NewRunnableMethod(&backend,
+ &NativeBackendGnome::GetAutofillableLogins,
+ &form_list));
+ BrowserThread::PostTask(BrowserThread::DB, FROM_HERE,
+ NewRunnableMethod(&backend,
+ &NativeBackendGnome::GetAutofillableLogins,
+ &form_list));
+
+ RunBothThreads();
+
+ // Quick check that we got two results back.
+ EXPECT_EQ(2u, form_list.size());
+ STLDeleteElements(&form_list);
+
+ EXPECT_EQ(1u, mock_keyring_items.size());
+ if (mock_keyring_items.size() > 0)
+ CheckMockKeyringItem(&mock_keyring_items[0], form_google_, "chrome-42");
+}
+
// TODO(mdm): add more basic (i.e. non-migration) tests here at some point.
TEST_F(NativeBackendGnomeTest, MigrateOneLogin) {

Powered by Google App Engine
This is Rietveld 408576698