Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(6)

Issue 7711011: Merge 93296 - Prepare frames for history navigation. (Closed)

Created:
9 years, 6 months ago by jam
Modified:
9 years, 6 months ago
Reviewers:
gavinp
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/835/
Visibility:
Public.

Description

Merge 93296 - Prepare frames for history navigation. Before beginning an explicit history navigation in a newly initialized frame, it's important to give a "previous" item to avoid crashes, and give a state to the state machine to avoid extra validating loads. https://bugs.webkit.org/show_bug.cgi?id=66322 Reviewed by Darin Fisher. Source/WebCore: No new tests, as history navigation is very difficult to test in DumpRenderTree. * loader/FrameLoader.cpp: (WebCore::FrameLoader::prepareForHistoryNavigation): * loader/FrameLoader.h: Source/WebKit/chromium: * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::loadHistoryItem): TBR=gavinp@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93533

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3272 lines, -10 lines) Patch
M Source/WebCore/ChangeLog View 1 chunk +2442 lines, -0 lines 0 comments Download
M Source/WebCore/loader/FrameLoader.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/loader/FrameLoader.cpp View 1 chunk +19 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/ChangeLog View 1 chunk +809 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebFrameImpl.cpp View 1 chunk +1 line, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
9 years, 6 months ago (2011-08-22 20:33:08 UTC) #1
gavinp
9 years, 6 months ago (2011-08-23 15:52:43 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698