Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: Source/WebCore/ChangeLog

Side-by-side diff isn't available for this file because of its large size.
Issue 7711011: Merge 93296 - Prepare frames for history navigation. (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/835/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | Source/WebCore/loader/FrameLoader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/ChangeLog
===================================================================
--- Source/WebCore/ChangeLog (revision 93532)
+++ Source/WebCore/ChangeLog (working copy)
@@ -1,3 +1,2445 @@
+2011-08-18 Jing Zhao <jingzhao@chromium.org>
+
+ When changing the size of a menulist from x (x>1) to 1, the first item should be selected.
+ https://bugs.webkit.org/show_bug.cgi?id=66282
+
+ Reviewed by Kent Tamura.
+
+ No new tests since it only changes the behavior in Android Browser.
+
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::parseMappedAttribute):
+
+2011-08-18 Adam Klein <adamk@chromium.org>
+
+ Handle "form" attribute updates in parseMappedAttribute() instead of attributeChanged() to better match HTMLElement practices
+ https://bugs.webkit.org/show_bug.cgi?id=66321
+
+ Reviewed by Darin Adler.
+
+ This is simply a cleanup change: there's no need that I can see for
+ HTMLFormControlElement and HTMLObjectElement to override
+ Element::attributeChanged since they can properly handle form
+ attribute changes in parseMappedAttribute, which they also override.
+
+ Though no change in behavior, I've added test coverage of the moved
+ code to an existing test (fast/forms/form-attribute.html) and added
+ a new test.
+
+ Test: fast/forms/radio-remove-form-attr.html
+
+ * html/HTMLFormControlElement.cpp:
+ (WebCore::HTMLFormControlElement::parseMappedAttribute):
+ * html/HTMLFormControlElement.h:
+ * html/HTMLObjectElement.cpp:
+ (WebCore::HTMLObjectElement::parseMappedAttribute):
+ * html/HTMLObjectElement.h:
+
+2011-08-18 Chang Shu <cshu@webkit.org>
+
+ Add support of setPasswordEchoEnabled and setPasswordEchoDuration for password echo feature
+ https://bugs.webkit.org/show_bug.cgi?id=66052
+
+ Reviewed by Alexey Proskuryakov.
+
+ Added runtime settings in WebCore.
+ Added support in window.internals for testing.
+
+ Tests: editing/input/password-echo-passnode.html
+ editing/input/password-echo-passnode2.html
+ editing/input/password-echo-passnode3.html
+ editing/input/password-echo-textnode.html
+
+ * page/Settings.cpp:
+ (WebCore::Settings::Settings):
+ * page/Settings.h:
+ (WebCore::Settings::setPasswordEchoEnabled):
+ (WebCore::Settings::passwordEchoEnabled):
+ (WebCore::Settings::setPasswordEchoDurationInSeconds):
+ (WebCore::Settings::passwordEchoDurationInSeconds):
+ * testing/Internals.cpp:
+ (WebCore::Internals::Internals):
+ (WebCore::Internals::setPasswordEchoEnabled):
+ (WebCore::Internals::setPasswordEchoDurationInSeconds):
+ (WebCore::Internals::reset):
+ * testing/Internals.h:
+ * testing/Internals.idl:
+
+2011-08-18 Wyatt Carss <wcarss@chromium.org>
+
+ Selecting all and inserting text into a page with a frameset leads to a NULL ptr
+ https://bugs.webkit.org/show_bug.cgi?id=66288
+
+ Reviewed by Tony Chang.
+
+ VisibleSelection returns a NoSelection to InsertTextCommand::doApply as
+ a new endingSelection, which isn't a sane state to be in. The code
+ tries to get a position on a higher node for a better selection, but
+ cannot go above the frameset (which exists in place of the body tag),
+ which lacks a renderer, and therefore cannot have a non-NoSelection
+ VisibleSelection.
+
+ Because this is a rare corner case, it seemed more reasonable to bail
+ out in this circumstance than to change the way VisibleSelection
+ canonicalization works. The new behavior is to delete the content, but
+ insert nothing. I investigated the possibility of trying to move above
+ or below the frameset in this particular case, but there still isn't a
+ renderer, so it didn't prevent the crash.
+
+ Test: editing/inserting/insert-text-into-empty-frameset-crash.html
+
+ * editing/InsertTextCommand.cpp:
+ (WebCore::InsertTextCommand::doApply):
+
+2011-08-18 Takashi Toyoshima <toyoshim@chromium.org>
+
+ Remove arguments from CloseEvent::create().
+ https://bugs.webkit.org/show_bug.cgi?id=66294
+
+ Reviewed by Kent Tamura.
+
+ CloseEvent objects are initialized by initCloseEvent() in all cases.
+ Initialization in create() is redundant.
+
+ No new tests for no functional difference.
+
+ * websockets/CloseEvent.h:
+ (WebCore::CloseEvent::create):
+ (WebCore::CloseEvent::CloseEvent):
+ * websockets/WebSocket.cpp:
+ (WebCore::WebSocket::didClose):
+
+2011-08-18 Fady Samuel <fsamuel@chromium.org>
+
+ iframe and frameset scaling is broken
+ https://bugs.webkit.org/show_bug.cgi?id=57785
+
+ Reviewed by Simon Fraser.
+
+ Fixed two iframe and frameset scaling bugs:
+ #1 iframes and frameset backgrounds and scroll areas are doubly scaled when they are styled with -webkit-transform.
+ #2 frameset does not respect -webkit-transform-origin when scaled
+
+ Tests: fast/frames/frame-set-scaling-3d.html
+ fast/frames/frame-set-scaling-centered.html
+ fast/frames/frame-set-scaling-rotate.html
+ fast/frames/frame-set-scaling-skew.html
+ fast/frames/frame-set-scaling.html
+ fast/frames/iframe-scaling-with-scroll.html
+
+ * rendering/RenderFrameSet.cpp:
+ (WebCore::RenderFrameSet::layout):
+ Update the FrameSet's layer transform after we've computed size to correctly account for the transform origin.
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::childrenClipRect):
+ The dirty rect should be the document's unscaled size.
+ * rendering/RenderWidget.cpp:
+ (WebCore::RenderWidget::setWidget):
+ (WebCore::RenderWidget::updateWidgetPosition):
+ Don't scale the FrameView rect here. Scaling is done within the FrameView.
+
+2011-08-18 Csaba Osztrogon√°c <ossy@webkit.org>
+
+ Unreviewed buildfix after r93268.
+
+ * dom/Document.cpp:
+ (WebCore::disableRangeMutation):
+
+2011-08-17 Emil A Eklund <eae@chromium.org>
+
+ Switch RenderBox to to new layout types
+ https://bugs.webkit.org/show_bug.cgi?id=66156
+
+ Reviewed by Eric Seidel.
+
+ Convert RenderBox to new layout abstraction as a part of the ongoing
+ conversion work.
+
+ No new tests as no new functionality.
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::scrollWidth):
+ (WebCore::RenderBox::scrollHeight):
+ (WebCore::RenderBox::scrollLeft):
+ (WebCore::RenderBox::scrollTop):
+ (WebCore::RenderBox::setScrollLeft):
+ (WebCore::RenderBox::setScrollTop):
+ (WebCore::RenderBox::absoluteRects):
+ (WebCore::RenderBox::absoluteContentBox):
+ (WebCore::RenderBox::absoluteContentQuad):
+ (WebCore::RenderBox::outlineBoundsForRepaint):
+ (WebCore::RenderBox::reflectionBox):
+ (WebCore::RenderBox::reflectedRect):
+ (WebCore::RenderBox::verticalScrollbarWidth):
+ (WebCore::RenderBox::horizontalScrollbarHeight):
+ (WebCore::RenderBox::computeContentBoxLogicalWidth):
+ (WebCore::RenderBox::computeContentBoxLogicalHeight):
+ (WebCore::RenderBox::maskClipRect):
+ (WebCore::RenderBox::repaintLayerRectsForImage):
+ (WebCore::RenderBox::pushContentsClip):
+ (WebCore::RenderBox::overflowClipRect):
+ (WebCore::RenderBox::clipRect):
+ (WebCore::RenderBox::containingBlockLogicalWidthForContent):
+ (WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):
+ (WebCore::RenderBox::positionLineBox):
+ (WebCore::RenderBox::clippedOverflowRectForRepaint):
+ (WebCore::RenderBox::computeRectForRepaint):
+ (WebCore::RenderBox::computeLogicalWidth):
+ (WebCore::RenderBox::computeInlineDirectionMargins):
+ (WebCore::RenderBox::computeLogicalHeight):
+ (WebCore::RenderBox::computeLogicalHeightUsing):
+ (WebCore::RenderBox::computePercentageLogicalHeight):
+ (WebCore::RenderBox::computeBlockDirectionMargins):
+ (WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
+ (WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
+ (WebCore::computeInlineStaticDistance):
+ (WebCore::RenderBox::computePositionedLogicalWidth):
+ (WebCore::computeLogicalLeftPositionedOffset):
+ (WebCore::RenderBox::computePositionedLogicalWidthUsing):
+ (WebCore::computeBlockStaticDistance):
+ (WebCore::RenderBox::computePositionedLogicalHeight):
+ (WebCore::computeLogicalTopPositionedOffset):
+ (WebCore::RenderBox::computePositionedLogicalHeightUsing):
+ (WebCore::RenderBox::computePositionedLogicalWidthReplaced):
+ (WebCore::RenderBox::computePositionedLogicalHeightReplaced):
+ (WebCore::RenderBox::localCaretRect):
+ (WebCore::RenderBox::lineHeight):
+ (WebCore::RenderBox::baselinePosition):
+ (WebCore::RenderBox::logicalVisualOverflowRectForPropagation):
+ (WebCore::RenderBox::visualOverflowRectForPropagation):
+ (WebCore::RenderBox::logicalLayoutOverflowRectForPropagation):
+ (WebCore::RenderBox::layoutOverflowRectForPropagation):
+ (WebCore::RenderBox::locationOffsetIncludingFlipping):
+ * rendering/RenderBox.h:
+ (WebCore::RenderBox::borderFitAdjust):
+ (WebCore::RenderBox::intrinsicSize):
+ (WebCore::RenderBox::intrinsicLogicalWidth):
+ (WebCore::RenderBox::intrinsicLogicalHeight):
+ (WebCore::RenderBox::scrollbarLogicalHeight):
+ (WebCore::RenderBox::controlClipRect):
+ (WebCore::RenderBox::firstLineBoxBaseline):
+ (WebCore::RenderBox::lastLineBoxBaseline):
+
+2011-08-17 Annie Sullivan <sullivan@chromium.org>
+
+ Reduce usages of String::createUninitialized
+ https://bugs.webkit.org/show_bug.cgi?id=66399
+
+ Constructs Strings with StringBuilder instead of calling createUninitialized.
+
+ Reviewed by Adam Barth.
+
+ No new tests; no functional change.
+
+ * dom/StyleElement.cpp:
+ (WebCore::StyleElement::process):
+ * dom/Text.cpp:
+ (WebCore::Text::wholeText):
+ * html/parser/HTMLSourceTracker.cpp:
+ (WebCore::HTMLSourceTracker::sourceForToken):
+ * platform/graphics/Font.cpp:
+ (WebCore::Font::normalizeSpaces):
+ * platform/text/TextCodecUserDefined.cpp:
+ (WebCore::TextCodecUserDefined::decode):
+
+2011-08-17 Emil A Eklund <eae@chromium.org>
+
+ Switch FrameView to to new layout types
+ https://bugs.webkit.org/show_bug.cgi?id=66147
+
+ Reviewed by Eric Seidel.
+
+ Convert Frame & FrameView to new layout abstraction as a part of the
+ ongoing conversion work.
+
+ No new tests, no new functionality.
+
+ * page/Frame.cpp:
+ (WebCore::Frame::visiblePositionForPoint):
+ (WebCore::Frame::documentAtPoint):
+ (WebCore::Frame::rangeForPoint):
+ (WebCore::Frame::setPageAndTextZoomFactors):
+ (WebCore::Frame::scalePage):
+ * page/Frame.h:
+ * page/FrameView.cpp:
+ (WebCore::FrameView::create):
+ (WebCore::FrameView::reset):
+ (WebCore::FrameView::init):
+ (WebCore::FrameView::invalidateRect):
+ (WebCore::FrameView::setFrameRect):
+ (WebCore::FrameView::setMarginWidth):
+ (WebCore::FrameView::setMarginHeight):
+ (WebCore::FrameView::setContentsSize):
+ (WebCore::FrameView::adjustViewSize):
+ (WebCore::FrameView::scrollXForFixedPosition):
+ (WebCore::FrameView::scrollYForFixedPosition):
+ (WebCore::FrameView::scrollOffsetForFixedPosition):
+ (WebCore::FrameView::currentMousePosition):
+ (WebCore::FrameView::scrollContentsFastPath):
+ (WebCore::FrameView::scrollContentsSlowPath):
+ (WebCore::FrameView::setScrollPosition):
+ (WebCore::FrameView::repaintContentRectangle):
+ (WebCore::FrameView::scrollToAnchor):
+ (WebCore::FrameView::performPostLayoutTasks):
+ (WebCore::FrameView::windowClipRect):
+ (WebCore::FrameView::windowClipRectForLayer):
+ (WebCore::FrameView::scrollTo):
+ (WebCore::FrameView::invalidateScrollbarRect):
+ (WebCore::FrameView::getTickmarks):
+ (WebCore::FrameView::windowResizerRect):
+ (WebCore::FrameView::setVisibleScrollerThumbRect):
+ (WebCore::FrameView::paintScrollCorner):
+ (WebCore::FrameView::paintContents):
+ (WebCore::FrameView::paintOverhangAreas):
+ (WebCore::FrameView::forceLayoutForPagination):
+ (WebCore::FrameView::convertFromRenderer):
+ (WebCore::FrameView::convertToRenderer):
+ (WebCore::FrameView::convertToContainingView):
+ (WebCore::FrameView::convertFromContainingView):
+ * page/FrameView.h:
+ (WebCore::FrameView::marginWidth):
+ (WebCore::FrameView::marginHeight):
+ * page/mac/FrameMac.mm:
+ (WebCore::Frame::snapshotDragImage):
+ (WebCore::Frame::nodeImage):
+
+2011-08-17 Emil A Eklund <eae@chromium.org>
+
+ Switch html/* to to new layout types
+ https://bugs.webkit.org/show_bug.cgi?id=66347
+
+ Reviewed by Eric Seidel.
+
+ Convert HTML* and shadow element to new layout abstraction as a part of
+ the ongoing conversion work.
+
+ No new tests, no new functionality.
+
+ * html/HTMLAreaElement.cpp:
+ (WebCore::HTMLAreaElement::invalidateCachedRegion):
+ (WebCore::HTMLAreaElement::mapMouseEvent):
+ (WebCore::HTMLAreaElement::computePath):
+ (WebCore::HTMLAreaElement::computeRect):
+ (WebCore::HTMLAreaElement::getRegion):
+ * html/HTMLAreaElement.h:
+ * html/HTMLCanvasElement.cpp:
+ (WebCore::HTMLCanvasElement::paint):
+ * html/HTMLCanvasElement.h:
+ * html/HTMLMapElement.cpp:
+ (WebCore::HTMLMapElement::mapMouseEvent):
+ * html/HTMLMapElement.h:
+ * html/ImageDocument.cpp:
+ (WebCore::ImageDocumentParser::finish):
+ (WebCore::ImageDocument::scale):
+ (WebCore::ImageDocument::resizeImageToFit):
+ (WebCore::ImageDocument::imageFitsInWindow):
+ * html/ValidationMessage.cpp:
+ (WebCore::adjustBubblePosition):
+ * html/canvas/CanvasRenderingContext2D.cpp:
+ (WebCore::size):
+ (WebCore::CanvasRenderingContext2D::drawImage):
+ * html/shadow/MediaControlElements.cpp:
+ (WebCore::MediaControlPanelElement::startDrag):
+ (WebCore::MediaControlPanelElement::continueDrag):
+ (WebCore::MediaControlPanelElement::setPosition):
+ (WebCore::MediaControlPanelElement::defaultEventHandler):
+ * html/shadow/MediaControlElements.h:
+ * html/shadow/SliderThumbElement.cpp:
+ (WebCore::SliderThumbElement::dragFrom):
+ (WebCore::SliderThumbElement::setPositionFromPoint):
+ * html/shadow/SliderThumbElement.h:
+ * rendering/RenderImage.cpp:
+ (WebCore::RenderImage::nodeAtPoint):
+
+2011-08-17 David Grogan <dgrogan@chromium.org>
+
+ Change references to leveldb.gyp to leveldatabase.gyp as part of the
+ leveldb refactoring going on in chromium: crbug.com/89378
+ https://bugs.webkit.org/show_bug.cgi?id=66332
+
+ Reviewed by Tony Gentilcore.
+
+ Tests: new-run-webkit-tests --debug --chromium --no-retry-failures --build-directory=llvm storage/indexeddb
+
+ * WebCore.gyp/WebCore.gyp:
+
+2011-08-17 Hayato Ito <hayato@chromium.org>
+
+ Implement proper handling of focus/blur events in regard to shadow DOM boundaries.
+ https://bugs.webkit.org/show_bug.cgi?id=61421
+
+ Reviewed by Dimitri Glazkov.
+
+ Introduces FocusEventDispatchMediator/BlurEventDispatchMediator so
+ that focus/blue events are stopped at the lowest common shadow boundary.
+
+ * dom/Document.cpp:
+ (WebCore::Document::setFocusedNode):
+ * dom/Event.cpp:
+ (WebCore::FocusEventDispatchMediator::create):
+ (WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
+ (WebCore::FocusEventDispatchMediator::dispatchEvent):
+ (WebCore::BlurEventDispatchMediator::create):
+ (WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
+ (WebCore::BlurEventDispatchMediator::dispatchEvent):
+ * dom/Event.h:
+ * dom/Node.cpp:
+ (WebCore::Node::dispatchFocusEvent):
+ (WebCore::Node::dispatchBlurEvent):
+ * dom/Node.h:
+ * html/HTMLFormControlElement.cpp:
+ (WebCore::HTMLFormControlElement::dispatchBlurEvent):
+ * html/HTMLFormControlElement.h:
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::dispatchFocusEvent):
+ (WebCore::HTMLSelectElement::dispatchBlurEvent):
+ * html/HTMLSelectElement.h:
+ * html/HTMLTextFormControlElement.cpp:
+ (WebCore::HTMLTextFormControlElement::dispatchFocusEvent):
+ (WebCore::HTMLTextFormControlElement::dispatchBlurEvent):
+ * html/HTMLTextFormControlElement.h:
+ * page/FocusController.cpp:
+ (WebCore::dispatchEventsOnWindowAndFocusedNode):
+
+2011-08-17 Ben Wells <benwells@chromium.org>
+
+ Canvas fill and fillRect with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy have errors
+ https://bugs.webkit.org/show_bug.cgi?id=66036
+
+ These modes cannot be passed straight through to the underlying graphics context as the graphics context
+ and the HTML5 canvas spec have different interpretations to them. In the graphics context, the compositing
+ modes are applied just over the area being filled. In the HTML5 spec, the compositing modes are applied over
+ the entire canvas.
+
+ The SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy modes all need some kind of extra action
+ to just performing the composited fill on the canvas, as they need t he canvas to be cleared outside of the
+ area being filled.
+
+ Previous to this change the Copy mode did not do this clearing at all. The other modes did but if the
+ transformed path being filled contained anti-aliasing at its edges artifacts were introduced.
+
+ With this change, Copy now does a complete erase of the canvas before performing a fill as per normal.
+ The other modes use a temporary buffer just big enough for the transformed path (in device coordinates).
+ The fill is first done there in SourceOver mode. Then this is drawn into the canvas context using the
+ appropriate mode, with any areas outside the draw area being cleared.
+
+ Reviewed by James Robinson.
+
+ Test: fast/canvas/canvas-composite-transformclip.html
+
+ * html/HTMLCanvasElement.h:
+ * html/canvas/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::fill):
+ (WebCore::CanvasRenderingContext2D::fillRect):
+ (WebCore::CanvasRenderingContext2D::clearCanvas):
+ (WebCore::CanvasRenderingContext2D::transformAreaToDevice):
+ (WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere):
+ * html/canvas/CanvasRenderingContext2D.h:
+ * platform/graphics/skia/ImageBufferSkia.cpp:
+ (WebCore::ImageBuffer::ImageBuffer):
+
+2011-08-17 Emil A Eklund <eae@chromium.org>
+
+ Switch inspector to to new layout types
+ https://bugs.webkit.org/show_bug.cgi?id=66358
+
+ Reviewed by Eric Seidel.
+
+ Convert inspector code to new layout abstraction as a part of the ongoing
+ conversion work.
+
+ No new tests, no new functionality.
+
+ * inspector/DOMNodeHighlighter.cpp:
+ (WebCore::DOMNodeHighlighter::drawNodeHighlight):
+ * inspector/InspectorInstrumentation.cpp:
+ (WebCore::InspectorInstrumentation::willPaintImpl):
+ * inspector/InspectorInstrumentation.h:
+ (WebCore::InspectorInstrumentation::willPaint):
+ * inspector/InspectorTimelineAgent.cpp:
+ (WebCore::InspectorTimelineAgent::willPaint):
+ * inspector/InspectorTimelineAgent.h:
+ * inspector/TimelineRecordFactory.cpp:
+ (WebCore::TimelineRecordFactory::createPaintData):
+ * inspector/TimelineRecordFactory.h:
+
+2011-08-17 Levi Weintraub <leviw@chromium.org>
+
+ Switch Editing code to new layout types
+ https://bugs.webkit.org/show_bug.cgi?id=66355
+
+ Reviewed by Eric Seidel.
+
+ Converting remaining editing code to the LayoutUnit abstraction.
+
+ No new tests, no change in functionality.
+
+ * editing/Editor.cpp:
+ (WebCore::Editor::rangeForPoint):
+ (WebCore::Editor::insideVisibleArea):
+ (WebCore::Editor::countMatchesForText):
+ * editing/Editor.h:
+ * editing/mac/FrameSelectionMac.mm:
+ (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
+
+2011-08-17 Levi Weintraub <leviw@chromium.org>
+
+ Switch Accessibility code to new layout types
+ https://bugs.webkit.org/show_bug.cgi?id=66348
+
+ Reviewed by Eric Seidel.
+
+ Converting remaining Accessibility code to the LayoutUnit abstraction.
+
+ No new tests, no change in functionality
+
+ * accessibility/AccessibilityImageMapLink.cpp:
+ (WebCore::AccessibilityImageMapLink::elementRect):
+ * accessibility/AccessibilityImageMapLink.h:
+ * accessibility/AccessibilityListBox.cpp:
+ (WebCore::AccessibilityListBox::elementAccessibilityHitTest):
+ * accessibility/AccessibilityListBox.h:
+ * accessibility/AccessibilityListBoxOption.cpp:
+ (WebCore::AccessibilityListBoxOption::elementRect):
+ * accessibility/AccessibilityListBoxOption.h:
+ * accessibility/AccessibilityMenuListOption.cpp:
+ (WebCore::AccessibilityMenuListOption::elementRect):
+ * accessibility/AccessibilityMenuListOption.h:
+ (WebCore::AccessibilityMenuListOption::size):
+ * accessibility/AccessibilityMenuListPopup.h:
+ (WebCore::AccessibilityMenuListPopup::elementRect):
+ (WebCore::AccessibilityMenuListPopup::size):
+ * accessibility/AccessibilityObject.cpp:
+ (WebCore::AccessibilityObject::clickPoint):
+ (WebCore::AccessibilityObject::orientation):
+ (WebCore::AccessibilityObject::elementAccessibilityHitTest):
+ * accessibility/AccessibilityObject.h:
+ (WebCore::AccessibilityObject::accessibilityHitTest):
+ (WebCore::AccessibilityObject::boundingBoxRect):
+ (WebCore::AccessibilityObject::size):
+ (WebCore::AccessibilityObject::boundsForVisiblePositionRange):
+ (WebCore::AccessibilityObject::doAXBoundsForRange):
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::isOffScreen):
+ (WebCore::AccessibilityRenderObject::boundingBoxRect):
+ (WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
+ (WebCore::AccessibilityRenderObject::elementRect):
+ (WebCore::AccessibilityRenderObject::size):
+ (WebCore::AccessibilityRenderObject::clickPoint):
+ (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
+ (WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):
+ (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
+ (WebCore::AccessibilityRenderObject::doAXBoundsForRange):
+ * accessibility/AccessibilityRenderObject.h:
+ * accessibility/AccessibilityScrollView.cpp:
+ (WebCore::AccessibilityScrollView::accessibilityHitTest):
+ (WebCore::AccessibilityScrollView::elementRect):
+ * accessibility/AccessibilityScrollView.h:
+ * accessibility/AccessibilityScrollbar.cpp:
+ (WebCore::AccessibilityScrollbar::elementRect):
+ * accessibility/AccessibilityScrollbar.h:
+ * accessibility/AccessibilitySlider.cpp:
+ (WebCore::AccessibilitySliderThumb::elementRect):
+ (WebCore::AccessibilitySliderThumb::size):
+ * accessibility/AccessibilitySlider.h:
+ * accessibility/AccessibilityTableColumn.cpp:
+ (WebCore::AccessibilityTableColumn::elementRect):
+ (WebCore::AccessibilityTableColumn::size):
+ * accessibility/AccessibilityTableColumn.h:
+ * accessibility/AccessibilityTableHeaderContainer.cpp:
+ (WebCore::AccessibilityTableHeaderContainer::elementRect):
+ (WebCore::AccessibilityTableHeaderContainer::size):
+ * accessibility/AccessibilityTableHeaderContainer.h:
+ * accessibility/mac/AccessibilityObjectWrapper.mm:
+ (-[AccessibilityObjectWrapper position]):
+ (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
+ (-[AccessibilityObjectWrapper accessibilityShowContextMenu]):
+
+2011-08-17 Emil A Eklund <eae@chromium.org>
+
+ Switch focus handling to to new layout types
+ https://bugs.webkit.org/show_bug.cgi?id=66331
+
+ Reviewed by Eric Seidel.
+
+ Convert FocusController and SpatialNavigation to new layout abstraction
+ as a part of the ongoing conversion work.
+
+ No new tests, no new functionality.
+
+ * page/FocusController.cpp:
+ (WebCore::updateFocusCandidateIfNeeded):
+ (WebCore::FocusController::findFocusCandidateInContainer):
+ (WebCore::FocusController::advanceFocusDirectionallyInContainer):
+ (WebCore::FocusController::advanceFocusDirectionally):
+ * page/FocusController.h:
+ * page/SpatialNavigation.cpp:
+ (WebCore::alignmentForRects):
+ (WebCore::start):
+ (WebCore::middle):
+ (WebCore::end):
+ (WebCore::areRectsFullyAligned):
+ (WebCore::areRectsPartiallyAligned):
+ (WebCore::areRectsMoreThanFullScreenApart):
+ (WebCore::below):
+ (WebCore::rightOf):
+ (WebCore::isRectInDirection):
+ (WebCore::hasOffscreenRect):
+ (WebCore::scrollInDirection):
+ (WebCore::deflateIfOverlapped):
+ (WebCore::canScrollInDirection):
+ (WebCore::rectToAbsoluteCoordinates):
+ (WebCore::nodeRectInAbsoluteCoordinates):
+ (WebCore::frameRectInAbsoluteCoordinates):
+ (WebCore::entryAndExitPointsForDirection):
+ (WebCore::distanceDataForNode):
+ (WebCore::canBeScrolledIntoView):
+ (WebCore::virtualRectForDirection):
+ (WebCore::virtualRectForAreaElementAndDirection):
+ * page/SpatialNavigation.h:
+
+2011-08-17 Levi Weintraub <leviw@chromium.org>
+
+ Switch Document, DocumentMarker, Clipboard, and Range to new layout types
+ https://bugs.webkit.org/show_bug.cgi?id=66330
+
+ Reviewed by Eric Seidel.
+
+ Converting the remaining DOM classes to use the LayoutUnit abstraction.
+
+ No new tests, no new behavior.
+
+ * dom/Clipboard.h:
+ (WebCore::Clipboard::dragLocation):
+ * dom/Document.cpp:
+ (WebCore::Document::nodesFromRect):
+ (WebCore::nodeFromPoint):
+ (WebCore::Document::caretRangeFromPoint):
+ (WebCore::Document::prepareMouseEvent):
+ * dom/Document.h:
+ * dom/DocumentMarkerController.cpp:
+ (WebCore::DocumentMarkerController::markerContainingPoint):
+ (WebCore::DocumentMarkerController::renderedRectsForMarkers):
+ (WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):
+ * dom/DocumentMarkerController.h:
+ * dom/Range.cpp:
+ (WebCore::adjustFloatQuadsForScrollAndAbsoluteZoomAndPageScale):
+ * dom/RenderedDocumentMarker.h:
+ (WebCore::RenderedDocumentMarker::contains):
+ (WebCore::RenderedDocumentMarker::setRenderedRect):
+ (WebCore::RenderedDocumentMarker::renderedRect):
+ (WebCore::RenderedDocumentMarker::invalidMarkerRect):
+ (WebCore::RenderedDocumentMarker::invalidate):
+
+2011-08-17 Dan Bernstein <mitz@apple.com>
+
+ Removed an unused setting.
+
+ Reviewed by Anders Carlsson.
+
+ * WebCore.exp.in:
+ * page/Settings.cpp:
+ (WebCore::Settings::Settings): Removed initializer for m_needsTigerMailQuirks.
+ * page/Settings.h: Removed accessors.
+
+2011-08-17 Oliver Hunt <oliver@apple.com>
+
+ Move towards supporting user controlled prototypes on CanvasPixelArray
+ https://bugs.webkit.org/show_bug.cgi?id=66429
+
+ Reviewed by Gavin Barraclough.
+
+ Start using a per-global object structure for canvas pixel array.
+
+ * bindings/js/JSImageDataCustom.cpp:
+ (WebCore::toJS):
+
+2011-08-17 Luke Macpherson <macpherson@chromium.org>
+
+ Support cast from CSSPrimitiveValue to unsigned, and use in appropriate places in CSSStyleSelector::applyProperty
+ https://bugs.webkit.org/show_bug.cgi?id=66281
+
+ Reviewed by Eric Seidel.
+
+ No new tests - refactoring only.
+
+ The return if type!=CSS_NUMBER case becomes an ASSERT because it is unreachable unless there is an error in the parser.
+
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ Support cast from unsigned to CSSPrimitiveValue
+ (WebCore::CSSPrimitiveValue::operator unsigned):
+ Support cast from CSSPrimitiveValue to unsigned
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::applyProperty):
+ Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro for CSSPropertyWebkitBoxFlex,
+ CSSPropertyWebkitBoxFlexGroup and CSSPropertyWebkitBoxOrdinalGroup properties.
+
+2011-08-17 Scott Byer <scottbyer@chromium.org>
+
+ ScrollAnimatorNone: Remove unused field
+ https://bugs.webkit.org/show_bug.cgi?id=66312
+
+ Reviewed by Adam Barth.
+
+ No functional change; no test needed.
+
+ * platform/ScrollAnimatorNone.cpp:
+ (WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
+ (WebCore::ScrollAnimatorNone::scroll):
+ * platform/ScrollAnimatorNone.h:
+
+2011-08-17 Jeff Miller <jeffm@apple.com>
+
+ Work-in-progress on Soft link against AVFoundationCF and CoreMedia
+ https://bugs.webkit.org/show_bug.cgi?id=65725
+
+ Don't bother with SOFT_LINK_LIBRARY(libdispatch), we're going to continue to statically link to it since
+ the DLL will have already been loaded by other parts of AAS and is guaranteed to be available if AVFoundation
+ is enabled.
+
+ Reviewed by Anders Carlsson.
+
+ No new tests; no functional change.
+
+ * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Removed SOFT_LINK_DEBUG_LIBRARY(libdispatch) and SOFT_LINK_LIBRARY(libdispatch).
+ (WebCore::MediaPlayerPrivateAVFoundationCF::isAvailable): Don't check for libdispatch.
+
+2011-08-17 Brady Eidson <beidson@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=66354 and <rdar://problem/9965209>
+ Regression: On Lion, redirects lose HTTP authentication headers
+
+ Reviewed by Alexey Proskuryakov and Darin Adler.
+
+ This changes makes WebCore try to apply basic credentials after a redirect if the redirect is to the same origin,
+ assuming the redirected URL did not contain credentials directly.
+
+ Tests: http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin.html
+ http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin.html
+ http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html
+
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::applyBasicAuthorizationHeader): Apply the user/password from a credential to the HTTP headers for a request.
+ (WebCore::ResourceHandle::createCFURLConnection): Use the applyBasicAuthorizationHeader helper.
+ (WebCore::ResourceHandle::willSendRequest): If this is a redirect within the same origin, apply any stored target credentials to the new request.
+
+ * platform/network/mac/ResourceHandleMac.mm:
+ (WebCore::applyBasicAuthorizationHeader): Apply the user/password from a credential to the HTTP headers for a request.
+ (WebCore::ResourceHandle::createNSURLConnection): Use the applyBasicAuthorizationHeader helper.
+ (WebCore::ResourceHandle::willSendRequest): If this is a redirect within the same origin, apply any stored target credentials to the new request.
+
+2011-08-17 Chris Fleizach <cfleizach@apple.com>
+
+ Accessibility stack exhaustion using role attribute
+ https://bugs.webkit.org/show_bug.cgi?id=65174
+
+ Reviewed by Darin Adler.
+
+ Forgot to commit review comments.
+
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::remapAriaRoleDueToParent):
+
+2011-08-17 Chris Fleizach <cfleizach@apple.com>
+
+ Accessibility stack exhaustion using role attribute
+ https://bugs.webkit.org/show_bug.cgi?id=65174
+
+ Make sure we do not call accessibilityIsIgnored() during the AccessibilityObject
+ creation flow. That can lead to loops.
+
+ Reviewed by Darin Adler.
+
+ Tests: accessibility/crash-determining-aria-role-when-label-present.html
+
+ * accessibility/AccessibilityObject.cpp:
+ (WebCore::createARIARoleMap):
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::remapAriaRoleDueToParent):
+ (WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
+ * accessibility/AccessibilityRenderObject.h:
+
+2011-08-17 James Robinson <jamesr@chromium.org>
+
+ [chromium] Crash if compositing is disabled during updateLayers()
+ https://bugs.webkit.org/show_bug.cgi?id=66353
+
+ Reviewed by Kenneth Russell.
+
+ If compositing is turned off during LayerRendererChromium::updateLayers(), the rootLayer() will become null.
+ Sicne CCLayerTreeHost::doComposite() calls updateLayers() and then drawLayers() without checking for this case,
+ drawLayers() has to return without doing anything if the root layer is null.
+
+ Crash fixed based on crash reports. No known reliably repro case, unfortunately.
+
+ * platform/graphics/chromium/LayerRendererChromium.cpp:
+ (WebCore::LayerRendererChromium::drawLayers):
+
+2011-08-17 Dan Bernstein <mitz@apple.com>
+
+ <rdar://problem/9971293> Mid-word breaks can occur in the middle of a surrogate pair
+ https://bugs.webkit.org/show_bug.cgi?id=66402
+
+ Reviewed by Dave Hyatt.
+
+ Test: fast/text/midword-break-before-surrogate-pair-2.html
+
+ * rendering/RenderBlockLineLayout.cpp:
+ (WebCore::RenderBlock::LineBreaker::nextLineBreak): Just never allow a mid-word
+ break before a trailing surrogate.
+
+2011-08-16 Chang Shu <cshu@webkit.org>
+
+ Support reset in WebCore::Internals
+ https://bugs.webkit.org/show_bug.cgi?id=66307
+
+ Reviewed by Dimitri Glazkov.
+
+ New tests will be added when function reset is implemented.
+
+ Added framework code in WebCoreTestSupport. The real implementation of
+ Internals::reset() depends on the need from the settings that require a reset.
+
+ * testing/Internals.cpp:
+ (WebCore::Internals::reset):
+ * testing/Internals.h:
+ * testing/js/WebCoreTestSupport.cpp:
+ (WebCoreTestSupport::resetInternalsObject):
+ * testing/js/WebCoreTestSupport.h:
+ * testing/v8/WebCoreTestSupport.cpp:
+ (WebCoreTestSupport::resetInternalsObject):
+ * testing/v8/WebCoreTestSupport.h:
+
+2011-08-17 Tony Chang <tony@chromium.org>
+
+ Fix chromium mac compile. MediaPlayerPrivateAVFoundationObjC.* moved
+ and the WebCore.gypi file wasn't updated.
+
+ * WebCore.gypi:
+
+2011-08-17 Abhishek Arya <inferno@chromium.org>
+
+ Crash in Document::recalcStyleSelector
+ https://bugs.webkit.org/show_bug.cgi?id=66335
+
+ Reviewed by Simon Fraser.
+
+ When node is getting destroyed and its removedFromDocument
+ is not called due to entire document structure torn down(using
+ removeAllChildren), make sure to clear out the stylesheet
+ candidate node from document's structures in its destructor.
+
+ Test: svg/dom/stylesheet-candidate-node-crash-main.html
+
+ * dom/ProcessingInstruction.cpp:
+ (WebCore::ProcessingInstruction::~ProcessingInstruction):
+ * html/HTMLLinkElement.cpp:
+ (WebCore::HTMLLinkElement::~HTMLLinkElement):
+ * html/HTMLStyleElement.cpp:
+ (WebCore::HTMLStyleElement::~HTMLStyleElement):
+ * svg/SVGStyleElement.cpp:
+ (WebCore::SVGStyleElement::~SVGStyleElement):
+
+2011-08-17 Sam White <samuel.white@rochester.edu>
+
+ AccessibilityObject levels are inconsistent
+ https://bugs.webkit.org/show_bug.cgi?id=66180
+
+ Updated accessibilityTable to return level values consistent with other accessibilityObjects that
+ return level values. This means a value of 0 is now only returned when tableLevel() is called on a
+ non-table element.
+
+ Reviewed by Chris Fleizach.
+
+ Test: platform/mac/accessibility/element-level.html
+
+ * accessibility/AccessibilityTable.cpp:
+ (WebCore::AccessibilityTable::tableLevel):
+ * accessibility/mac/AccessibilityObjectWrapper.mm:
+ (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
+
+2011-08-17 Ryosuke Niwa <rniwa@webkit.org>
+
+ An arrow key collapses directionless selection range in the wrong direction in BiDi
+ https://bugs.webkit.org/show_bug.cgi?id=64626
+
+ Reviewed by Darin Adler.
+
+ The bug was caused by willBeModified's always using block direction to determine
+ the direction to which the selection is collapsed. Fixed the bug by calling directionOfSelection
+ in willBeModified, which will return the text direction of the surrounding context when
+ the start and the end have the same direction. When the text directions at the start and at the end
+ of selection do not match, it uses the block's text direction.
+
+ Test: editing/selection/collapse-selection-in-bidi.html
+
+ * editing/FrameSelection.cpp:
+ (WebCore::FrameSelection::directionOfSelection): Added.
+ (WebCore::FrameSelection::willBeModified): Calls directionOfSelection.
+ (WebCore::FrameSelection::modifyMovingRight): Ditto.
+ (WebCore::FrameSelection::modifyMovingLeft): Ditto.
+ * editing/FrameSelection.h:
+
+2011-08-17 Jeff Miller <jeffm@apple.com>
+
+ Some AVFoundation source files should be in platform-specific directories
+ https://bugs.webkit.org/show_bug.cgi?id=66352
+
+ Moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.* files to platform/graphics/avfoundation/cf,
+ and moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.* files to platform/graphics/avfoundation/objc/.
+
+ While I was at it, added svn:eol-style property to the MediaPlayerPrivateAVFoundationObjC.* files.
+
+ Also, for some reason, Visual Studio decided to re-sort a couple files in \inspector\front-end\ in WebCore.vcproj, even though
+ I just re-sorted the project in r93215.
+
+ Reviewed by Eric Carlson.
+
+ No new tests; no functional change.
+
+ * WebCore.vcproj/WebCore.vcproj: Moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.* files to platform/graphics/avfoundation/cf.
+
+ * WebCore.vcproj/WebCoreMediaQT.vsprops: Added $(ProjectDir)..\platform\graphics\avfoundation\cf to include paths.
+
+ * WebCore.xcodeproj/project.pbxproj: Moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.* files to platform/graphics/avfoundation/objc/.
+
+ * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Removed.
+ * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.h: Removed.
+ * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h: Removed.
+ * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: Removed.
+
+ * platform/graphics/avfoundation/cf: Added.
+ * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp.
+ * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.h.
+
+ * platform/graphics/avfoundation/objc: Added.
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h.
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm.
+
+2011-08-17 Luke Macpherson <macpherson@chromium.org>
+
+ Only set m_fontDirty if TextSizeAdjust is actually changed.
+ https://bugs.webkit.org/show_bug.cgi?id=66022
+
+ Reviewed by Darin Adler.
+
+ No new tests. Refactoring only.
+
+ Reduces instances where the font information is dirtied to save recalculation where it is not necessary.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::applyProperty):
+ Call new setTextSizeAdjust function.
+ * css/CSSStyleSelector.h:
+ (WebCore::CSSStyleSelector::setTextSizeAdjust):
+ Add wrapper for RenderStyle::setTextSizeAdjust() that automatically updates m_fontDirty.
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::setTextSizeAdjust):
+ Make setTextSizeAdjust return true if the unlderlying value was changed.
+
+2011-08-17 Kenichi Ishibashi <bashi@chromium.org>
+
+ [Chromium] Crash in HarfbuzzFace::~HarfbuzzFace
+ https://bugs.webkit.org/show_bug.cgi?id=66211
+
+ Holds Skia's unique font ID instead of FontPlatformData to avoid accessing freed FontPlatformData.
+
+ Reviewed by Tony Chang.
+
+ No new tests; no functional change.
+
+ * platform/graphics/chromium/HarfbuzzSkia.cpp:
+ (WebCore::releaseCachedHarfbuzzFace): Changed the argument.
+ (WebCore::HarfbuzzFace::HarfbuzzFace): Changed to have Skia's font uniqueID instead of FontPlatformData.
+ (WebCore::HarfbuzzFace::~HarfbuzzFace): Uses m_uniqueID to call releaseCachedHarfbuzzFace.
+ * platform/graphics/chromium/HarfbuzzSkia.h:
+
+2011-08-17 Jeff Miller <jeffm@apple.com>
+
+ Re-sort the WebCore project with Visual Studio after recent changes that I assume were done by manually editing the XML.
+
+ * WebCore.vcproj/WebCore.vcproj:
+
+2011-08-17 Sailesh Agrawal <sail@chromium.org>
+
+ Chromium Mac: Fix implementation of wkScrollbarMinimumTotalLengthNeededForThumb to match WebKitSystemInterface
+ https://bugs.webkit.org/show_bug.cgi?id=66311
+
+ Reviewed by Dimitri Glazkov.
+
+ Updated wkScrollbarMinimumTotalLengthNeededForThumb() based on the latest disassembly of libWebKitSystemInterfaceLion.a.
+
+ * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
+ (wkScrollbarMinimumTotalLengthNeededForThumb):
+
+2011-08-17 Steve Block <steveblock@google.com>
+
+ Unreviewed, rolling out r93186.
+ http://trac.webkit.org/changeset/93186
+ https://bugs.webkit.org/show_bug.cgi?id=66114
+
+ Breaks LayoutTests on Chromium canary bots
+
+ * platform/graphics/chromium/LayerChromium.h:
+ * platform/graphics/chromium/LayerRendererChromium.cpp:
+ (WebCore::LayerRendererChromium::updateLayers):
+ (WebCore::LayerRendererChromium::drawLayersInternal):
+ (WebCore::LayerRendererChromium::drawLayer):
+ * platform/graphics/chromium/cc/CCLayerImpl.h:
+
+2011-08-17 Ryosuke Niwa <rniwa@webkit.org>
+
+ Get rid of calls to deprecatedNode and deprecatedEditingOffset in
+ AccessibilityRenderObject.cpp and InsertTextCommand.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=66014
+
+ Reviewed by Hajime Morita.
+
+ Removed calls to deprecatedNode and deprecatedEditingOffsets in the following files.
+
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::indexForVisiblePosition): Calls Position::rootEditableElement
+ and Range::setEnd(const Position&, ExceptionCode) instead of manually pulling deprecatedNode
+ and deprecatedEditingOffset.
+ (WebCore::AccessibilityRenderObject::index): Abstracted the logic to loop through render objects
+ from deprecatedNodes' renderer to m_renderer as renderObjectContainsPosition.
+ * dom/Position.h:
+ (WebCore::Position::rootEditableElement): Added.
+ * dom/Range.cpp:
+ (WebCore::Range::setStart): Added.
+ (WebCore::Range::setEnd): Added.
+ * dom/Range.h:
+ * editing/InsertTextCommand.cpp:
+ (WebCore::InsertTextCommand::insertTab):
+ * editing/RenderedPosition.cpp:
+ (WebCore::renderObjectContainsPosition): Extracted from AccessibilityRenderObject::index.
+ * editing/RenderedPosition.h:
+
+2011-08-17 Sailesh Agrawal <sail@chromium.org>
+
+ Chromium Mac: Fix issue where scrollbar wouldn't be drawn until page finished loading
+ https://bugs.webkit.org/show_bug.cgi?id=66238
+
+ Reviewed by Dimitri Glazkov.
+
+ Overlay scrollbars were not visible if the user scrolled a page while the page was loading. The sequence of events necessary to reproduce this bug were:
+ 1. -[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:] is called
+ 2. animation is delayed because shouldSuspendScrollAnimations() is true
+ 3. ScrollAnimatorChromiumMac::scroll() is called before the ScrollAnimatorChromiumMac::m_initialScrollbarPaintTimer is fired.
+ 4. At this point the scrollbar painter assumes the scrollbar is already visible (because of 1.) so the scrollbar's alpha stays at 0. Thus the scrollbar isn't visible until the page finishes loading.
+ It turns out that the root problem was that when the initialScrollbarPainterTimer fired I wasn't flashing the scrollbar correctly. My implementation of wkScrollbarPainterForceFlashScrollers() just called flashScrollers. The Safari implementation of this function also calls hideOverlayScrollers. Calling hideOverlayScrollers causes the alpha to change to 0 which prevents step 4 from happening.
+
+ Also, now that wkScrollbarPainterForceFlashScrollers is working correctly I don't need the extra logic I added to the initialScrollbarPainterTimer handler. That logic restarted the timer if shouldSuspendScrollAnimations() was true. But this isn't necessary since calling wkScrollbarPainterForceFlashScrollers() causes -[ScrollbarPainterDelegate setUpAnimation:...] to be called which does the exact same thing. Removing the extra logic reverts http://trac.webkit.org/changeset/92316.
+
+ * platform/chromium/ScrollAnimatorChromiumMac.mm:
+ (WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired):
+ * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
+ (wkScrollbarPainterForceFlashScrollers):
+
+2011-08-16 Andrey Kosyakov <caseq@chromium.org>
+
+ Web Inspector: maintain visible view hierarchy and dispatch common view events automatically
+ https://bugs.webkit.org/show_bug.cgi?id=66131
+
+ Reviewed by Pavel Feldman.
+
+ Test: inspector/view-events.html
+
+ - added a notion of an optional parent to a View
+ - maintain a list of View children
+ - dispatch common view events, such as show/hide/resize automatically through the hierarchy of visible views.
+ - promoted Panel's logic of (re)storing scroll positions to view
+ - demoted inheritScrollPositionFromView to a couple of views that need it.
+
+ * inspector/front-end/ApplicationCacheItemsView.js:
+ (WebInspector.ApplicationCacheItemsView.prototype.onResize):
+ * inspector/front-end/ConsoleView.js:
+ (WebInspector.ConsoleView.prototype.populateStatusBar):
+ (WebInspector.ConsoleView.prototype.elementsToRestoreScrollPositionsFor):
+ * inspector/front-end/CookieItemsView.js:
+ (WebInspector.CookieItemsView.prototype.onResize):
+ (WebInspector.SimpleCookiesTable.prototype.onResize):
+ * inspector/front-end/DOMStorageItemsView.js:
+ (WebInspector.DOMStorageItemsView.prototype.onResize):
+ * inspector/front-end/DetailedHeapshotView.js:
+ (WebInspector.DetailedHeapshotView.prototype.onResize):
+ * inspector/front-end/Drawer.js:
+ (WebInspector.Drawer.prototype.set visibleView):
+ (WebInspector.Drawer.prototype.show):
+ (WebInspector.Drawer.prototype.hide):
+ (WebInspector.Drawer.prototype.onResize):
+ (WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished):
+ (WebInspector.Drawer.prototype._animateDrawerHeight):
+ (WebInspector.Drawer.prototype._statusBarDragging):
+ (WebInspector.Drawer.prototype._endStatusBarDragging):
+ * inspector/front-end/ElementsPanel.js:
+ (WebInspector.ElementsPanel.prototype.onResize):
+ * inspector/front-end/ExtensionPanel.js:
+ * inspector/front-end/FontView.js:
+ (WebInspector.FontView.prototype.onResize):
+ * inspector/front-end/IFrameView.js:
+ (WebInspector.IFrameView):
+ * inspector/front-end/NetworkItemView.js:
+ (WebInspector.NetworkItemView.prototype._installHighlightSupport):
+ * inspector/front-end/NetworkPanel.js:
+ (WebInspector.NetworkLogView):
+ (WebInspector.NetworkLogView.prototype.elementsToRestoreScrollPositionsFor):
+ (WebInspector.NetworkLogView.prototype.onResize):
+ (WebInspector.NetworkLogView.prototype.wasShown):
+ (WebInspector.NetworkLogView.prototype.willHide):
+ (WebInspector.NetworkPanel):
+ (WebInspector.NetworkPanel.prototype.show):
+ (WebInspector.NetworkPanel.prototype._showResource):
+ (WebInspector.NetworkPanel.prototype._closeVisibleResource):
+ * inspector/front-end/Panel.js:
+ (WebInspector.Panel.prototype.show):
+ (WebInspector.Panel.prototype.hide):
+ (WebInspector.Panel.prototype.performSearch.processChunk):
+ (WebInspector.Panel.prototype.performSearch):
+ (WebInspector.Panel.prototype.updateSidebarWidth):
+ * inspector/front-end/PanelEnablerView.js:
+ (WebInspector.PanelEnablerView.prototype.show):
+ (WebInspector.PanelEnablerView.prototype.onResize):
+ * inspector/front-end/ProfileView.js:
+ (WebInspector.CPUProfileView.prototype.onResize):
+ * inspector/front-end/ProfilesPanel.js:
+ (WebInspector.ProfilesPanel.prototype.updateMainViewWidth):
+ * inspector/front-end/ResourceCookiesView.js:
+ (WebInspector.ResourceCookiesView.prototype.onResize):
+ * inspector/front-end/ResourcePreviewView.js:
+ (WebInspector.ResourcePreviewView.prototype.contentLoaded):
+ * inspector/front-end/ResourceResponseView.js:
+ (WebInspector.ResourceResponseView.prototype.contentLoaded):
+ * inspector/front-end/ResourceTimingView.js:
+ (WebInspector.ResourceTimingView.prototype.show):
+ * inspector/front-end/ResourcesPanel.js:
+ (WebInspector.ResourcesPanel.prototype.show):
+ (WebInspector.ResourcesPanel.prototype._innerShowView):
+ (WebInspector.ResourcesPanel.prototype.closeVisibleView):
+ (WebInspector.ResourcesPanel.prototype.updateMainViewWidth):
+ (WebInspector.FrameResourceTreeElement.prototype._recreateSourceView):
+ * inspector/front-end/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel.prototype.show):
+ (WebInspector.ScriptsPanel.prototype._createSourceFrame):
+ (WebInspector.ScriptsPanel.prototype._removeSourceFrame):
+ (WebInspector.ScriptsPanel.prototype.setSidebarWidth):
+ * inspector/front-end/SourceFrame.js:
+ (WebInspector.SourceFrame):
+ (WebInspector.SourceFrame.prototype.show):
+ (WebInspector.SourceFrame.prototype.willHide):
+ (WebInspector.SourceFrame.prototype.clearMessages):
+ (WebInspector.SourceFrame.prototype._setTextViewerDecorations):
+ (WebInspector.SourceFrame.prototype.inheritScrollPositions):
+ * inspector/front-end/TabbedPane.js:
+ (WebInspector.TabbedPane.prototype.appendTab):
+ * inspector/front-end/TextViewer.js:
+ (WebInspector.TextViewer.prototype.elementsToRestoreScrollPositionsFor):
+ (WebInspector.TextViewer.prototype.inheritScrollPositions):
+ (WebInspector.TextViewer.prototype.onResize):
+ * inspector/front-end/TimelinePanel.js:
+ (WebInspector.TimelinePanel.prototype.onResize):
+ (WebInspector.TimelinePanel.prototype.elementsToRestoreScrollPositionsFor):
+ (WebInspector.TimelinePanel.prototype.show):
+ * inspector/front-end/View.js:
+ (WebInspector.View):
+ (WebInspector.View.prototype.wasShown):
+ (WebInspector.View.prototype.willHide):
+ (WebInspector.View.prototype._innerShow):
+ (WebInspector.View.prototype.show):
+ (WebInspector.View.prototype._innerHide):
+ (WebInspector.View.prototype.hide):
+ (WebInspector.View.prototype._detach):
+ (WebInspector.View.prototype.elementsToRestoreScrollPositionsFor):
+ (WebInspector.View.prototype.storeScrollPositions):
+ (WebInspector.View.prototype.restoreScrollPositions):
+ (WebInspector.View.prototype.addChildView):
+ (WebInspector.View.prototype.removeChildView):
+ (WebInspector.View.prototype.onResize):
+ (WebInspector.View.prototype.doResize):
+ (WebInspector.View.prototype.dispatchToSelfAndVisibleChildren):
+ (WebInspector.View.prototype.dispatchToVisibleChildren):
+ * inspector/front-end/inspector.js:
+ (WebInspector.windowResize):
+
+2011-08-16 Luke Macpherson <macpherson@chromium.org>
+
+ Represent RenderStyle::textOverflow property using an enum instead of a bool.
+ https://bugs.webkit.org/show_bug.cgi?id=66356
+
+ Reviewed by Dan Bernstein.
+
+ No new tests - no behavioral changes.
+
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ Support cast from TextOverflow to CSSPrimitiveValue.
+ (WebCore::CSSPrimitiveValue::operator TextOverflow):
+ Support cast from CSSPrimitiveValue to TextOverflow.
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::applyProperty):
+ Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro for text overflow.
+ * rendering/style/RenderStyle.h:
+ (WebCore::InheritedFlags::textOverflow):
+ Return TextOverflow enum.
+ (WebCore::InheritedFlags::setTextOverflow):
+ Accept TextOverflow enum parameter.
+ (WebCore::InheritedFlags::initialTextOverflow):
+ Return TextOverflowClip.
+ * rendering/style/RenderStyleConstants.h:
+ Define TextOverflow enum.
+ * rendering/style/StyleRareNonInheritedData.h:
+ Change representation of text overflow from bool to one-bit unsigned.
+
+2011-08-16 Jeff Miller <jeffm@apple.com>
+
+ Apple's Windows production build should fail to compile if AVFoundation is not enabled
+ https://bugs.webkit.org/show_bug.cgi?id=66339
+
+ Generate a compile-time error for Production builds if !USE(AVFOUNDATION).
+
+ Reviewed by Darin Adler.
+
+ * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Generate a compile-time error for Production builds if !USE(AVFOUNDATION).
+
+2011-08-16 David Levin <levin@chromium.org>
+
+ REGRESSION (r89086): All worker xhr requests trigger preflight requests.
+ https://bugs.webkit.org/show_bug.cgi?id=66340
+
+ Reviewed by Adam Barth.
+
+ Test coming in a more comprehensive patch shortly. This is just a very targetted
+ patch to allow for easier merging.
+
+ * loader/CrossOriginAccessControl.cpp:
+ (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Add referer to the list
+ of whitelisted headers. It can't be set by xhr so it is ok to whitelist it, but it is
+ set before calling this function. This is similar to what is done for "origin" in here.
+
+2011-08-16 Shawn Singh <shawnsingh@chromium.org>
+
+ Computing screen-space transform for LayerChromium and CCLayerImpl
+ https://bugs.webkit.org/show_bug.cgi?id=66114
+
+ Reviewed by James Robinson.
+
+ Test: compositing/backface-visibility-hierarchical-transform.html
+
+ Added a data member to LayerChromium and CCLayerImpl that holds
+ the screen-space transform. The transform is computed in
+ calculateDrawTransformsAndVisibility(), which is used during
+ updating (LayerChromium) and drawing (CCLayerImpl). This transform
+ will also be used for other things, such as HUD drawing, in upcoming
+ patches.
+
+ Also fixed a FIXME in LayerRendererChromium::drawLayer, which
+ was not computing the entire hierarchy of transforms to determine
+ back-face visibility. Now it simply uses the screen space transform.
+
+ * platform/graphics/chromium/LayerChromium.h:
+ (WebCore::LayerChromium::screenSpaceDrawTransform):
+ (WebCore::LayerChromium::setScreenSpaceDrawTransform):
+ * platform/graphics/chromium/LayerRendererChromium.cpp:
+ (WebCore::LayerRendererChromium::updateLayers):
+ (WebCore::LayerRendererChromium::drawLayersInternal):
+ (WebCore::LayerRendererChromium::drawLayer):
+ (WebCore::calculateDrawTransformsAndVisibility):
+ * platform/graphics/chromium/cc/CCLayerImpl.h:
+ (WebCore::CCLayerImpl::screenSpaceDrawTransform):
+ (WebCore::CCLayerImpl::setScreenSpaceDrawTransform):
+
+2011-08-16 Hayato Ito <hayato@chromium.org>
+
+ Implement proper handling of events which happen in children of shadow hosts.
+ https://bugs.webkit.org/show_bug.cgi?id=66285
+
+ Reviewed by Dimitri Glazkov.
+
+ Fix the issue where a shadow host stops an event propagation if an
+ event happens at the children of shadow hosts, outside of the shadow root.
+
+ Test: fast/dom/shadow/shadow-contents-event.html
+
+ * dom/EventDispatcher.cpp:
+ (WebCore::EventDispatcher::adjustToShadowBoundaries):
+
+2011-08-16 Per-Erik Brodin <per-erik.brodin@ericsson.com>
+
+ Make it possible to explicitly prevent a preflight via ThreadableLoaderOptions
+ https://bugs.webkit.org/show_bug.cgi?id=65694
+
+ Reviewed by Alexey Proskuryakov.
+
+ No new tests since there is no change in behavior.
+
+ * fileapi/FileReaderLoader.cpp:
+ (WebCore::FileReaderLoader::start):
+ * loader/DocumentThreadableLoader.cpp:
+ (WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
+ (WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
+ * loader/ThreadableLoader.h:
+ (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions):
+ * notifications/Notification.cpp:
+ (WebCore::Notification::startLoading):
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::createRequest):
+
+2011-08-16 Scott Byer <scottbyer@chromium.org>
+
+ Fix spelling error.
+ https://bugs.webkit.org/show_bug.cgi?id=66261
+
+ Reviewed by Adam Barth.
+
+ No functional change, no tests needed.
+
+ * platform/ScrollAnimator.cpp:
+ (WebCore::ScrollAnimator::scroll):
+ (WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):
+ (WebCore::ScrollAnimator::notifyPositionChanged):
+ * platform/ScrollAnimator.h:
+ * platform/ScrollAnimatorNone.cpp:
+ (WebCore::ScrollAnimatorNone::scrollToOffsetWithoutAnimation):
+ (WebCore::ScrollAnimatorNone::animationTimerFired):
+ * platform/ScrollAnimatorWin.cpp:
+ (WebCore::ScrollAnimatorWin::scrollToOffsetWithoutAnimation):
+ (WebCore::ScrollAnimatorWin::animateScroll):
+ * platform/chromium/ScrollAnimatorChromiumMac.h:
+ * platform/chromium/ScrollAnimatorChromiumMac.mm:
+ (WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint):
+ (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaX):
+ (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaY):
+ (WebCore::ScrollAnimatorChromiumMac::notifyPositionChanged):
+ * platform/mac/ScrollAnimatorMac.h:
+ * platform/mac/ScrollAnimatorMac.mm:
+ (WebCore::ScrollAnimatorMac::immediateScrollToPoint):
+ (WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
+ (WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
+ (WebCore::ScrollAnimatorMac::notifyPositionChanged):
+
+2011-08-16 Joseph Pecoraro <joepeck@webkit.org>
+
+ ASSERT in fast/css/custom-font-xheight.html
+ https://bugs.webkit.org/show_bug.cgi?id=66328
+
+ Reviewed by Dan Bernstein.
+
+ In r93140 the temporary font created for a remote CSS font face
+ was created without being retained. We need to protect the
+ font from being purged while we hold onto it, so add a font cache
+ purge preventer.
+
+ * css/CSSFontFaceSource.cpp:
+ (WebCore::CSSFontFaceSource::getFontData):
+
+2011-08-16 Joseph Pecoraro <joepeck@webkit.org>
+
+ Unreviewed Chromium Windows build fix after r93140. Take 4.
+ Namespace the now public enum as FontCache::ShouldRetain.
+
+ * platform/graphics/chromium/FontCacheChromiumWin.cpp:
+ (WebCore::GetLastResortFallbackFontProcData::GetLastResortFallbackFontProcData):
+
+2011-08-15 Stephen White <senorblanco@chromium.org>
+
+ Canvas resizing can be slow
+ https://bugs.webkit.org/show_bug.cgi?id=66251
+
+ Canvas resizing was slow due to re-allocation of the ImageBuffer on
+ each size change (width or height). This was introduced inadvertently
+ by calls to isAccelerated() during canvas reset(). Since we won't
+ know if we have successfully accelerated until ImageBuffer creation,
+ move the compositor invalidation to createImageBuffer() as well.
+ This patch also attempts to unify the Skia and CG accelerated canvas
+ paths. The DrawingBuffer used by the Skia path is now owned by
+ ImageBuffer[Skia], similar to how the IOSurface is owned by
+ ImageBuffer[CG]. Some of the logic for when to accelerate was moved
+ into HTMLCanvasElement and unified with the CG path. Acceleration is
+ also now enabled by the same "Accelerated" ImageBuffer create flag
+ used by the CG path. DrawingBuffer is now re-created even for a
+ same-size change (same as the memory buffer), but we speed it up
+ by calling GraphicsContext3D::texImage2D() with a NULL pixels ptr
+ instead of GraphicsContext3D::teximage2DResourceSafe() (no need to
+ clear it, since it's done with a glClear anyway).
+
+ Reviewed by Kenneth Russell.
+
+ Covered by existing tests in fast/canvas and canvas/philip.
+
+ * html/HTMLCanvasElement.cpp:
+ (WebCore::HTMLCanvasElement::reset):
+ Don't call isAccelerated() from reset(), since we don't want to
+ inadvertently create the ImageBuffer. Also, since we won't know if
+ we have successfully accelerated until createImageBuffer() is
+ called, defer the compositor invalidation to createImageBuffer() as
+ well.
+ (WebCore::HTMLCanvasElement::shouldAccelerate):
+ Unify the CG and Skia ports' logic for when to accelerate (Skia
+ logic moved in from CanvasRenderingContext2D).
+ (WebCore::HTMLCanvasElement::createImageBuffer):
+ Use the unified shouldAccelerate() logic, and pass it as a flag
+ to ImageBuffer. Do compositor invalidation as well.
+ * html/HTMLCanvasElement.h:
+ (WebCore::HTMLCanvasElement::hasCreatedImageBuffer):
+ Expose hasCreatedImageBuffer() publically, so
+ CanvasRenderingContext2D::isAccelerated() doesn't inadvertently create
+ it.
+ * html/canvas/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
+ (WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
+ Remove all acceleration setting and resetting, since it's now done
+ during ImageBuffer creation.
+ (WebCore::CanvasRenderingContext2D::isAccelerated):
+ Check if the image buffer was created, so we don't inadvertently
+ create it here.
+ (WebCore::CanvasRenderingContext2D::paintsIntoCanvasBuffer):
+ Don't call GraphicsContext3D::paintsIntoCanvasBuffer(), since its
+ WebViewImpl may be null. Ask the render tree instead.
+ (WebCore::CanvasRenderingContext2D::reset):
+ Don't reset acceleration here, since we don't own it anymore.
+ (WebCore::CanvasRenderingContext2D::platformLayer):
+ Call into the ImageBuffer to get our PlatformLayer.
+ * html/canvas/CanvasRenderingContext2D.h:
+ Remove m_drawingBuffer, and all acceleration-related calls.
+ * platform/graphics/GraphicsContext.cpp:
+ * platform/graphics/GraphicsContext.h:
+ Remove setGraphicsContext3D(), and paintsIntoImageBuffer().
+ * platform/graphics/ImageBuffer.cpp:
+ (WebCore::ImageBuffer::platformLayer):
+ Implement a dummy platformLayer() call for non-skia ports.
+ * platform/graphics/ImageBuffer.h:
+ Declare a platformLayer() call (USE(ACCELERATED_COMPOSITING) only).
+ * platform/graphics/chromium/ImageBufferDataSkia.h:
+ Add a DrawingBuffer data member.
+ * platform/graphics/gpu/DrawingBuffer.cpp:
+ (WebCore::DrawingBuffer::reset):
+ Use texImage2D() with a NULL ptr, not texImage2DResourceSafe().
+ Since we immediately clear the framebuffer via glClear(), this whole
+ resource safe business is overkill.
+ * platform/graphics/skia/GraphicsContextSkia.cpp:
+ Remove setGraphicsContext3D() and paintsIntoImageBuffer(). This
+ functionality is handled by ImageBuffer now.
+ * platform/graphics/skia/ImageBufferSkia.cpp:
+ (WebCore::ImageBuffer::ImageBuffer):
+ Give the ImageBufferData ownership of the DrawingBuffer.
+ (WebCore::ImageBuffer::platformLayer):
+ Implement an accessor for the DrawingBuffer's PlatformLayer.
+ * platform/graphics/skia/PlatformContextSkia.cpp:
+ (WebCore::PlatformContextSkia::setGraphicsContext3D):
+ * platform/graphics/skia/PlatformContextSkia.h:
+ Remove isPathSkiaSafe() extern (unused).
+ Remove paintsIntoImageBuffer() (now unused). Remove IntSize param
+ from setGraphicsContext3D() (unused).
+
+2011-08-16 Joseph Pecoraro <joepeck@webkit.org>
+
+ Unreviewed Chromium Windows build fix after r93140. Take 3.
+ Include the proper includes!
+
+ * platform/graphics/FontCache.h:
+
+2011-08-16 Mihnea Ovidenie <mihnea@adobe.com>
+
+ Unmatrix algorithm implementation is wrong
+ https://bugs.webkit.org/show_bug.cgi?id=66080
+
+ Reviewed by Dean Jackson.
+
+ Current version of the algorithm negates only the scaleX while
+ it should negate also scaleY and scaleZ when appropriate.
+
+ Test: animations/animation-matrix-negative-scale-unmatrix.html
+
+ * platform/graphics/transforms/TransformationMatrix.cpp:
+ (WebCore::decompose):
+
+2011-08-16 Joseph Pecoraro <joepeck@webkit.org>
+
+ Unreviewed Chromium Windows build fix after r93140.
+
+ This just makes the troublesome enum public. If this
+ fixes the build I will file a follow-up bug to clean-up
+ these build issues and either keep the enum public and
+ cleanup other functions or restore the enum to private.
+ There is no harm in making the enum public right now.
+
+ * platform/graphics/FontCache.h:
+
+2011-08-16 Joseph Pecoraro <joepeck@webkit.org>
+
+ Unreviewed Chromium Windows build fix after r93140.
+
+ * platform/graphics/FontCache.h:
+
+2011-08-16 Joseph Pecoraro <joepeck@webkit.org>
+
+ Unreviewed Windows and Chromium Windows build fix after r93140.
+
+ * platform/graphics/FontCache.h:
+ * platform/graphics/chromium/FontCacheChromiumWin.cpp:
+ (WebCore::FontCache::fontDataFromDescriptionAndLogFont):
+ (WebCore::getLastResortFallbackFontProc):
+ (WebCore::FontCache::getLastResortFallbackFont):
+ * platform/graphics/win/FontCacheWin.cpp:
+ (WebCore::FontCache::fontDataFromDescriptionAndLogFont):
+ (WebCore::FontCache::getLastResortFallbackFont):
+
+2011-08-16 Adam Roben <aroben@apple.com>
+
+ Make placeholder text remain visible until a character is typed on Windows
+
+ Fixes <http://webkit.org/b/66319> Placeholder text in text fields disappears when the field
+ is focused on Windows, which doesn't match Lion or Windows native text fields
+
+ Covered by existing tests (which are currently failing on the bots until this patch lands).
+
+ Reviewed by Dave Hyatt.
+
+ * rendering/RenderThemeSafari.h:
+ (WebCore::RenderThemeSafari::shouldShowPlaceholderWhenFocused):
+ * rendering/RenderThemeWin.h:
+ (WebCore::RenderThemeWin::shouldShowPlaceholderWhenFocused):
+ Added overrides to return true.
+
+2011-08-16 David Hyatt <hyatt@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=66254
+
+ Make region invalidation and repainting work properly. We do this by making RenderFlowThreads into
+ repaint containers and then issuing new repaints in the regions that contain the invalidated flow thread
+ content.
+
+ Reviewed by Simon Fraser.
+
+ Added new tests in fast/repaint.
+
+ * rendering/RenderFlowThread.cpp:
+ (WebCore::RenderFlowThread::repaintRectangleInRegions):
+ * rendering/RenderFlowThread.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::enclosingRenderFlowThread):
+ (WebCore::RenderObject::containerForRepaint):
+ (WebCore::RenderObject::repaintUsingContainer):
+ * rendering/RenderObject.h:
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::RenderView):
+ (WebCore::RenderView::renderFlowThreadWithName):
+ * rendering/RenderView.h:
+ (WebCore::RenderView::hasRenderFlowThreads):
+
+2011-08-16 Joseph Pecoraro <joepeck@webkit.org>
+
+ Abandoned Memory: Temporary CSS Fonts May Never Be Purged
+ https://bugs.webkit.org/show_bug.cgi?id=66153
+
+ Reviewed by Dan Bernstein.
+
+ While a remote CSS font face is loading we fallback to a
+ temporary font. We don't want to retain the fallback font
+ because noone takes ownership of the temporary font. This
+ patch adds a way to get an uncached fallback font, which
+ plumbs the ShouldRetain enum through the different platform
+ implementations of getLastResortFallbackFont.
+
+ No new tests, no functional change.
+
+ * css/CSSFontFaceSource.cpp:
+ (WebCore::CSSFontFaceSource::getFontData):
+ * platform/graphics/FontCache.cpp:
+ (WebCore::FontCache::getNonRetainedLastResortFallbackFont):
+ * platform/graphics/FontCache.h:
+ * platform/graphics/chromium/FontCacheChromiumWin.cpp:
+ (WebCore::fontDataFromDescriptionAndLogFont):
+ (WebCore::GetLastResortFallbackFontProcData::GetLastResortFallbackFontProcData):
+ (WebCore::getLastResortFallbackFontProc):
+ (WebCore::FontCache::getLastResortFallbackFont):
+ * platform/graphics/chromium/FontCacheLinux.cpp:
+ (WebCore::FontCache::getLastResortFallbackFont):
+ * platform/graphics/freetype/FontCacheFreeType.cpp:
+ (WebCore::FontCache::getLastResortFallbackFont):
+ * platform/graphics/haiku/FontCacheHaiku.cpp:
+ (WebCore::FontCache::getLastResortFallbackFont):
+ * platform/graphics/mac/FontCacheMac.mm:
+ (WebCore::FontCache::getLastResortFallbackFont):
+ * platform/graphics/pango/FontCachePango.cpp:
+ (WebCore::FontCache::getLastResortFallbackFont):
+ * platform/graphics/qt/FontCacheQt.cpp:
+ (WebCore::FontCache::getLastResortFallbackFont):
+ * platform/graphics/win/FontCacheWin.cpp:
+ (WebCore::fontDataFromDescriptionAndLogFont):
+ (WebCore::FontCache::getLastResortFallbackFont):
+ * platform/graphics/wince/FontCacheWinCE.cpp:
+ * platform/graphics/wx/FontCacheWx.cpp:
+ (WebCore::FontCache::getLastResortFallbackFont):
+
+2011-08-16 Alexei Svitkine <asvitkine@chromium.org>
+
+ Chromium Mac: Rubber banding gutter drawing
+ https://bugs.webkit.org/show_bug.cgi?id=66226
+
+ Make ScrollView::paintOverhangAreas() use the ScrollbarTheme::nativeTheme() to
+ draw the overhang areas.
+ Move default implementation to ScrollbarThemeComposite::paintOverhangAreas().
+ Add a different implementation for Chromium Mac.
+
+ Reviewed by Dimitri Glazkov.
+
+ No new tests since this is just refactoring code and adding a Chromium-specific path for overhang drawing.
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::wheelEvent):
+ * platform/ScrollbarTheme.h:
+ (WebCore::ScrollbarTheme::paintOverhangAreas):
+ * platform/ScrollbarThemeComposite.cpp:
+ (WebCore::ScrollbarThemeComposite::paintOverhangAreas):
+ * platform/ScrollbarThemeComposite.h:
+ * platform/chromium/ScrollbarThemeChromiumMac.h:
+ * platform/chromium/ScrollbarThemeChromiumMac.mm:
+ (WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
+ (WebCore::scrollbarStateToThemeState):
+ (WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
+ (WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):
+
+2011-08-12 Wyatt Carss <wcarss@chromium.org>
+
+ Programmatically set selection should not have direction on Mac
+ https://bugs.webkit.org/show_bug.cgi?id=60529
+
+ Reviewed by Ryosuke Niwa.
+
+ Modified default value of VisibleSelection->m_isDirectional from 'true'
+ to 'false' by adding a defaulted argument to several VisibleSelection
+ constructors to make programmatic selection be directionless by default
+ on Mac. Also modified several calls to VisibleSelection's constructors
+ to correctly preserve directionality.
+
+ Near the end of FrameSelection::modify (presently FrameSelection.cpp:869)
+ a call to setExtent triggers an editing delegate that uses the
+ FrameSelection. The direction here should have been preserved from before,
+ but setIsDirectional was not called until after FrameSelection.cpp:869. It
+ has been moved up to make things behave.
+
+ * WebCore.exp.in:
+ * editing/ApplyBlockElementCommand.cpp:
+ (WebCore::ApplyBlockElementCommand::doApply):
+ (WebCore::ApplyBlockElementCommand::formatSelection):
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::ApplyStyleCommand::updateStartEnd):
+ * editing/BreakBlockquoteCommand.cpp:
+ (WebCore::BreakBlockquoteCommand::doApply):
+ * editing/CompositeEditCommand.cpp:
+ (WebCore::CompositeEditCommand::moveParagraphWithClones):
+ (WebCore::CompositeEditCommand::moveParagraphs):
+ (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
+ (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
+ * editing/CreateLinkCommand.cpp:
+ (WebCore::CreateLinkCommand::doApply):
+ * editing/DeleteSelectionCommand.cpp:
+ (WebCore::DeleteSelectionCommand::setStartingSelectionOnSmartDelete):
+ (WebCore::DeleteSelectionCommand::doApply):
+ * editing/Editor.cpp:
+ (WebCore::Editor::selectionForCommand):
+ * editing/FrameSelection.cpp:
+ (WebCore::shouldAlwaysUseDirectionalSelection):
+ (WebCore::FrameSelection::FrameSelection):
+ (WebCore::FrameSelection::moveTo):
+ (WebCore::FrameSelection::setNonDirectionalSelectionIfNeeded):
+ (WebCore::FrameSelection::modify):
+ (WebCore::FrameSelection::setBase):
+ (WebCore::FrameSelection::setExtent):
+ * editing/FrameSelection.h:
+ * editing/InsertLineBreakCommand.cpp:
+ (WebCore::InsertLineBreakCommand::doApply):
+ * editing/InsertListCommand.cpp:
+ (WebCore::InsertListCommand::doApply):
+ * editing/InsertParagraphSeparatorCommand.cpp:
+ (WebCore::InsertParagraphSeparatorCommand::doApply):
+ * editing/InsertTextCommand.cpp:
+ (WebCore::InsertTextCommand::performTrivialReplace):
+ (WebCore::InsertTextCommand::doApply):
+ * editing/MoveSelectionCommand.cpp:
+ (WebCore::MoveSelectionCommand::doApply):
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
+ * editing/TypingCommand.cpp:
+ (WebCore::TypingCommand::makeEditableRootEmpty):
+ (WebCore::TypingCommand::deleteKeyPressed):
+ (WebCore::TypingCommand::forwardDeleteKeyPressed):
+ * editing/VisibleSelection.cpp:
+ (WebCore::VisibleSelection::VisibleSelection):
+ * editing/VisibleSelection.h:
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::updateSelectionForMouseDownDispatchingSelectStart):
+ (WebCore::EventHandler::updateSelectionForMouseDrag):
+
+2011-08-16 Jeffrey Pfau <jpfau@apple.com>
+
+ New XML parser: Add document fragment parser
+ https://bugs.webkit.org/show_bug.cgi?id=66317
+
+ Reviewed by Adam Barth.
+
+ * dom/DocumentFragment.cpp:
+ (WebCore::DocumentFragment::parseXML):
+ * xml/parser/NewXMLDocumentParser.cpp:
+ (WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
+ (WebCore::NewXMLDocumentParser::parseDocumentFragment):
+ * xml/parser/NewXMLDocumentParser.h:
+ (WebCore::NewXMLDocumentParser::create):
+ * xml/parser/XMLTokenizer.h:
+ * xml/parser/XMLTreeBuilder.cpp:
+ (WebCore::XMLTreeBuilder::XMLTreeBuilder):
+ (WebCore::XMLTreeBuilder::pushCurrentNode):
+ * xml/parser/XMLTreeBuilder.h:
+ (WebCore::XMLTreeBuilder::create):
+ (WebCore::XMLTreeBuilder::NodeStackItem::node):
+
+2011-08-16 Jeffrey Pfau <jpfau@apple.com>
+
+ New XML parser: Replace assertions regarding character data in the prolog with proper checks
+ https://bugs.webkit.org/show_bug.cgi?id=66269
+
+ Reviewed by Adam Barth.
+
+ This patch checks for character data in the prolog (which is illegal in XML) and discards it, instead of failing an assertion.
+
+ * xml/parser/XMLTreeBuilder.cpp:
+ (WebCore::XMLTreeBuilder::processProcessingInstruction):
+ (WebCore::XMLTreeBuilder::processXMLDeclaration):
+ (WebCore::XMLTreeBuilder::processDOCTYPE):
+ (WebCore::XMLTreeBuilder::enterText):
+ (WebCore::XMLTreeBuilder::failOnText):
+ * xml/parser/XMLTreeBuilder.h:
+
+2011-08-16 Alexander Pavlov <apavlov@chromium.org>
+
+ Web Inspector: word wrap long edits
+ https://bugs.webkit.org/show_bug.cgi?id=65512
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/front-end/inspector.css:
+ (.styles-section .properties li.child-editing):
+
+2011-08-16 Pavel Feldman <pfeldman@google.com>
+
+ Web Inspector: convert DOM breakpoint types to strings.
+ https://bugs.webkit.org/show_bug.cgi?id=66304
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/Inspector.json:
+ * inspector/InspectorDOMDebuggerAgent.cpp:
+ (WebCore::domTypeForName):
+ (WebCore::InspectorDOMDebuggerAgent::setDOMBreakpoint):
+ (WebCore::InspectorDOMDebuggerAgent::removeDOMBreakpoint):
+ * inspector/InspectorDOMDebuggerAgent.h:
+ * inspector/front-end/DOMBreakpointsSidebarPane.js:
+ (WebInspector.DOMBreakpointsSidebarPane):
+
+2011-08-16 Pavel Feldman <pfeldman@google.com>
+
+ Web Inspector: force pseudo element state when checking it in the styles sidebar.
+ https://bugs.webkit.org/show_bug.cgi?id=66292
+
+ This reverts http://trac.webkit.org/changeset/89132 and introduces InspectorInstrumentation
+ calls from the CSSStyleSelector for pseudo state processing. These calls are very fast:
+ they are guarded with the inline checks for the front-end count.
+
+ Reviewed by David Hyatt.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::initForStyleResolve):
+ (WebCore::CSSStyleSelector::styleRulesForElement):
+ (WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
+ (WebCore::CSSStyleSelector::checkSelector):
+ (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
+ (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
+ * css/CSSStyleSelector.h:
+ * inspector/InspectorCSSAgent.cpp:
+ (WebCore::computePseudoClassMask):
+ (WebCore::InspectorCSSAgent::InspectorCSSAgent):
+ (WebCore::InspectorCSSAgent::clearFrontend):
+ (WebCore::InspectorCSSAgent::forcePseudoState):
+ (WebCore::InspectorCSSAgent::getStylesForNode):
+ (WebCore::InspectorCSSAgent::didRemoveDocument):
+ (WebCore::InspectorCSSAgent::didRemoveDOMNode):
+ (WebCore::InspectorCSSAgent::clearPseudoState):
+ * inspector/InspectorCSSAgent.h:
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::disconnectFrontend):
+ * inspector/InspectorInstrumentation.cpp:
+ (WebCore::InspectorInstrumentation::forcePseudoStateImpl):
+ * inspector/InspectorInstrumentation.h:
+ (WebCore::InspectorInstrumentation::forcePseudoState):
+
+2011-08-16 Tony Chang <tony@chromium.org>
+
+ Unreviewed, rolling out r93114.
+ http://trac.webkit.org/changeset/93114
+ https://bugs.webkit.org/show_bug.cgi?id=66226
+
+ broke the chromium mac compile
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::wheelEvent):
+ * platform/ScrollbarTheme.h:
+ * platform/ScrollbarThemeComposite.cpp:
+ * platform/ScrollbarThemeComposite.h:
+ * platform/chromium/ScrollbarThemeChromiumMac.h:
+ * platform/chromium/ScrollbarThemeChromiumMac.mm:
+ (WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
+ (WebCore::scrollbarStateToThemeState):
+ (WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
+ * platform/mac/ScrollbarThemeMac.h:
+
+2011-08-16 Alexei Svitkine <asvitkine@chromium.org>
+
+ Chromium Mac: Rubber banding gutter drawing
+ https://bugs.webkit.org/show_bug.cgi?id=66226
+
+ Make ScrollView::paintOverhangAreas() use the ScrollbarTheme::nativeTheme() to
+ draw the overhang areas.
+ Move default implementation to ScrollbarThemeComposite::paintOverhangAreas().
+ Add a different implementation for Chromium Mac.
+
+ Reviewed by Dimitri Glazkov.
+
+ No new tests since this is just refactoring code and adding a Chromium-specific path for overhang drawing.
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::wheelEvent):
+ * platform/ScrollbarTheme.h:
+ (WebCore::ScrollbarTheme::paintOverhangAreas):
+ * platform/ScrollbarThemeComposite.cpp:
+ (WebCore::ScrollbarThemeComposite::paintOverhangAreas):
+ * platform/ScrollbarThemeComposite.h:
+ * platform/chromium/ScrollbarThemeChromiumMac.h:
+ * platform/chromium/ScrollbarThemeChromiumMac.mm:
+ (WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
+ (WebCore::scrollbarStateToThemeState):
+ (WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
+ (WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):
+
+2011-08-16 Luke Macpherson <macpherson@chromium.org>
+
+ Support cast between CSSPrimitiveValue and ETransformStyle3D and use in CSSStyleSelector.
+ https://bugs.webkit.org/show_bug.cgi?id=66273
+
+ Reviewed by Simon Fraser.
+
+ No new tests - no functionality changed - refactoring only.
+
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ Define cast from CSSPrimitiveValue to ETransformStyle3D.
+ (WebCore::CSSPrimitiveValue::operator ETransformStyle3D):
+ Define cast from ETransformStyle3D to CSSPrimitiveValue.
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::applyProperty):
+ Use appropriate macro to handle CSSPropertyWebkitTransformStyle.
+
+2011-08-16 Luke Macpherson <macpherson@chromium.org>
+
+ Use appropriate macro to handle CSSPropertyWebkitContentOrder in CSSStyleSelector::applyProperty()
+ https://bugs.webkit.org/show_bug.cgi?id=66279
+
+ Reviewed by Simon Fraser.
+
+ No new tests - no functionality changed - simple refactoring only.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::applyProperty):
+ Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro to handle CSSPropertyWebkitContentOrder.
+ This works because PrimitiveValue now supports cast to int.
+
+2011-08-16 Eric Carlson <eric.carlson@apple.com>
+
+ [REGRESSION] Media controls should always be enabled when scripting is disabled
+ https://bugs.webkit.org/show_bug.cgi?id=66303
+
+ Reviewed by Dimitri Glazkov.
+
+ Tests: media/video-controls-no-scripting-iframe.html
+ media/video-controls-no-scripting.html
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::attributeChanged): Move the controls enabling/disabling code
+ to configureMediaControls.
+ (WebCore::HTMLMediaElement::prepareForLoad): Call configureMediaControls.
+ (WebCore::HTMLMediaElement::configureMediaControls): New, move code duplicated in
+ attributeChanged and preDispatchEventHandler here.
+ (WebCore::HTMLMediaElement::preDispatchEventHandler): Move the controls enabling/disabling code
+ to configureMediaControls.
+ * html/HTMLMediaElement.h:
+
+2011-08-16 Pavel Feldman <pfeldman@google.com>
+
+ Web Inspector: hide non-conservative methods from the protocol documentation.
+ https://bugs.webkit.org/show_bug.cgi?id=66301
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/Inspector.json:
+
+2011-08-16 Andras Becsi <abecsi@webkit.org>
+
+ Web Inspector: nuke background events collection (dead feature)
+ https://bugs.webkit.org/show_bug.cgi?id=66296
+
+ Fix the GTK build after r93095.
+
+ Unreviewed build fix.
+
+ No new tests neede.
+
+ * GNUmakefile.list.am: Remove nonexistent sources.
+
+2011-08-16 Andras Becsi <abecsi@webkit.org>
+
+ Reviewed by Csaba Osztrogon√°c.
+
+ Need AtomicStrings for the various font family names
+ https://bugs.webkit.org/show_bug.cgi?id=28024
+
+ Unify the usage of '-webkit' prefixed font family names by using
+ global AtomicStrings.
+ Use a .in file to generate the needed sources through make_names.pl.
+
+ No new tests needed.
+
+ * CMakeLists.txt:
+ * CodeGenerators.pri:
+ * DerivedSources.make:
+ * GNUmakefile.am:
+ * GNUmakefile.list.am:
+ * WebCore.gyp/WebCore.gyp:
+ * WebCore.gyp/scripts/action_makenames.py:
+ * WebCore.gypi:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::identifierForFamily):
+ * css/CSSFontSelector.cpp:
+ (WebCore::CSSFontSelector::addFontFaceRule):
+ (WebCore::fontDataForGenericFamily):
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::applyProperty):
+ * css/WebKitFontFamilyNames.in: Added.
+ * dom/make_names.pl:
+ * page/Frame.cpp:
+ (WebCore::Frame::Frame):
+ * platform/graphics/FontCache.cpp:
+ (WebCore::FontCache::getFontData):
+ * platform/graphics/FontDescription.h:
+ (WebCore::FontDescription::useFixedDefaultSize):
+
+2011-08-16 Pavel Feldman <pfeldman@google.com>
+
+ Web Inspector: nuke background events collection (dead feature)
+ https://bugs.webkit.org/show_bug.cgi?id=66296
+
+ Reviewed by Yury Semikhatsky.
+
+ * CMakeLists.txt:
+ * WebCore.gypi:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * inspector/EventsCollector.cpp: Removed.
+ * inspector/EventsCollector.h: Removed.
+ * inspector/Inspector.json:
+ * inspector/InspectorFrontendProxy.cpp: Removed.
+ * inspector/InspectorFrontendProxy.h: Removed.
+ * inspector/InspectorResourceAgent.cpp:
+ (WebCore::InspectorResourceAgent::setFrontend):
+ (WebCore::InspectorResourceAgent::clearFrontend):
+ (WebCore::InspectorResourceAgent::InspectorResourceAgent):
+ * inspector/InspectorResourceAgent.h:
+ * inspector/front-end/NetworkPanel.js:
+ (WebInspector.NetworkLogView):
+
+2011-08-16 Lindsay Mathieson <lindsay.mathieson@gmail.com>
+
+ [Qt] Missing spell check support
+ https://bugs.webkit.org/show_bug.cgi?id=44114
+
+ Reviewed by Benjamin Poulain.
+
+ Add drawErrorUnderline() from Cairo to render the line for text checking on the Qt port.
+
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ (WebCore::drawErrorUnderline):
+ (WebCore::GraphicsContext::drawLineForTextChecking):
+
+2011-08-15 MORITA Hajime <morrita@google.com>
+
+ REGRESSION(r70598): [Chromium] Style changes in textInput event can prevent from updating <textarea> value.
+ https://bugs.webkit.org/show_bug.cgi?id=66216
+
+ Reviewed by Ryosuke Niwa.
+
+ Element::spellcheckAttributeState() uses Element::hasAttribute(),
+ which calls updateStyleAttribute(), which potentially makes style
+ dirty. But that is problematic since Editor calls spellcheckAttributeState()
+ during the spell-checking phase and make the style dirty,
+ which can trigger re-layout, which wipes the shadow tree of a textarea
+ out by pre-committed "value" text.
+
+ This change removes the hasAttribute() call from
+ spellcheckAttributeState().
+
+ Test: editing/input/style-change-during-input.html
+
+ * dom/Element.cpp:
+ (WebCore::Element::spellcheckAttributeState):
+
+2011-08-15 Gyuyoung Kim <gyuyoung.kim@samsung.com>
+
+ [CMAKE] Wrap files of websocket and worker in each macro.
+ https://bugs.webkit.org/show_bug.cgi?id=65012
+
+ Move files of web socket and workers into each macro block in CMakeList.txt.
+ And, header files related to WORKER and SHARED_WORKER are wrapped by macro in cpp files.
+
+ Reviewed by Daniel Bates.
+
+ * CMakeLists.txt:
+ * UseJSC.cmake:
+ * bindings/js/JSDOMWindowCustom.cpp:
+ * bindings/js/JSWorkerContextBase.cpp:
+ * bindings/js/ScriptState.cpp:
+ * bindings/js/WorkerScriptController.cpp:
+
+2011-08-15 Jeffrey Pfau <jpfau@apple.com>
+
+ New XML parser: add xml namespace to the default map of namespaces
+ https://bugs.webkit.org/show_bug.cgi?id=66266
+
+ Reviewed by Adam Barth.
+
+ * xml/parser/XMLTreeBuilder.cpp:
+ (WebCore::XMLTreeBuilder::NodeStackItem::NodeStackItem):
+
+2011-08-15 Hayato Ito <hayato@chromium.org>
+
+ Fix crash when mouse moves from <summary> element to parent <details> element.
+ https://bugs.webkit.org/show_bug.cgi?id=66210
+
+ Reviewed by Dimitri Glazkov.
+
+ This is a regression caused by r92922, which wrongly assumes that
+ a shadow host always has a shadow root as an immediate child in
+ ancestors chain. This assumption does not apply to <details>
+ element. <details> element is implemented as a shadow host, but
+ may have a <summary> element as an immediate child element in
+ ancestors chain.
+
+ Test: fast/dom/shadow/details-summary-mouseover.html
+
+ * dom/EventDispatcher.cpp:
+ (WebCore::EventDispatcher::adjustToShadowBoundaries):
+
+2011-08-15 Jeffrey Pfau <jpfau@apple.com>
+
+ New XML parser: Use xmlnsAtom instead of redundant xmlnsPrefix
+ https://bugs.webkit.org/show_bug.cgi?id=66264
+
+ Reviewed by Adam Barth.
+
+ * xml/parser/XMLTreeBuilder.cpp:
+ (WebCore::XMLTreeBuilder::processNamespaces):
+ (WebCore::XMLTreeBuilder::processAttributes):
+
+2011-08-15 Emil A Eklund <eae@chromium.org>
+
+ Switch Element/Node to to new layout types
+ https://bugs.webkit.org/show_bug.cgi?id=66260
+
+ Reviewed by Eric Seidel.
+
+ Convert Element, Node, ElementRareData and ContainerNode to new layout
+ abstraction as a part of the ongoing conversion work.
+
+ No new tests, no new functionality.
+
+ * dom/ContainerNode.cpp:
+ (WebCore::ContainerNode::getLowerRightCorner):
+ (WebCore::ContainerNode::getRect):
+ * dom/ContainerNode.h:
+ * dom/Element.cpp:
+ (WebCore::Element::scrollIntoView):
+ (WebCore::Element::scrollIntoViewIfNeeded):
+ (WebCore::adjustForLocalZoom):
+ (WebCore::Element::boundsInWindowSpace):
+ (WebCore::Element::getClientRects):
+ (WebCore::Element::getBoundingClientRect):
+ (WebCore::Element::screenRect):
+ (WebCore::Element::minimumSizeForResizing):
+ (WebCore::Element::setMinimumSizeForResizing):
+ * dom/Element.h:
+ * dom/ElementRareData.h:
+ * dom/Node.cpp:
+ (WebCore::Node::getRect):
+ (WebCore::Node::renderRect):
+ (WebCore::Node::hasNonEmptyBoundingBox):
+ * dom/Node.h:
+
+2011-08-15 Alexey Proskuryakov <ap@apple.com>
+
+ Regional indicator symbols that are combined should behave as a single character when editing
+ https://bugs.webkit.org/show_bug.cgi?id=65395
+
+ Reviewed by Dan Bernstein.
+
+ Part one: make backspace work.
+
+ Test: editing/deleting/regional-indicators.html
+
+ * rendering/RenderText.cpp:
+ (WebCore::isRegionalIndicator):
+ (WebCore::RenderText::previousOffsetForBackwardDeletion): Added a special case for regional
+ indicator symbols.
+
+2011-08-15 Jeffrey Pfau <jpfau@apple.com>
+
+ New XML parser: Re-entering a character node should not clobber the buffered characters
+ https://bugs.webkit.org/show_bug.cgi?id=66257
+
+ Reviewed by Adam Barth.
+
+ * xml/parser/XMLTreeBuilder.cpp:
+ (WebCore::XMLTreeBuilder::enterText):
+
+2011-08-15 Dmitry Titov <dimich@chromium.org>
+
+ FrameLoaderClient::transferLoadingResourceFromPage does not have enough parameters
+ https://bugs.webkit.org/show_bug.cgi?id=66165
+
+ Reviewed by Darin Fisher.
+
+ No new tests since no change in behavior.
+ The original issue is only reproducible on Chromium in multi-process mode
+ and is tested there by a browsertest.
+
+ * loader/DocumentLoader.cpp:
+ (WebCore::DocumentLoader::transferLoadingResourcesFromPage):
+ Passing ResourceLoader* into the FrameLoaderClient notification.
+ Also, fixed the bug where the same ResourceRequest was passed for all subresources.
+ * loader/EmptyClients.h:
+ (WebCore::EmptyFrameLoaderClient::transferLoadingResourceFromPage):
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::dispatchTransferLoadingResourceFromPage):
+ * loader/FrameLoader.h:
+ * loader/FrameLoaderClient.h:
+ * loader/ResourceLoadNotifier.cpp:
+ (WebCore::ResourceLoadNotifier::dispatchTransferLoadingResourceFromPage):
+ * loader/ResourceLoadNotifier.h:
+ * loader/ResourceLoader.cpp:
+ (WebCore::ResourceLoader::init):
+ * loader/ResourceLoader.h:
+ (WebCore::ResourceLoader::originalRequest): Added the originalRequest() accessor that
+ returns the request as it existed before redirects (but after client's will SendRequest).
+ This is to be able to pass the original request for loading subresources into
+ FrameLoaderClient::transferLoadingResourceFromPage, since that one is used to invoke
+ assignIdentifierToInitialRequest, which needs original request.
+
+2011-08-15 Mark Hahnenberg <mhahnenberg@apple.com>
+
+ Refactor JS objects to allocate in static create methods rather than constructors
+ https://bugs.webkit.org/show_bug.cgi?id=65347
+
+ Reviewed by Geoffrey Garen.
+
+ No new tests.
+
+ Removed all calls to deprecatedGetDOMObject from initialization lists as part of a
+ larger refactoring to get rid of all allocation during initialization.
+
+ * bindings/js/JSDOMBinding.h:
+ * bridge/c/CRuntimeObject.cpp:
+ (JSC::Bindings::CRuntimeObject::CRuntimeObject):
+ * bridge/c/CRuntimeObject.h:
+ (JSC::Bindings::CRuntimeObject::create):
+ * bridge/c/c_instance.cpp:
+ (JSC::Bindings::CRuntimeMethod::create):
+ (JSC::Bindings::CRuntimeMethod::CRuntimeMethod):
+ * bridge/jni/jsc/JavaInstanceJSC.cpp:
+ (JavaRuntimeMethod::create):
+ (JavaRuntimeMethod::JavaRuntimeMethod):
+ * bridge/jni/jsc/JavaRuntimeObject.cpp:
+ (JSC::Bindings::JavaRuntimeObject::JavaRuntimeObject):
+ * bridge/jni/jsc/JavaRuntimeObject.h:
+ (JSC::Bindings::JavaRuntimeObject::create):
+ * bridge/objc/objc_runtime.h:
+ (JSC::Bindings::ObjcFallbackObjectImp::create):
+ * bridge/objc/objc_runtime.mm:
+ (JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
+ * bridge/qt/qt_instance.cpp:
+ (JSC::Bindings::QtRuntimeObject::create):
+ (JSC::Bindings::QtRuntimeObject::QtRuntimeObject):
+ * bridge/qt/qt_pixmapruntime.cpp:
+ (JSC::Bindings::QtPixmapRuntimeObject::create):
+ (JSC::Bindings::QtPixmapRuntimeObject::QtPixmapRuntimeObject):
+ * bridge/qt/qt_runtime.cpp:
+ (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
+ (JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):
+ (JSC::Bindings::QtRuntimeConnectionMethod::QtRuntimeConnectionMethod):
+ * bridge/qt/qt_runtime.h:
+ (JSC::Bindings::QtRuntimeMetaMethod::create):
+ (JSC::Bindings::QtRuntimeConnectionMethod::create):
+ * bridge/runtime_array.cpp:
+ (JSC::RuntimeArray::RuntimeArray):
+ * bridge/runtime_array.h:
+ (JSC::RuntimeArray::create):
+ * bridge/runtime_object.cpp:
+
+2011-08-15 Adam Roben <aroben@apple.com>
+
+ Update pages' style and content scale when the window's backing scale factor changes
+
+ Unfortunately, I couldn't think of a way to test this in an automated fashion.
+
+ Fixes <http://webkit.org/b/66229> <rdar://problem/9906269> WebKit doesn't react to device
+ scale factor changes
+
+ Reviewed by Simon Fraser.
+
+ * WebCore.exp.in: Export Frame::deviceOrScaleFactorChanged.
+
+ * page/Frame.cpp:
+ (WebCore::Frame::deviceScaleFactorChanged):
+ * page/Frame.h:
+ Added this new function. We recalc style so that, e.g., device-scale-factor-dependent media
+ queries will be reevaluated, and we tell compositing layers about the new scale factor so
+ they can rerender at the new resolution.
+
+2011-08-15 Cary Clark <caryclark@google.com>
+
+ Revise Skia on Chrome Mac to return fallback fonts.
+ https://bugs.webkit.org/show_bug.cgi?id=62986
+
+ Reviewed by Darin Fisher.
+
+ Since Skia on Chrome Mac uses CoreText to determine
+ text metrics, CG font architecture is used to return
+ fallback fonts.
+
+ This improves many existing layout tests, including
+ justify-ideograph-simple and t0905-c414-flt-04-c
+
+ * platform/graphics/skia/FontSkia.cpp:
+ (WebCore::Font::canReturnFallbackFontsForComplexText):
+
+2011-08-15 Aaron Boodman <aa@chromium.org>
+
+ Pass additional details to client in didCreateIsolatedContext
+ https://bugs.webkit.org/show_bug.cgi?id=66037
+
+ Reviewed by Darin Fisher.
+
+ * bindings/v8/IsolatedWorld.cpp:
+ (WebCore::IsolatedWorld::IsolatedWorld):
+ * bindings/v8/IsolatedWorld.h:
+ (WebCore::IsolatedWorld::create):
+ (WebCore::IsolatedWorld::id):
+ * bindings/v8/V8IsolatedContext.cpp:
+ (WebCore::V8IsolatedContext::V8IsolatedContext):
+ * bindings/v8/V8IsolatedContext.h:
+ * bindings/v8/V8Proxy.cpp:
+ (WebCore::V8Proxy::evaluateInIsolatedWorld):
+ * loader/EmptyClients.h:
+ (WebCore::EmptyFrameLoaderClient::didCreateIsolatedScriptContext):
+ * loader/FrameLoaderClient.h:
+
+2011-08-15 Chris Rogers <crogers@google.com>
+
+ Add shell implementation for Web Audio API's MediaElementAudioSourceNode
+ https://bugs.webkit.org/show_bug.cgi?id=66175
+
+ Reviewed by Kenneth Russell.
+
+ Test: webaudio/mediaelementaudiosourcenode.html
+
+ * DerivedSources.make:
+ * WebCore.gypi:
+ * WebCore.xcodeproj/project.pbxproj:
+ * html/HTMLMediaElement.idl:
+ * webaudio/AudioContext.cpp:
+ (WebCore::AudioContext::createMediaElementSource):
+ * webaudio/AudioContext.h:
+ * webaudio/AudioContext.idl:
+ * webaudio/AudioNode.h:
+ * webaudio/MediaElementAudioSourceNode.cpp: Added.
+ (WebCore::MediaElementAudioSourceNode::create):
+ (WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):
+ (WebCore::MediaElementAudioSourceNode::process):
+ (WebCore::MediaElementAudioSourceNode::reset):
+ * webaudio/MediaElementAudioSourceNode.h: Added.
+ (WebCore::MediaElementAudioSourceNode::mediaElement):
+ * webaudio/MediaElementAudioSourceNode.idl: Added.
+
+2011-08-15 Emil A Eklund <eae@chromium.org>
+
+ Switch mouse events to to new layout types
+ https://bugs.webkit.org/show_bug.cgi?id=66179
+
+ Reviewed by Eric Seidel.
+
+ Convert mouse events to new layout abstraction as a part of the ongoing
+ conversion work.
+
+ No new tests, no new functionality.
+
+ * dom/MouseRelatedEvent.cpp:
+ (WebCore::contentsScrollOffset):
+ (WebCore::MouseRelatedEvent::MouseRelatedEvent):
+ (WebCore::MouseRelatedEvent::initCoordinates):
+ (WebCore::MouseRelatedEvent::computePageLocation):
+ (WebCore::MouseRelatedEvent::computeRelativePosition):
+ (WebCore::MouseRelatedEvent::pageLocation):
+ * dom/MouseRelatedEvent.h:
+ (WebCore::MouseRelatedEvent::screenLocation):
+ (WebCore::MouseRelatedEvent::clientLocation):
+ (WebCore::MouseRelatedEvent::absoluteLocation):
+ (WebCore::MouseRelatedEvent::setAbsoluteLocation):
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::clear):
+ (WebCore::EventHandler::handleMousePressEventSingleClick):
+ (WebCore::selectionExtentRespectingEditingBoundary):
+ (WebCore::EventHandler::hitTestResultAtPoint):
+ (WebCore::EventHandler::currentMousePosition):
+ (WebCore::documentPointForWindowPoint):
+ (WebCore::EventHandler::handleMousePressEvent):
+ (WebCore::EventHandler::mouseMoved):
+ (WebCore::EventHandler::handleWheelEvent):
+ (WebCore::EventHandler::sendContextMenuEvent):
+ (WebCore::EventHandler::sendContextMenuEventForKey):
+ (WebCore::EventHandler::fakeMouseMoveEventTimerFired):
+ (WebCore::EventHandler::dragHysteresisExceeded):
+ (WebCore::EventHandler::handleDrag):
+ (WebCore::EventHandler::handleTouchEvent):
+ * page/EventHandler.h:
+ * platform/PlatformMouseEvent.h:
+ (WebCore::PlatformMouseEvent::PlatformMouseEvent):
+ (WebCore::PlatformMouseEvent::pos):
+ (WebCore::PlatformMouseEvent::x):
+ (WebCore::PlatformMouseEvent::y):
+ (WebCore::PlatformMouseEvent::globalX):
+ (WebCore::PlatformMouseEvent::globalY):
+ * platform/mac/PlatformMouseEventMac.mm:
+ (WebCore::globalPoint):
+ (WebCore::pointForEvent):
+ (WebCore::globalPointForEvent):
+
+2011-08-15 Ryosuke Niwa <rniwa@webkit.org>
+
+ webkit-indent-blockquote is unnecessary
+ https://bugs.webkit.org/show_bug.cgi?id=66195
+
+ Reviewed by Tony Chang.
+
+ Stop adding class="webkit-indent-blockquote" on blockquotes created by execCommand('Indent') and
+ execCommand('Outdent'). Also removed the code to add the class attribute in ApplyBlockElementCommand
+ since no other class inherited from ApplyBlockElementCommand uses this feature.
+
+ * editing/ApplyBlockElementCommand.cpp:
+ (WebCore::ApplyBlockElementCommand::ApplyBlockElementCommand):
+ (WebCore::ApplyBlockElementCommand::createBlockElement):
+ * editing/ApplyBlockElementCommand.h:
+ * editing/IndentOutdentCommand.cpp:
+ (WebCore::IndentOutdentCommand::IndentOutdentCommand):
+
+2011-08-15 Levi Weintraub <leviw@chromium.org>
+
+ Switch remaining SVG Rendering methods to LayoutUnits
+ https://bugs.webkit.org/show_bug.cgi?id=66169
+
+ Reviewed by Eric Seidel.
+
+ Changing remaining integer SVG methods to use the LayoutUnits abstraction.
+
+ No tests as no change in functionality.
+
+ * rendering/svg/RenderSVGBlock.cpp:
+ (WebCore::RenderSVGBlock::visualOverflowRect):
+ * rendering/svg/RenderSVGBlock.h:
+ * rendering/svg/RenderSVGContainer.cpp:
+ (WebCore::RenderSVGContainer::paint):
+ * rendering/svg/RenderSVGForeignObject.cpp:
+ (WebCore::RenderSVGForeignObject::paint):
+ (WebCore::RenderSVGForeignObject::clippedOverflowRectForRepaint):
+ (WebCore::RenderSVGForeignObject::computeRectForRepaint):
+ * rendering/svg/RenderSVGHiddenContainer.cpp:
+ (WebCore::RenderSVGHiddenContainer::paint):
+ * rendering/svg/RenderSVGImage.cpp:
+ (WebCore::RenderSVGImage::paint):
+ * rendering/svg/RenderSVGInlineText.cpp:
+ (WebCore::RenderSVGInlineText::linesBoundingBox):
+ * rendering/svg/RenderSVGInlineText.h:
+ * rendering/svg/RenderSVGModelObject.cpp:
+ (WebCore::RenderSVGModelObject::outlineBoundsForRepaint):
+ * rendering/svg/RenderSVGPath.cpp:
+ (WebCore::RenderSVGPath::paint):
+ * rendering/svg/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::localToBorderBoxTransform):
+ (WebCore::RenderSVGRoot::parentOriginToBorderBox):
+ (WebCore::RenderSVGRoot::borderOriginToContentBox):
+ (WebCore::RenderSVGRoot::localToRepaintContainerTransform):
+ (WebCore::RenderSVGRoot::localToParentTransform):
+ (WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):
+ (WebCore::RenderSVGRoot::computeRectForRepaint):
+ * rendering/svg/RenderSVGRoot.h:
+ * rendering/svg/RenderSVGText.cpp:
+ (WebCore::RenderSVGText::paint):
+ * rendering/svg/SVGInlineFlowBox.cpp:
+ (WebCore::SVGInlineFlowBox::paint):
+ * rendering/svg/SVGInlineTextBox.cpp:
+ (WebCore::SVGInlineTextBox::paint):
+ * rendering/svg/SVGRenderSupport.cpp:
+ (WebCore::SVGRenderSupport::clippedOverflowRectForRepaint):
+ (WebCore::SVGRenderSupport::computeRectForRepaint):
+ * rendering/svg/SVGRenderSupport.h:
+ * rendering/svg/SVGRootInlineBox.cpp:
+ (WebCore::SVGRootInlineBox::paint):
+ (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
+ (WebCore::SVGRootInlineBox::layoutChildBoxes):
+ (WebCore::SVGRootInlineBox::layoutRootBox):
+ (WebCore::SVGRootInlineBox::closestLeafChildForPosition):
+ * rendering/svg/SVGRootInlineBox.h:
+
+2011-08-12 Jeff Miller <jeffm@apple.com>
+
+ MediaPlayerPrivateAVFoundationCF::playerItemStatus() should return MediaPlayerAVPlayerItemStatusDoesNotExist if there is no AVPlayerItem
+ https://bugs.webkit.org/show_bug.cgi?id=66171
+
+ MediaPlayerPrivateAVFoundationCF::playerItemStatus() should return MediaPlayerAVPlayerItemStatusDoesNotExist if there is no AVPlayerItem
+ to match the Mac implementation in MediaPlayerPrivateAVFoundationObjC. I also added better logging to notificationCallback().
+
+ Reviewed by Jon Honeycutt.
+
+ No new tests, uses existing media tests.
+
+ * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:
+ (WebCore::MediaPlayerPrivateAVFoundationCF::playerItemStatus): Return MediaPlayerAVPlayerItemStatusDoesNotExist if no AVPlayerItem.
+ (WebCore::AVFWrapper::notificationCallback): Log the name of the received notification.
+
+2011-08-15 Adam Roben <aroben@apple.com>
+
+ Rename an instance of pageScaleFactorChanged I missed in r93040
+
+ I tried to make a test for this but failed. It would probably have been easier if we dumped
+ layers' content scales in layerTreeAsText output.
+
+ Followup to <http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to
+ the device scale factor
+
+ * platform/graphics/ca/GraphicsLayerCA.cpp:
+ (WebCore::GraphicsLayerCA::deviceOrPageScaleFactorChanged):
+ * platform/graphics/ca/GraphicsLayerCA.h:
+ Renamed from pageScaleFactorChanged to match the base class.
+
2011-08-15 Pavel Feldman <pfeldman@google.com>
Web Inspector: [V8] crash upon stepIn while not on pause.
« no previous file with comments | « no previous file | Source/WebCore/loader/FrameLoader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698