Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 7711002: This changes ProfileManager::GetProfileInfoCache() to be GetProfileInfo() and (Closed)

Created:
9 years, 4 months ago by Robert Sesek
Modified:
9 years, 4 months ago
Reviewers:
Miranda Callahan, sail
CC:
chromium-reviews, estade+watch_chromium.org, rginda+watch_chromium.org, achuith+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

This changes ProfileManager::GetProfileInfoCache() to be GetProfileInfo() and returning the ProfileInfoInterface, making it easier to mock out for testing. In the few places that require the full ProfileInfoCache, GetMutableProfileInfo() was added. Because a handful of Mac unittests make calls into g_browser_process for the ProfileManager, BrowserTestHelper was expanded to set that up with a TestingProfile and a FakeProfileInfo so that tests continue to pass. BUG=60105 TEST=Covered by unit tests and browser tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97709

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -34 lines) Patch
M chrome/browser/profiles/fake_profile_info_interface.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager.h View 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/avatar_button.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_test_helper.h View 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_test_helper.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/browser_titlebar.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/profile_menu_model.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/avatar_menu_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_sync_setup_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/personal_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/test/base/testing_profile_manager.h View 1 chunk +59 lines, -0 lines 0 comments Download
A chrome/test/base/testing_profile_manager.cc View 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Robert Sesek
Splitting out of http://codereview.chromium.org/7648037/ to prevent bitrot and so I can continue working on different ...
9 years, 4 months ago (2011-08-22 15:47:36 UTC) #1
Miranda Callahan
9 years, 4 months ago (2011-08-22 17:57:16 UTC) #2
On 2011/08/22 15:47:36, rsesek wrote:
> Splitting out of http://codereview.chromium.org/7648037/ to prevent bitrot and
> so I can continue working on different profile stuff while
> sync_integration_tests are being fixed.

LGTM!

Powered by Google App Engine
This is Rietveld 408576698