tools/pnacl-thaw/pnacl-thaw.cpp - Issue 770853002: Fix error reporting in the PNaCl bitcode reader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/pnacl-thaw/pnacl-thaw.cpp

Issue 770853002: Fix error reporting in the PNaCl bitcode reader. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-llvm.git@master

Patch Set: Fix nits. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/pnacl-thaw/pnacl-thaw.cpp

diff --git a/tools/pnacl-thaw/pnacl-thaw.cpp b/tools/pnacl-thaw/pnacl-thaw.cpp

index ef252ceab52f8c2c3adee61149f78327b0c5fa66..e0a2d2a1a72e55bd905529dd592d1db0f8fa18ce 100644

--- a/tools/pnacl-thaw/pnacl-thaw.cpp

+++ b/tools/pnacl-thaw/pnacl-thaw.cpp

@@ -74,7 +74,8 @@ int main(int argc, char **argv) {

else

DisplayFilename = InputFilename;

M.reset(getNaClStreamedBitcodeModule(DisplayFilename, Buffer.release(),

- Context, &ErrorMessage,

+ Context, /*VerboseErrors=*/false,

jvoung (off chromium) 2014/12/01 23:23:50 Why not set VerboseErrors to true for commandline

Karl 2014/12/03 18:32:10 Done.

+ &ErrorMessage,

/*AcceptSupportedOnly=*/false));

if (M.get())

if (std::error_code EC = M->materializeAllPermanently()) {

« tools/llvm-nm/llvm-nm.cpp ('K') | « tools/pnacl-llc/pnacl-llc.cpp ('k') | no next file » | no next file with comments »