Fix error reporting in the PNaCl bitcode reader.

tools/pnacl-thaw/pnacl-thaw.cpp

 /* Copyright 2013 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can
  * be found in the LICENSE file.
  */
 
 //===-- pnacl-thaw.cpp - The low-level NaCl bitcode thawer ----------------===//
 //
 //===----------------------------------------------------------------------===//
 //
 // Converts NaCl wire format back to LLVM bitcode.
@@ skipping 56 matching lines @@
   DataStreamer *streamer = getDataFileStreamer(InputFilename, &ErrorMessage);
   std::unique_ptr<StreamingMemoryObject> Buffer(
       new StreamingMemoryObjectImpl(streamer));
   if (streamer) {
     std::string DisplayFilename;
     if (InputFilename == "-")
       DisplayFilename = "<stdin>";
     else
       DisplayFilename = InputFilename;
     M.reset(getNaClStreamedBitcodeModule(DisplayFilename, Buffer.release(),
-                                         Context, &ErrorMessage,
+                                         Context, /*VerboseErrors=*/false,

[jvoung (off chromium), 2014/12/01 23:23:50]

Why not set VerboseErrors to true for commandline tools?

[Karl, 2014/12/03 18:32:10]

Done.

+                                         &ErrorMessage,
                                          /*AcceptSupportedOnly=*/false));
     if (M.get())
       if (std::error_code EC = M->materializeAllPermanently()) {
         ErrorMessage = EC.message();
         M.reset();
       }
   }
 
   if (!M.get()) {
     errs() << argv[0] << ": ";
     if (ErrorMessage.size())
       errs() << ErrorMessage << "\n";
     else
       errs() << "bitcode didn't read correctly.\n";
     return 1;
   }
 
   WriteOutputFile(M.get());
   return 0;
 }