Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: tools/llvm-nm/llvm-nm.cpp

Issue 770853002: Fix error reporting in the PNaCl bitcode reader. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-llvm.git@master
Patch Set: Fix nits. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/llvm-nm/llvm-nm.cpp
diff --git a/tools/llvm-nm/llvm-nm.cpp b/tools/llvm-nm/llvm-nm.cpp
index 2c346e51a1fef59b3f69ae2ef8c35027f1628db4..890b48ca111d94b833308d8afa9cf67bfdc0ae55 100644
--- a/tools/llvm-nm/llvm-nm.cpp
+++ b/tools/llvm-nm/llvm-nm.cpp
@@ -1011,14 +1011,13 @@ static void dumpSymbolNamesFromFile(std::string &Filename) {
// Support parsing PNaCl bitcode files
/* TODO(jfb) This is currently broken: the code base now requires an Object.
if (InputFileFormat == PNaClFormat) {
- std::string ErrorMessage;
- Module *Result = NaClParseBitcodeFile(BufferOrErr.get().release(), Context,
- &ErrorMessage);
+ ErrorOr<Module *>Result =
jvoung (off chromium) 2014/12/01 23:23:50 space between > and Result
Karl 2014/12/03 18:32:10 Done.
+ NaClParseBitcodeFile(BufferOrErr.get().release(), Context);
if (Result) {
- DumpSymbolNamesFromModule(Result);
+ DumpSymbolNamesFromModule(Result.get());
delete Result;
} else {
- error(ErrorMessage, Filename);
+ error(Result.message(), Filename);
return;
}
}

Powered by Google App Engine
This is Rietveld 408576698