lib/IR/Module.cpp - Issue 770853002: Fix error reporting in the PNaCl bitcode reader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/IR/Module.cpp

Issue 770853002: Fix error reporting in the PNaCl bitcode reader. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-llvm.git@master

Patch Set: Fix nits. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/IR/Module.cpp

diff --git a/lib/IR/Module.cpp b/lib/IR/Module.cpp

index f1b1f9a2acc877f094343c5c0bfbbe1919891346..0d2600f85b5e05adb297c9b880f2b5b0e732c033 100644

--- a/lib/IR/Module.cpp

+++ b/lib/IR/Module.cpp

@@ -26,6 +26,7 @@

#include "llvm/Support/Dwarf.h"

#include "llvm/Support/Path.h"

#include "llvm/Support/RandomNumberGenerator.h"

+#include "llvm/Support/raw_ostream.h"

#include <algorithm>

#include <cstdarg>

#include <cstdlib>

@@ -394,7 +395,9 @@ bool Module::Materialize(GlobalValue *GV, std::string *ErrInfo) {

if (!Materializer)

return false;

+ errs() << "-> Module::Materialize\n";

jvoung (off chromium) 2014/12/01 23:23:50 I assume these are for debugging -- can these be r

Karl 2014/12/03 18:32:10 Reverted and removed from CL.

std::error_code EC = Materializer->Materialize(GV);

+ errs() << "<- Module::Materialize\n";

if (!EC)

return false;

if (ErrInfo)

« lib/Bitcode/NaCl/Reader/NaClBitcodeReader.cpp ('K') | « lib/Bitcode/NaCl/Reader/NaClBitcodeReader.cpp ('k') | lib/IRReader/IRReader.cpp » ('j') | lib/IRReader/IRReader.cpp » ('J')