Fix error reporting in the PNaCl bitcode reader.

lib/IR/Module.cpp

 //===-- Module.cpp - Implement the Module class ---------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file implements the Module class for the IR library.
 //
 //===----------------------------------------------------------------------===//
 
 #include "llvm/IR/Module.h"
 #include "SymbolTableListTraitsImpl.h"
 #include "llvm/ADT/DenseSet.h"
 #include "llvm/ADT/STLExtras.h"
 #include "llvm/ADT/SmallString.h"
 #include "llvm/ADT/StringExtras.h"
 #include "llvm/IR/Constants.h"
 #include "llvm/IR/DerivedTypes.h"
 #include "llvm/IR/GVMaterializer.h"
 #include "llvm/IR/InstrTypes.h"
 #include "llvm/IR/LLVMContext.h"
 #include "llvm/IR/LeakDetector.h"
 #include "llvm/Support/Dwarf.h"
 #include "llvm/Support/Path.h"
 #include "llvm/Support/RandomNumberGenerator.h"
+#include "llvm/Support/raw_ostream.h"
 #include <algorithm>
 #include <cstdarg>
 #include <cstdlib>
 using namespace llvm;
 
 //===----------------------------------------------------------------------===//
 // Methods to implement the globals and functions lists.
 //
 
 // Explicit instantiations of SymbolTableListTraits since some of the methods
@@ skipping 348 matching lines @@
 bool Module::isDematerializable(const GlobalValue *GV) const {
   if (Materializer)
     return Materializer->isDematerializable(GV);
   return false;
 }
 
 bool Module::Materialize(GlobalValue *GV, std::string *ErrInfo) {
   if (!Materializer)
     return false;
 
+  errs() << "-> Module::Materialize\n";

[jvoung (off chromium), 2014/12/01 23:23:50]

I assume these are for debugging -- can these be removed now?

[Karl, 2014/12/03 18:32:10]

Reverted and removed from CL.

   std::error_code EC = Materializer->Materialize(GV);
+  errs() << "<- Module::Materialize\n";
   if (!EC)
     return false;
   if (ErrInfo)
     *ErrInfo = EC.message();
   return true;
 }
 
 void Module::Dematerialize(GlobalValue *GV) {
   if (Materializer)
     return Materializer->Dematerialize(GV);
@@ skipping 46 matching lines @@
   return cast<ConstantInt>(Val)->getZExtValue();
 }
 
 Comdat *Module::getOrInsertComdat(StringRef Name) {
   Comdat C;
   StringMapEntry<Comdat> &Entry =
       ComdatSymTab.GetOrCreateValue(Name, std::move(C));
   Entry.second.Name = &Entry;
   return &Entry.second;
 }