Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 77053003: Remove the first_right_arg hack for HMod. (Closed)

Created:
7 years, 1 month ago by Benedikt Meurer
Modified:
7 years, 1 month ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Remove the first_right_arg hack for HMod. Generate a proper subgraph in BuildBinaryOperation instead. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17919

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -118 lines) Patch
M src/arm/lithium-arm.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +17 lines, -2 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +2 lines, -10 lines 0 comments Download
M src/hydrogen-instructions.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
7 years, 1 month ago (2013-11-20 12:34:21 UTC) #1
Sven Panne
lgtm
7 years, 1 month ago (2013-11-20 12:42:47 UTC) #2
Benedikt Meurer
7 years, 1 month ago (2013-11-20 12:43:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17919.

Powered by Google App Engine
This is Rietveld 408576698