Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1421)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 77053003: Remove the first_right_arg hack for HMod. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1465 matching lines...) Expand 10 before | Expand all | Expand 10 after
1476 ASSERT(instr->right()->representation().Equals(instr->representation())); 1476 ASSERT(instr->right()->representation().Equals(instr->representation()));
1477 if (instr->HasPowerOf2Divisor()) { 1477 if (instr->HasPowerOf2Divisor()) {
1478 ASSERT(!right->CanBeZero()); 1478 ASSERT(!right->CanBeZero());
1479 LModI* mod = new(zone()) LModI(UseRegisterAtStart(left), 1479 LModI* mod = new(zone()) LModI(UseRegisterAtStart(left),
1480 UseOrConstant(right)); 1480 UseOrConstant(right));
1481 LInstruction* result = DefineAsRegister(mod); 1481 LInstruction* result = DefineAsRegister(mod);
1482 return (left->CanBeNegative() && 1482 return (left->CanBeNegative() &&
1483 instr->CheckFlag(HValue::kBailoutOnMinusZero)) 1483 instr->CheckFlag(HValue::kBailoutOnMinusZero))
1484 ? AssignEnvironment(result) 1484 ? AssignEnvironment(result)
1485 : result; 1485 : result;
1486 } else if (instr->fixed_right_arg().has_value) {
1487 LModI* mod = new(zone()) LModI(UseRegisterAtStart(left),
1488 UseRegisterAtStart(right));
1489 return AssignEnvironment(DefineAsRegister(mod));
1490 } else if (CpuFeatures::IsSupported(SUDIV)) { 1486 } else if (CpuFeatures::IsSupported(SUDIV)) {
1491 LModI* mod = new(zone()) LModI(UseRegister(left), 1487 LModI* mod = new(zone()) LModI(UseRegister(left),
1492 UseRegister(right)); 1488 UseRegister(right));
1493 LInstruction* result = DefineAsRegister(mod); 1489 LInstruction* result = DefineAsRegister(mod);
1494 return (right->CanBeZero() || 1490 return (right->CanBeZero() ||
1495 (left->RangeCanInclude(kMinInt) && 1491 (left->RangeCanInclude(kMinInt) &&
1496 right->RangeCanInclude(-1) && 1492 right->RangeCanInclude(-1) &&
1497 instr->CheckFlag(HValue::kBailoutOnMinusZero)) || 1493 instr->CheckFlag(HValue::kBailoutOnMinusZero)) ||
1498 (left->CanBeNegative() && 1494 (left->CanBeNegative() &&
1499 instr->CanBeZero() && 1495 instr->CanBeZero() &&
(...skipping 1190 matching lines...) Expand 10 before | Expand all | Expand 10 after
2690 2686
2691 2687
2692 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2688 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2693 LOperand* object = UseRegister(instr->object()); 2689 LOperand* object = UseRegister(instr->object());
2694 LOperand* index = UseRegister(instr->index()); 2690 LOperand* index = UseRegister(instr->index());
2695 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2691 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2696 } 2692 }
2697 2693
2698 2694
2699 } } // namespace v8::internal 2695 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698