runtime/vm/intermediate_language_arm.cc - Issue 770303002: Support non-deoptimizing version of UnboxInt32 for integer definitions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_arm.cc

Issue 770303002: Support non-deoptimizing version of UnboxInt32 for integer definitions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_arm.cc

diff --git a/runtime/vm/intermediate_language_arm.cc b/runtime/vm/intermediate_language_arm.cc

index 4391ca6daf617b25971ccb69336645cd635badcb..41bbb8825eb1aec64530ff50ae2fa565861c6b58 100644

--- a/runtime/vm/intermediate_language_arm.cc

+++ b/runtime/vm/intermediate_language_arm.cc

@@ -3992,6 +3992,11 @@ void UnboxInteger32Instr::EmitNativeCode(FlowGraphCompiler* compiler) {

__ SmiUntag(out, value);

} else if (value_cid == kMintCid) {

LoadInt32FromMint(compiler, value, out, temp, out_of_range);

+ } else if (!CanDeoptimize()) {

+ Label done;

+ __ SmiUntag(out, value, &done);

+ LoadInt32FromMint(compiler, value, out, temp, out_of_range);

Florian Schneider 2014/12/02 13:12:03 s/out_of_range/NULL/ since it is always NULL in t

Vyacheslav Egorov (Google) 2014/12/02 13:15:58 Done.

+ __ Bind(&done);

} else {

Label done;

__ SmiUntag(out, value, &done);

« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | runtime/vm/intermediate_language_mips.cc » ('J')