runtime/vm/intermediate_language.cc - Issue 770303002: Support non-deoptimizing version of UnboxInt32 for integer definitions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language.cc

Issue 770303002: Support non-deoptimizing version of UnboxInt32 for integer definitions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language.cc

diff --git a/runtime/vm/intermediate_language.cc b/runtime/vm/intermediate_language.cc

index 9ac5c3f17b0cb244839ec07a06e0bcb5c7d45b5c..ee0de86035a61a6388c64e06d1eed1bf67f6cb05 100644

--- a/runtime/vm/intermediate_language.cc

+++ b/runtime/vm/intermediate_language.cc

@@ -1202,6 +1202,10 @@ bool UnboxInt32Instr::CanDeoptimize() const {

return !is_truncating() &&

!RangeUtils::Fits(value()->definition()->range(),

RangeBoundary::kRangeBoundaryInt32);

+ } else if ((kSmiBits < 32) && value()->Type()->IsInt()) {

+ // Note: we don't support truncation of Bigint values.

+ return !RangeUtils::Fits(value()->definition()->range(),

+ RangeBoundary::kRangeBoundaryInt32);

} else {

return true;

}

« no previous file with comments | « no previous file | runtime/vm/intermediate_language_arm.cc » ('j') | runtime/vm/intermediate_language_arm.cc » ('J')