DescriptionRevert of Improve logic in ensureDefaultStyleSheetsForElement (patchset #1 id:1 of https://codereview.chromium.org/708713004/)
Reason for revert:
Seems to be the cause of assertion failures like:
crash log for renderer (pid 30072):
STDOUT: #CRASHED - renderer (pid 30072)
STDERR: Xlib: extension "RANDR" missing on display ":9".
STDERR: [30072:30072:1017/090946:3443219798580:ERROR:renderer_main.cc(227)] Running without renderer sandbox
STDERR: [30090:30090:1017/090946:3443219850178:ERROR:renderer_main.cc(227)] Running without renderer sandbox
STDERR: ASSERTION FAILED: !value || (value->isInitialValue())
STDERR: ../../third_party/WebKit/Source/core/css/CSSLineBoxContainValue.h(59) : const WebCore::CSSLineBoxContainValue* WebCore::toCSSLineBoxContainValue(const WebCore::CSSValue*)
Example failing build:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20%28dbg%29/builds/19815
Please file bugs for changes like this in the future so there is a permanent record of any reverts and re-lands.
Original issue's description:
> Improve logic in ensureDefaultStyleSheetsForElement
>
> Improve logic in ensureDefaultStyleSheetsForElement, there
> is no need for example to test namespace for Mathml if we
> already established the element is an SVG element.
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186262
TBR=esprehn@chromium.org,rob.buis@samsung.com
NOTREECHECKS=true
NOTRY=true
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186272
Patch Set 1 #
Created: 6 years ago
(Patch set is too large to download)
Messages
Total messages: 3 (0 generated)
|