Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 770103002: Revert of Improve logic in ensureDefaultStyleSheetsForElement (Closed)

Created:
6 years ago by Ken Russell (switch to Gerrit)
Modified:
6 years ago
Reviewers:
esprehn, rwlbuis
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Improve logic in ensureDefaultStyleSheetsForElement (patchset #1 id:1 of https://codereview.chromium.org/708713004/) Reason for revert: Seems to be the cause of assertion failures like: crash log for renderer (pid 30072): STDOUT: #CRASHED - renderer (pid 30072) STDERR: Xlib: extension "RANDR" missing on display ":9". STDERR: [30072:30072:1017/090946:3443219798580:ERROR:renderer_main.cc(227)] Running without renderer sandbox STDERR: [30090:30090:1017/090946:3443219850178:ERROR:renderer_main.cc(227)] Running without renderer sandbox STDERR: ASSERTION FAILED: !value || (value->isInitialValue()) STDERR: ../../third_party/WebKit/Source/core/css/CSSLineBoxContainValue.h(59) : const WebCore::CSSLineBoxContainValue* WebCore::toCSSLineBoxContainValue(const WebCore::CSSValue*) Example failing build: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20%28dbg%29/builds/19815 Please file bugs for changes like this in the future so there is a permanent record of any reverts and re-lands. Original issue's description: > Improve logic in ensureDefaultStyleSheetsForElement > > Improve logic in ensureDefaultStyleSheetsForElement, there > is no need for example to test namespace for Mathml if we > already established the element is an SVG element. > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186262 TBR=esprehn@chromium.org,rob.buis@samsung.com NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186272

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -25 lines) Patch
M Source/core/css/CSSDefaultStyleSheets.cpp View 1 chunk +24 lines, -25 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ken Russell (switch to Gerrit)
Created Revert of Improve logic in ensureDefaultStyleSheetsForElement
6 years ago (2014-12-02 01:13:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/770103002/1
6 years ago (2014-12-02 01:14:44 UTC) #2
commit-bot: I haz the power
6 years ago (2014-12-02 01:15:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186272

Powered by Google App Engine
This is Rietveld 408576698