Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 769533004: Fuse GrReplacements and GrLayerCache (Closed)

Created:
6 years ago by robertphillips
Modified:
6 years ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fuse GrReplacements and GrLayerCache The conversion step from GrCachedLayer to ReplacementInfo isn't necessary. Committed: https://skia.googlesource.com/skia/+/e99d499caa7dbc80b58e0faf5ce137e7d30cc5d0

Patch Set 1 #

Patch Set 2 : Clean up #

Patch Set 3 : clang #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -310 lines) Patch
M src/core/SkLayerInfo.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkMultiPictureDraw.cpp View 2 chunks +3 lines, -6 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrLayerCache.h View 1 2 11 chunks +23 lines, -23 lines 0 comments Download
M src/gpu/GrLayerCache.cpp View 1 2 6 chunks +8 lines, -9 lines 0 comments Download
M src/gpu/GrLayerHoister.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrLayerHoister.cpp View 6 chunks +4 lines, -52 lines 0 comments Download
M src/gpu/GrRecordReplaceDraw.h View 1 chunk +2 lines, -107 lines 0 comments Download
M src/gpu/GrRecordReplaceDraw.cpp View 1 2 6 chunks +37 lines, -54 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
M tests/GpuLayerCacheTest.cpp View 1 2 8 chunks +16 lines, -15 lines 0 comments Download
M tests/RecordReplaceDrawTest.cpp View 1 2 5 chunks +37 lines, -30 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
robertphillips
6 years ago (2014-12-02 14:58:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/769533004/20001
6 years ago (2014-12-02 14:58:56 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-02 14:58:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/914) Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot/builds/925)
6 years ago (2014-12-02 15:00:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/769533004/40001
6 years ago (2014-12-02 15:53:59 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-02 15:54:00 UTC) #10
robertphillips
ping
6 years ago (2014-12-03 13:41:44 UTC) #12
bsalomon
On 2014/12/03 13:41:44, robertphillips wrote: > ping Sorry, got distracted by our visitors yesterday and ...
6 years ago (2014-12-03 14:39:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/769533004/40001
6 years ago (2014-12-03 15:33:47 UTC) #15
commit-bot: I haz the power
6 years ago (2014-12-03 15:34:06 UTC) #16
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/e99d499caa7dbc80b58e0faf5ce137e7d30cc5d0

Powered by Google App Engine
This is Rietveld 408576698