Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 769323002: Make SkColorTable explicitly thread-safe. (Closed)

Created:
6 years ago by mtklein_C
Modified:
6 years ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Make SkColorTable explicitly thread-safe. Mostly this means using SkLazyPtr for the 16-bit cache. We can remove the copy constructor now and just ref it instead. BUG=skia: Committed: https://skia.googlesource.com/skia/+/cc969c4dd936c97670788395c9cbee3f346e87d1

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -32 lines) Patch
M include/core/SkColorTable.h View 2 chunks +10 lines, -10 lines 2 comments Download
M src/core/SkBitmap.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkColorTable.cpp View 2 chunks +17 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtklein
6 years ago (2014-12-02 17:44:50 UTC) #2
reed1
lgtm w/ thought about const fields https://codereview.chromium.org/769323002/diff/1/include/core/SkColorTable.h File include/core/SkColorTable.h (right): https://codereview.chromium.org/769323002/diff/1/include/core/SkColorTable.h#newcode60 include/core/SkColorTable.h:60: int fCount; can ...
6 years ago (2014-12-02 17:46:31 UTC) #3
mtklein
https://codereview.chromium.org/769323002/diff/1/include/core/SkColorTable.h File include/core/SkColorTable.h (right): https://codereview.chromium.org/769323002/diff/1/include/core/SkColorTable.h#newcode60 include/core/SkColorTable.h:60: int fCount; On 2014/12/02 17:46:31, reed1 wrote: > can ...
6 years ago (2014-12-02 17:51:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/769323002/1
6 years ago (2014-12-02 17:52:18 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-02 18:02:52 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cc969c4dd936c97670788395c9cbee3f346e87d1

Powered by Google App Engine
This is Rietveld 408576698