Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.h

Issue 769153007: Managed bookmarks for supervised users (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
index 3ad4c5bb742a885ecf6e73a7e7a177b673d875ec..e352c7453188944a7c305ad3bddf35a10b48dff2 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
@@ -300,6 +300,9 @@ class BookmarkBarView : public views::AccessiblePaneView,
// Creates the button showing the "Managed Bookmarks" folder.
views::MenuButton* CreateManagedBookmarksButton();
+ // Creates the button showing the supervised bookmarks items.
+ views::MenuButton* CreateSupervisedBookmarksButton();
+
// Creates the button used when not all bookmark buttons fit.
views::MenuButton* CreateOverflowButton();
@@ -363,8 +366,9 @@ class BookmarkBarView : public views::AccessiblePaneView,
// Updates the colors for all the child objects in the bookmarks bar.
void UpdateColors();
- // Updates the visibility of |other_bookmarks_button_| and
- // |managed_bookmarks_button_|. Also shows or hides the separator if required.
+ // Updates the visibility of |other_bookmarks_button_|,
+ // |managed_bookmarks_button_|, and |supervised_bookmarks_button_|. Also
+ // shows or hides the separator if required.
// Returns true if something changed and a LayoutAndPaint() is needed.
bool UpdateOtherAndManagedButtonsVisibility();
@@ -413,6 +417,9 @@ class BookmarkBarView : public views::AccessiblePaneView,
// Shows the managed bookmarks entries.
views::MenuButton* managed_bookmarks_button_;
+ // Shows the supervised bookmarks entries.
+ views::MenuButton* supervised_bookmarks_button_;
Pam (message me for reviews) 2015/01/14 14:03:37 It seems strange to me that the supervised bookmar
Marc Treib 2015/01/14 16:40:50 Where else would they appear? I suppose we would a
Pam (message me for reviews) 2015/01/15 11:37:04 I expected them to be flat on the bookmarks bar, i
Marc Treib 2015/01/15 12:30:09 FWIW, in the new bookmarks UI (which should launch
+
// Shows the Apps page shortcut.
views::LabelButton* apps_page_shortcut_;

Powered by Google App Engine
This is Rietveld 408576698